[jira] [Commented] (ZOOKEEPER-2264) Wrong error message when secureClientPortAddress is configured but secureClientPort is not configured

["Rakesh R (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14732484#comment-14732484 ] 

Rakesh R commented on ZOOKEEPER-2264:
-------------------------------------

Thanks [~arshad.mohammad] for the contribution!

Committed to br3.5 : http://svn.apache.org/viewvc?view=revision&revision=1701506
Committed to trunk : http://svn.apache.org/viewvc?view=revision&revision=1701505

> Wrong error message when secureClientPortAddress is configured but secureClientPort is not configured 
> ------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2264
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2264
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Arshad Mohammad
>            Assignee: Arshad Mohammad
>            Priority: Minor
>             Fix For: 3.5.2
>
>         Attachments: ZOOKEEPER-2264-01.patch
>
>
> # Wrong error message when secureClientPortAddress is configured but secureClientPort is not configured.
> zookeeper throws IllegalArgumentException with error message {{clientPortAddress is set but clientPort is not set}} but should be {{secureClientPortAddress is set but secureClientPort is not set}}
> # There is another problem with the same code.
> value is assigned to local variable but null check is done on instance variable so we will never get error message for this scenario.
> {code}if (this.secureClientPortAddress != null) {{code}
> should be replaced with 
> {code}if (secureClientPortAddress != null) {{code}
> # Above problem is there for clientPort scenario also. So we should replace
> {code}if (this.clientPortAddress != null) {{code}
> with 
> {code}if (clientPortAddress != null) {{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)