You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/13 08:49:34 UTC

[GitHub] [flink] fsk119 opened a new pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

fsk119 opened a new pull request #12880:
URL: https://github.com/apache/flink/pull/12880


   …ed by string-based Configuration
   
   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   *Make TableConfig options can be configured by string-based configuration.*
   
   ## Brief change log
   
     - *Add config options*
     - *Use ConfigOption to get/set data.*
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
     - *Use get/set method to test read/write is correct*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (**yes** / no)
     - If yes, how is the feature documented? (not applicable / **docs** / JavaDocs / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12880:
URL: https://github.com/apache/flink/pull/12880#issuecomment-657437173


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0265191d170ed07f0980cf370b418f656159e49d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4432",
       "triggerID" : "0265191d170ed07f0980cf370b418f656159e49d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0265191d170ed07f0980cf370b418f656159e49d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4432) 
   * 34ee9488f149038dddd3227b9408bed674240a1a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] fsk119 commented on a change in pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

fsk119 commented on a change in pull request #12880:
URL: https://github.com/apache/flink/pull/12880#discussion_r465678917



##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableConfig.java
##########
@@ -286,20 +276,43 @@ public void setIdleStateRetentionTime(Time minTime, Time maxTime) {
 		}
 		minIdleStateRetentionTime = minTime.toMilliseconds();
 		maxIdleStateRetentionTime = maxTime.toMilliseconds();
+		setIdleStateRetentionDuration(Duration.ofMillis(minIdleStateRetentionTime));
+	}
+
+	/**
+	 * Specifies a retention time interval for how long idle state, i.e., state which
+	 * was not updated, will be retained.
+	 * State will never be cleared until it was idle for less than the retention time and will never
+	 * be kept if it was idle for more than the 1.5 * retention time.
+	 *
+	 * <p>When new data arrives for previously cleaned-up state, the new data will be handled as if it
+	 * was the first data. This can result in previous results being overwritten.
+	 *
+	 * <p>Set to 0 (zero) to never clean-up the state.
+	 *
+	 * <p>NOTE: Cleaning up state requires additional bookkeeping which becomes less expensive for
+	 * larger differences of minTime and maxTime. The difference between minTime and maxTime must be
+	 * at least 5 minutes.
+	 *
+	 * @param duration The retention time interval for which idle state is retained. Set to 0 (zero) to
+	 *                never clean-up the state.

Review comment:
       If we use the same function name with different parametere list, it will get strange thing on python side. We can only use one of the `setIdleStateRetentionTime` in python. So the only option is to use the method name `setIdleStateRetention`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12880:
URL: https://github.com/apache/flink/pull/12880#issuecomment-657437173


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0265191d170ed07f0980cf370b418f656159e49d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4432",
       "triggerID" : "0265191d170ed07f0980cf370b418f656159e49d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4447",
       "triggerID" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4470",
       "triggerID" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5207",
       "triggerID" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5225",
       "triggerID" : "c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "82edfc5569e7d434ecd56a872b2f56015df3a851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5232",
       "triggerID" : "82edfc5569e7d434ecd56a872b2f56015df3a851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5f9cc66b6457e7a28b137f82fe24bbff14fda84d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5278",
       "triggerID" : "5f9cc66b6457e7a28b137f82fe24bbff14fda84d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f213639e4e38e9e25506c20d7eff660cadbb6b1",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5286",
       "triggerID" : "1f213639e4e38e9e25506c20d7eff660cadbb6b1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1f213639e4e38e9e25506c20d7eff660cadbb6b1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5286) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12880:
URL: https://github.com/apache/flink/pull/12880#issuecomment-657437173


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0265191d170ed07f0980cf370b418f656159e49d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4432",
       "triggerID" : "0265191d170ed07f0980cf370b418f656159e49d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4447",
       "triggerID" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4470",
       "triggerID" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5207",
       "triggerID" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5225",
       "triggerID" : "c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "82edfc5569e7d434ecd56a872b2f56015df3a851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5232",
       "triggerID" : "82edfc5569e7d434ecd56a872b2f56015df3a851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5f9cc66b6457e7a28b137f82fe24bbff14fda84d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5278",
       "triggerID" : "5f9cc66b6457e7a28b137f82fe24bbff14fda84d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f213639e4e38e9e25506c20d7eff660cadbb6b1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5286",
       "triggerID" : "1f213639e4e38e9e25506c20d7eff660cadbb6b1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "94e8eb39032665f77e897cb572cd4320b66635f9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5703",
       "triggerID" : "94e8eb39032665f77e897cb572cd4320b66635f9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "72e7dcb66f3a2c6eda4899d51ddd6420d2d5822b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5744",
       "triggerID" : "72e7dcb66f3a2c6eda4899d51ddd6420d2d5822b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "607b519de6a6421d13b4bfa0b2414761ac8fccb4",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5907",
       "triggerID" : "607b519de6a6421d13b4bfa0b2414761ac8fccb4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 72e7dcb66f3a2c6eda4899d51ddd6420d2d5822b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5744) 
   * 607b519de6a6421d13b4bfa0b2414761ac8fccb4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5907) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12880:
URL: https://github.com/apache/flink/pull/12880#issuecomment-657437173


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0265191d170ed07f0980cf370b418f656159e49d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4432",
       "triggerID" : "0265191d170ed07f0980cf370b418f656159e49d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4447",
       "triggerID" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4470",
       "triggerID" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5207",
       "triggerID" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 05fede7e394cf0d1a7ba614d1411fa15141c3c65 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4470) 
   * 5e007a083820aed78298cd519ae17e3762b5fa53 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5207) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wuchong commented on a change in pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

wuchong commented on a change in pull request #12880:
URL: https://github.com/apache/flink/pull/12880#discussion_r466872581



##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/ExecutionConfigOptions.java
##########
@@ -37,9 +39,24 @@
 @PublicEvolving
 public class ExecutionConfigOptions {
 
+	// ------------------------------------------------------------------------
+	//  State Options
+	// ------------------------------------------------------------------------
+
+	@Documentation.TableOption(execMode = Documentation.ExecMode.STREAMING)
+	public static final ConfigOption<Duration> IDLE_STATE_RETENTION =
+		key("table.exec.state.ttl")
+			.durationType()
+			.defaultValue(Duration.ofMillis(0))
+			.withDescription("A time-to-live (TTL) can be assigned to the keyed state of any type. " +
+				"If a TTL is configured and a state value has expired, " +
+				"the stored value will be cleaned up on a best effort basis. " +
+				"Default value is 0, which means that it will never clean up state.");

Review comment:
       ```suggestion
   			.withDescription("Specifies a minimum time interval for how long idle state " +
   					"(i.e. state which was not updated), will be retained. State will never be " +
   					"cleared until it was idle for less than the minimum time, and will be cleared " +
   					"at some time after it was idle. Default is never clean-up the state.\n" +
   					"NOTE: Cleaning up state requires additional overhead for bookkeeping.\n" +
   					"Default value is 0, which means that it will never clean up state.");
   ```

##########
File path: flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/api/TableConfigTest.java
##########
@@ -0,0 +1,137 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.api;
+
+import org.apache.flink.configuration.Configuration;
+
+import org.junit.Test;
+
+import java.time.Duration;
+import java.time.ZoneId;
+import java.util.Arrays;
+import java.util.List;
+import java.util.function.BiConsumer;
+import java.util.function.Function;
+
+import static org.hamcrest.CoreMatchers.equalTo;
+import static org.junit.Assert.assertThat;
+
+/**
+ * Tests for {@link TableConfig}.
+ */
+public class TableConfigTest {

Review comment:
       We don't need to refactor it into `TestSpec`. There is limited methods to test. We can have a test for each option. 
   The TestSpec is not easy to understand and can't test some special methods, e.g. `setIdleStateRetentionTime(Time minTime, Time maxTime)`

##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/TableConfigOptions.java
##########
@@ -51,4 +52,24 @@ private TableConfigOptions() {}
 			.withDescription("The SQL dialect defines how to parse a SQL query. " +
 					"A different SQL dialect may support different SQL grammar. " +
 					"Currently supported dialects are: default and hive");
+
+	@Documentation.TableOption(execMode = Documentation.ExecMode.BATCH_STREAMING)
+	public static final ConfigOption<String> LOCAL_TIME_ZONE = key("table.local-time-zone")
+			.stringType()
+			// special value to decide whether to use ZoneId.systemDefault() in TableConfig.getLocalTimeZone()
+			.defaultValue("default")
+			.withDescription("The local time zone defines current session time zone id. It is used when converting to/from " +
+				"<code>TIMESTAMP_WITH_LOCAL_TIME_ZONE</code>. Internally, timestamps with local time zone are always represented in the UTC time zone. " +
+				"However, when converting to data types that don't include a time zone (e.g. TIMESTAMP, TIME, or simply STRING), " +
+				"the session time zone is used during conversion. The input of option is either an abbreviation such as \"PST\", a full name " +
+				"such as \"America/Los_Angeles\", or a custom timezone_id such as \"GMT-8:00\".");

Review comment:
       ```suggestion
   			.withDescription("The local time zone defines current session time zone id. It is used when converting to/from " +
   				"<code>TIMESTAMP WITH LOCAL TIME ZONE</code>. Internally, timestamps with local time zone are always represented in the UTC time zone. " +
   				"However, when converting to data types that don't include a time zone (e.g. TIMESTAMP, TIME, or simply STRING), " +
   				"the session time zone is used during conversion. The input of option is either an abbreviation such as \"PST\", a full name " +
   				"such as \"America/Los_Angeles\", or a custom timezone id such as \"GMT-8:00\".");
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12880:
URL: https://github.com/apache/flink/pull/12880#issuecomment-657437173


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0265191d170ed07f0980cf370b418f656159e49d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4432",
       "triggerID" : "0265191d170ed07f0980cf370b418f656159e49d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4447",
       "triggerID" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4470",
       "triggerID" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5207",
       "triggerID" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5225",
       "triggerID" : "c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "82edfc5569e7d434ecd56a872b2f56015df3a851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5232",
       "triggerID" : "82edfc5569e7d434ecd56a872b2f56015df3a851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5f9cc66b6457e7a28b137f82fe24bbff14fda84d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5278",
       "triggerID" : "5f9cc66b6457e7a28b137f82fe24bbff14fda84d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f213639e4e38e9e25506c20d7eff660cadbb6b1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5286",
       "triggerID" : "1f213639e4e38e9e25506c20d7eff660cadbb6b1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "94e8eb39032665f77e897cb572cd4320b66635f9",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5703",
       "triggerID" : "94e8eb39032665f77e897cb572cd4320b66635f9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "72e7dcb66f3a2c6eda4899d51ddd6420d2d5822b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "72e7dcb66f3a2c6eda4899d51ddd6420d2d5822b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 94e8eb39032665f77e897cb572cd4320b66635f9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5703) 
   * 72e7dcb66f3a2c6eda4899d51ddd6420d2d5822b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #12880:
URL: https://github.com/apache/flink/pull/12880#issuecomment-657437173


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0265191d170ed07f0980cf370b418f656159e49d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0265191d170ed07f0980cf370b418f656159e49d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0265191d170ed07f0980cf370b418f656159e49d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #12880:
URL: https://github.com/apache/flink/pull/12880#issuecomment-657418153

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit 0265191d170ed07f0980cf370b418f656159e49d (Mon Jul 13 08:51:11 UTC 2020)

**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.

Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:

- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wuchong commented on pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

wuchong commented on pull request #12880:
URL: https://github.com/apache/flink/pull/12880#issuecomment-676895558


   There are some failures in the build:
   
   ```
   ================flake8 checks=================
   ./pyflink/table/table_config.py:193:101: E501 line too long (105 > 100 characters)
   ./pyflink/table/table_config.py:194:101: E501 line too long (105 > 100 characters)
   ./pyflink/table/table_config.py:195:101: E501 line too long (101 > 100 characters)
   ./pyflink/table/table_config.py:209:101: E501 line too long (105 > 100 characters)
   ./pyflink/table/table_config.py:210:101: E501 line too long (105 > 100 characters)
   ./pyflink/table/table_config.py:211:101: E501 line too long (101 > 100 characters)
   ./pyflink/table/table_config.py:225:101: E501 line too long (103 > 100 characters)
   
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12880:
URL: https://github.com/apache/flink/pull/12880#issuecomment-657437173


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0265191d170ed07f0980cf370b418f656159e49d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4432",
       "triggerID" : "0265191d170ed07f0980cf370b418f656159e49d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4447",
       "triggerID" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 34ee9488f149038dddd3227b9408bed674240a1a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4447) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12880:
URL: https://github.com/apache/flink/pull/12880#issuecomment-657437173


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0265191d170ed07f0980cf370b418f656159e49d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4432",
       "triggerID" : "0265191d170ed07f0980cf370b418f656159e49d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4447",
       "triggerID" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4470",
       "triggerID" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5207",
       "triggerID" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5225",
       "triggerID" : "c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "82edfc5569e7d434ecd56a872b2f56015df3a851",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5232",
       "triggerID" : "82edfc5569e7d434ecd56a872b2f56015df3a851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5f9cc66b6457e7a28b137f82fe24bbff14fda84d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5278",
       "triggerID" : "5f9cc66b6457e7a28b137f82fe24bbff14fda84d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 82edfc5569e7d434ecd56a872b2f56015df3a851 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5232) 
   * 5f9cc66b6457e7a28b137f82fe24bbff14fda84d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5278) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12880:
URL: https://github.com/apache/flink/pull/12880#issuecomment-657437173


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0265191d170ed07f0980cf370b418f656159e49d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4432",
       "triggerID" : "0265191d170ed07f0980cf370b418f656159e49d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4447",
       "triggerID" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4470",
       "triggerID" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5207",
       "triggerID" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5225",
       "triggerID" : "c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "82edfc5569e7d434ecd56a872b2f56015df3a851",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5232",
       "triggerID" : "82edfc5569e7d434ecd56a872b2f56015df3a851",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 82edfc5569e7d434ecd56a872b2f56015df3a851 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5232) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12880:
URL: https://github.com/apache/flink/pull/12880#issuecomment-657437173


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0265191d170ed07f0980cf370b418f656159e49d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4432",
       "triggerID" : "0265191d170ed07f0980cf370b418f656159e49d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4447",
       "triggerID" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4470",
       "triggerID" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 34ee9488f149038dddd3227b9408bed674240a1a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4447) 
   * 05fede7e394cf0d1a7ba614d1411fa15141c3c65 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4470) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12880:
URL: https://github.com/apache/flink/pull/12880#issuecomment-657437173


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0265191d170ed07f0980cf370b418f656159e49d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4432",
       "triggerID" : "0265191d170ed07f0980cf370b418f656159e49d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4447",
       "triggerID" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4470",
       "triggerID" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5207",
       "triggerID" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5225",
       "triggerID" : "c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "82edfc5569e7d434ecd56a872b2f56015df3a851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5232",
       "triggerID" : "82edfc5569e7d434ecd56a872b2f56015df3a851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5f9cc66b6457e7a28b137f82fe24bbff14fda84d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5278",
       "triggerID" : "5f9cc66b6457e7a28b137f82fe24bbff14fda84d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f213639e4e38e9e25506c20d7eff660cadbb6b1",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1f213639e4e38e9e25506c20d7eff660cadbb6b1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5f9cc66b6457e7a28b137f82fe24bbff14fda84d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5278) 
   * 1f213639e4e38e9e25506c20d7eff660cadbb6b1 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12880:
URL: https://github.com/apache/flink/pull/12880#issuecomment-657437173


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0265191d170ed07f0980cf370b418f656159e49d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4432",
       "triggerID" : "0265191d170ed07f0980cf370b418f656159e49d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0265191d170ed07f0980cf370b418f656159e49d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4432) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12880:
URL: https://github.com/apache/flink/pull/12880#issuecomment-657437173


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0265191d170ed07f0980cf370b418f656159e49d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4432",
       "triggerID" : "0265191d170ed07f0980cf370b418f656159e49d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4447",
       "triggerID" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4470",
       "triggerID" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5207",
       "triggerID" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5e007a083820aed78298cd519ae17e3762b5fa53 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5207) 
   * c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] fsk119 commented on pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

fsk119 commented on pull request #12880:
URL: https://github.com/apache/flink/pull/12880#issuecomment-657998421


   CC @wuchong 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wuchong commented on a change in pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

wuchong commented on a change in pull request #12880:
URL: https://github.com/apache/flink/pull/12880#discussion_r460697474



##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/TableConfigOptions.java
##########
@@ -51,4 +52,24 @@ private TableConfigOptions() {}
 			.withDescription("The SQL dialect defines how to parse a SQL query. " +
 					"A different SQL dialect may support different SQL grammar. " +
 					"Currently supported dialects are: default and hive");
+
+	@Documentation.TableOption(execMode = Documentation.ExecMode.BATCH_STREAMING)
+	public static final ConfigOption<String> LOCAL_TIME_ZONE = key("table.local-time-zone")
+			.stringType()
+			// special value to decide whether to use ZoneId.systemDefault() in TableConfig.getLocalTimeZone()
+			.defaultValue("System")

Review comment:
       What about to use `(system-default)` here? It will be more like a system default value like `(none)`.  
   Besides, please store the "(system-default)" in a static final variable. 

##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableConfig.java
##########
@@ -286,20 +276,43 @@ public void setIdleStateRetentionTime(Time minTime, Time maxTime) {
 		}
 		minIdleStateRetentionTime = minTime.toMilliseconds();
 		maxIdleStateRetentionTime = maxTime.toMilliseconds();

Review comment:
       The member variables `minIdleStateRetentionTime`, `maxIdleStateRetentionTime` can be removed? 

##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableConfig.java
##########
@@ -286,20 +276,43 @@ public void setIdleStateRetentionTime(Time minTime, Time maxTime) {
 		}
 		minIdleStateRetentionTime = minTime.toMilliseconds();
 		maxIdleStateRetentionTime = maxTime.toMilliseconds();
+		setIdleStateRetentionDuration(Duration.ofMillis(minIdleStateRetentionTime));
+	}
+
+	/**
+	 * Specifies a retention time interval for how long idle state, i.e., state which
+	 * was not updated, will be retained.
+	 * State will never be cleared until it was idle for less than the retention time and will never
+	 * be kept if it was idle for more than the 1.5 * retention time.
+	 *
+	 * <p>When new data arrives for previously cleaned-up state, the new data will be handled as if it
+	 * was the first data. This can result in previous results being overwritten.
+	 *
+	 * <p>Set to 0 (zero) to never clean-up the state.
+	 *
+	 * <p>NOTE: Cleaning up state requires additional bookkeeping which becomes less expensive for
+	 * larger differences of minTime and maxTime. The difference between minTime and maxTime must be
+	 * at least 5 minutes.
+	 *
+	 * @param duration The retention time interval for which idle state is retained. Set to 0 (zero) to
+	 *                never clean-up the state.
+	 */
+	public void setIdleStateRetentionDuration(Duration duration){
+		configuration.set(ExecutionConfigOptions.IDLE_STATE_RETENTION, duration);
 	}
 
 	/**
 	 * @return The minimum time until state which was not updated will be retained.
 	 */
 	public long getMinIdleStateRetentionTime() {

Review comment:
       Add a new method `getIdleStateRetentionTime` and deprecate `getMinIdleStateRetentionTime` and `getMaxIdleStateRetentionTime`.

##########
File path: flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/api/TableConfigTest.java
##########
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.api;
+
+import org.junit.Test;
+
+import java.time.Duration;
+import java.time.ZoneId;
+import java.time.ZoneOffset;
+import java.util.Arrays;
+import java.util.List;
+
+import static org.junit.Assert.assertEquals;
+
+/**
+ * Tests for {@link TableConfig}.
+ */
+public class TableConfigTest {
+	@Test
+	public void testGetAndSetTableConfigOptions() throws Exception{
+		Class<?> configClass = TableConfig.class;
+		TableConfig config = new TableConfig();
+		for (TestSpec<?> spec: testSpecList){
+			configClass.getMethod("set" + spec.fieldName, spec.inputClass).invoke(config, spec.inputValue);
+			assertEquals(spec.expectedValue, configClass.getMethod("get" + spec.fieldName).invoke(config));
+		}
+	}
+
+	@Test
+	public void testGetAndSetIdleStateRetentionDuration(){
+		TableConfig config = new TableConfig();
+		config.setIdleStateRetentionDuration(Duration.ofHours(1));
+		assertEquals(Duration.ofHours(1).toMillis(), config.getMinIdleStateRetentionTime());
+		assertEquals(Duration.ofHours(1).toMillis() * 3 / 2, config.getMaxIdleStateRetentionTime());

Review comment:
       Please also test the string option. 

##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/ExecutionConfigOptions.java
##########
@@ -49,6 +51,15 @@
 				"tasks to advance their watermarks without the need to wait for " +
 				"watermarks from this source while it is idle.");
 
+	@Documentation.TableOption(execMode = Documentation.ExecMode.STREAMING)
+	public static final ConfigOption<Duration> IDLE_STATE_RETENTION =
+		key("table.exec.state.ttl")
+			.durationType()
+			.defaultValue(Duration.ofMillis(0))
+			.withDescription("A time-to-live (TTL) can be assigned to the keyed state of any type. " +
+				"If a TTL is configured and a state value has expired, " +
+				"the stored value will be cleaned up on a best effort basis.");
+

Review comment:
       Add description for default value, for example: `Default is 0 (zero) which will never clean-up state`. 

##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableConfig.java
##########
@@ -274,9 +263,10 @@ public void setMaxGeneratedCodeLength(Integer maxGeneratedCodeLength) {
 	 *
 	 * @param minTime The minimum time interval for which idle state is retained. Set to 0 (zero) to
 	 *                never clean-up the state.
-	 * @param maxTime The maximum time interval for which idle state is retained. Must be at least
-	 *                5 minutes greater than minTime. Set to 0 (zero) to never clean-up the state.
+	 * @param maxTime Currently maxTime will be ignored and it will automatically derived from minTime
+	 *                as 1.5 x minTime.
 	 */
+	@Deprecated

Review comment:
       Add deprecate javadoc on this method, and suggest to use which method instead. 

##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/ExecutionConfigOptions.java
##########
@@ -49,6 +51,15 @@
 				"tasks to advance their watermarks without the need to wait for " +
 				"watermarks from this source while it is idle.");
 
+	@Documentation.TableOption(execMode = Documentation.ExecMode.STREAMING)
+	public static final ConfigOption<Duration> IDLE_STATE_RETENTION =
+		key("table.exec.state.ttl")
+			.durationType()
+			.defaultValue(Duration.ofMillis(0))
+			.withDescription("A time-to-live (TTL) can be assigned to the keyed state of any type. " +
+				"If a TTL is configured and a state value has expired, " +
+				"the stored value will be cleaned up on a best effort basis.");
+

Review comment:
       Move this before `Source Options`? And add comment `State Options` on it?

##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableConfig.java
##########
@@ -286,20 +276,43 @@ public void setIdleStateRetentionTime(Time minTime, Time maxTime) {
 		}
 		minIdleStateRetentionTime = minTime.toMilliseconds();
 		maxIdleStateRetentionTime = maxTime.toMilliseconds();
+		setIdleStateRetentionDuration(Duration.ofMillis(minIdleStateRetentionTime));
+	}
+
+	/**
+	 * Specifies a retention time interval for how long idle state, i.e., state which
+	 * was not updated, will be retained.
+	 * State will never be cleared until it was idle for less than the retention time and will never
+	 * be kept if it was idle for more than the 1.5 * retention time.
+	 *
+	 * <p>When new data arrives for previously cleaned-up state, the new data will be handled as if it
+	 * was the first data. This can result in previous results being overwritten.
+	 *
+	 * <p>Set to 0 (zero) to never clean-up the state.
+	 *
+	 * <p>NOTE: Cleaning up state requires additional bookkeeping which becomes less expensive for
+	 * larger differences of minTime and maxTime. The difference between minTime and maxTime must be
+	 * at least 5 minutes.
+	 *
+	 * @param duration The retention time interval for which idle state is retained. Set to 0 (zero) to
+	 *                never clean-up the state.
+	 */
+	public void setIdleStateRetentionDuration(Duration duration){

Review comment:
       I prefer to use the same method as before `setIdleStateRetentionTime` or without the `Time`/`Duration` suffix. 

##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableConfig.java
##########
@@ -286,20 +276,43 @@ public void setIdleStateRetentionTime(Time minTime, Time maxTime) {
 		}
 		minIdleStateRetentionTime = minTime.toMilliseconds();
 		maxIdleStateRetentionTime = maxTime.toMilliseconds();
+		setIdleStateRetentionDuration(Duration.ofMillis(minIdleStateRetentionTime));
+	}
+
+	/**
+	 * Specifies a retention time interval for how long idle state, i.e., state which
+	 * was not updated, will be retained.
+	 * State will never be cleared until it was idle for less than the retention time and will never
+	 * be kept if it was idle for more than the 1.5 * retention time.
+	 *
+	 * <p>When new data arrives for previously cleaned-up state, the new data will be handled as if it
+	 * was the first data. This can result in previous results being overwritten.
+	 *
+	 * <p>Set to 0 (zero) to never clean-up the state.
+	 *
+	 * <p>NOTE: Cleaning up state requires additional bookkeeping which becomes less expensive for
+	 * larger differences of minTime and maxTime. The difference between minTime and maxTime must be
+	 * at least 5 minutes.

Review comment:
       Remove the NOTE.

##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableConfig.java
##########
@@ -286,20 +276,43 @@ public void setIdleStateRetentionTime(Time minTime, Time maxTime) {
 		}
 		minIdleStateRetentionTime = minTime.toMilliseconds();
 		maxIdleStateRetentionTime = maxTime.toMilliseconds();
+		setIdleStateRetentionDuration(Duration.ofMillis(minIdleStateRetentionTime));
+	}
+
+	/**
+	 * Specifies a retention time interval for how long idle state, i.e., state which
+	 * was not updated, will be retained.
+	 * State will never be cleared until it was idle for less than the retention time and will never
+	 * be kept if it was idle for more than the 1.5 * retention time.

Review comment:
       ```suggestion
   	 * State will never be cleared until it was idle for less than the retention time and will be cleared on a best effort basis after the retention time.
   ```

##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableConfig.java
##########
@@ -274,9 +263,10 @@ public void setMaxGeneratedCodeLength(Integer maxGeneratedCodeLength) {
 	 *
 	 * @param minTime The minimum time interval for which idle state is retained. Set to 0 (zero) to
 	 *                never clean-up the state.
-	 * @param maxTime The maximum time interval for which idle state is retained. Must be at least
-	 *                5 minutes greater than minTime. Set to 0 (zero) to never clean-up the state.
+	 * @param maxTime Currently maxTime will be ignored and it will automatically derived from minTime

Review comment:
       I would suggest to keep the original description for `maxTime`, but add a NOTE to explain the `maxTime` is ignored now and is inferred from `minTime` with a 1.5 multiplier. 

##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableConfig.java
##########
@@ -286,20 +276,43 @@ public void setIdleStateRetentionTime(Time minTime, Time maxTime) {
 		}
 		minIdleStateRetentionTime = minTime.toMilliseconds();
 		maxIdleStateRetentionTime = maxTime.toMilliseconds();
+		setIdleStateRetentionDuration(Duration.ofMillis(minIdleStateRetentionTime));
+	}
+
+	/**
+	 * Specifies a retention time interval for how long idle state, i.e., state which
+	 * was not updated, will be retained.
+	 * State will never be cleared until it was idle for less than the retention time and will never
+	 * be kept if it was idle for more than the 1.5 * retention time.
+	 *
+	 * <p>When new data arrives for previously cleaned-up state, the new data will be handled as if it
+	 * was the first data. This can result in previous results being overwritten.
+	 *
+	 * <p>Set to 0 (zero) to never clean-up the state.
+	 *
+	 * <p>NOTE: Cleaning up state requires additional bookkeeping which becomes less expensive for
+	 * larger differences of minTime and maxTime. The difference between minTime and maxTime must be
+	 * at least 5 minutes.
+	 *
+	 * @param duration The retention time interval for which idle state is retained. Set to 0 (zero) to
+	 *                never clean-up the state.

Review comment:
       Add a `@see` comment:
   
   ```
   * @see org.apache.flink.api.common.state.StateTtlConfig
   ```
   
   

##########
File path: flink-table/flink-table-api-java-bridge/src/test/java/org/apache/flink/table/api/bridge/java/internal/StreamTableEnvironmentImplTest.java
##########
@@ -63,7 +63,7 @@ public void testAppendStreamDoesNotOverwriteTableConfig() {
 			equalTo(minRetention.toMilliseconds()));
 		assertThat(
 			tEnv.getConfig().getMaxIdleStateRetentionTime(),
-			equalTo(maxRetention.toMilliseconds()));
+			equalTo(minRetention.toMilliseconds() * 3 / 2));

Review comment:
       Please use the new method `setIdleStateRetentionTime` to set idle state in tests. 

##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/TableConfigOptions.java
##########
@@ -51,4 +52,24 @@ private TableConfigOptions() {}
 			.withDescription("The SQL dialect defines how to parse a SQL query. " +
 					"A different SQL dialect may support different SQL grammar. " +
 					"Currently supported dialects are: default and hive");
+
+	@Documentation.TableOption(execMode = Documentation.ExecMode.BATCH_STREAMING)
+	public static final ConfigOption<String> LOCAL_TIME_ZONE = key("table.local-time-zone")
+			.stringType()
+			// special value to decide whether to use ZoneId.systemDefault() in TableConfig.getLocalTimeZone()
+			.defaultValue("System")
+			.withDescription("The local time zone defines current session time zone id. It is used when converting to/from " +
+				"TIMESTAMP_WITH_LOCAL_TIME_ZONE. Internally, timestamps with local time zone are always represented in the UTC time zone. " +

Review comment:
       ```suggestion
   				"<code>TIMESTAMP WITH LOCAL TIME ZONE</code>. Internally, timestamps with local time zone are always represented in the UTC time zone. " +
   ```

##########
File path: flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/api/TableConfigTest.java
##########
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.api;
+
+import org.junit.Test;
+
+import java.time.Duration;
+import java.time.ZoneId;
+import java.time.ZoneOffset;
+import java.util.Arrays;
+import java.util.List;
+
+import static org.junit.Assert.assertEquals;
+
+/**
+ * Tests for {@link TableConfig}.
+ */
+public class TableConfigTest {
+	@Test
+	public void testGetAndSetTableConfigOptions() throws Exception{
+		Class<?> configClass = TableConfig.class;
+		TableConfig config = new TableConfig();
+		for (TestSpec<?> spec: testSpecList){
+			configClass.getMethod("set" + spec.fieldName, spec.inputClass).invoke(config, spec.inputValue);
+			assertEquals(spec.expectedValue, configClass.getMethod("get" + spec.fieldName).invoke(config));

Review comment:
       I think we should avoid use the Java reflection here, otherwise, it's hard to maintain when TableConfig is refactored again in the future. 
   
   I think we don't have much tests here, we can have a test for each method/option. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12880:
URL: https://github.com/apache/flink/pull/12880#issuecomment-657437173


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0265191d170ed07f0980cf370b418f656159e49d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4432",
       "triggerID" : "0265191d170ed07f0980cf370b418f656159e49d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4447",
       "triggerID" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4470",
       "triggerID" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5207",
       "triggerID" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5225",
       "triggerID" : "c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "82edfc5569e7d434ecd56a872b2f56015df3a851",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5232",
       "triggerID" : "82edfc5569e7d434ecd56a872b2f56015df3a851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5f9cc66b6457e7a28b137f82fe24bbff14fda84d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5f9cc66b6457e7a28b137f82fe24bbff14fda84d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 82edfc5569e7d434ecd56a872b2f56015df3a851 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5232) 
   * 5f9cc66b6457e7a28b137f82fe24bbff14fda84d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12880:
URL: https://github.com/apache/flink/pull/12880#issuecomment-657437173


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0265191d170ed07f0980cf370b418f656159e49d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4432",
       "triggerID" : "0265191d170ed07f0980cf370b418f656159e49d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4447",
       "triggerID" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4470",
       "triggerID" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5207",
       "triggerID" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5225",
       "triggerID" : "c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "82edfc5569e7d434ecd56a872b2f56015df3a851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5232",
       "triggerID" : "82edfc5569e7d434ecd56a872b2f56015df3a851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5f9cc66b6457e7a28b137f82fe24bbff14fda84d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5278",
       "triggerID" : "5f9cc66b6457e7a28b137f82fe24bbff14fda84d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5f9cc66b6457e7a28b137f82fe24bbff14fda84d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5278) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12880:
URL: https://github.com/apache/flink/pull/12880#issuecomment-657437173


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0265191d170ed07f0980cf370b418f656159e49d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4432",
       "triggerID" : "0265191d170ed07f0980cf370b418f656159e49d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4447",
       "triggerID" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4470",
       "triggerID" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5207",
       "triggerID" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5225",
       "triggerID" : "c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "82edfc5569e7d434ecd56a872b2f56015df3a851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5232",
       "triggerID" : "82edfc5569e7d434ecd56a872b2f56015df3a851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5f9cc66b6457e7a28b137f82fe24bbff14fda84d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5278",
       "triggerID" : "5f9cc66b6457e7a28b137f82fe24bbff14fda84d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f213639e4e38e9e25506c20d7eff660cadbb6b1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5286",
       "triggerID" : "1f213639e4e38e9e25506c20d7eff660cadbb6b1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "94e8eb39032665f77e897cb572cd4320b66635f9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5703",
       "triggerID" : "94e8eb39032665f77e897cb572cd4320b66635f9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "72e7dcb66f3a2c6eda4899d51ddd6420d2d5822b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5744",
       "triggerID" : "72e7dcb66f3a2c6eda4899d51ddd6420d2d5822b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "607b519de6a6421d13b4bfa0b2414761ac8fccb4",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5907",
       "triggerID" : "607b519de6a6421d13b4bfa0b2414761ac8fccb4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 607b519de6a6421d13b4bfa0b2414761ac8fccb4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5907) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12880:
URL: https://github.com/apache/flink/pull/12880#issuecomment-657437173


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0265191d170ed07f0980cf370b418f656159e49d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4432",
       "triggerID" : "0265191d170ed07f0980cf370b418f656159e49d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4447",
       "triggerID" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4470",
       "triggerID" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5207",
       "triggerID" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5225",
       "triggerID" : "c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5e007a083820aed78298cd519ae17e3762b5fa53 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5207) 
   * c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5225) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12880:
URL: https://github.com/apache/flink/pull/12880#issuecomment-657437173


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0265191d170ed07f0980cf370b418f656159e49d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4432",
       "triggerID" : "0265191d170ed07f0980cf370b418f656159e49d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4447",
       "triggerID" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4470",
       "triggerID" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5207",
       "triggerID" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5225",
       "triggerID" : "c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5225) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12880:
URL: https://github.com/apache/flink/pull/12880#issuecomment-657437173


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0265191d170ed07f0980cf370b418f656159e49d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4432",
       "triggerID" : "0265191d170ed07f0980cf370b418f656159e49d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4447",
       "triggerID" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4470",
       "triggerID" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5207",
       "triggerID" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5225",
       "triggerID" : "c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "82edfc5569e7d434ecd56a872b2f56015df3a851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5232",
       "triggerID" : "82edfc5569e7d434ecd56a872b2f56015df3a851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5f9cc66b6457e7a28b137f82fe24bbff14fda84d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5278",
       "triggerID" : "5f9cc66b6457e7a28b137f82fe24bbff14fda84d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f213639e4e38e9e25506c20d7eff660cadbb6b1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5286",
       "triggerID" : "1f213639e4e38e9e25506c20d7eff660cadbb6b1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "94e8eb39032665f77e897cb572cd4320b66635f9",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5703",
       "triggerID" : "94e8eb39032665f77e897cb572cd4320b66635f9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "72e7dcb66f3a2c6eda4899d51ddd6420d2d5822b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5744",
       "triggerID" : "72e7dcb66f3a2c6eda4899d51ddd6420d2d5822b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 94e8eb39032665f77e897cb572cd4320b66635f9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5703) 
   * 72e7dcb66f3a2c6eda4899d51ddd6420d2d5822b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5744) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12880:
URL: https://github.com/apache/flink/pull/12880#issuecomment-657437173


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0265191d170ed07f0980cf370b418f656159e49d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4432",
       "triggerID" : "0265191d170ed07f0980cf370b418f656159e49d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4447",
       "triggerID" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4470",
       "triggerID" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5207",
       "triggerID" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5e007a083820aed78298cd519ae17e3762b5fa53 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5207) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wuchong merged pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

wuchong merged pull request #12880:
URL: https://github.com/apache/flink/pull/12880


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12880:
URL: https://github.com/apache/flink/pull/12880#issuecomment-657437173


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0265191d170ed07f0980cf370b418f656159e49d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4432",
       "triggerID" : "0265191d170ed07f0980cf370b418f656159e49d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4447",
       "triggerID" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4470",
       "triggerID" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5207",
       "triggerID" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5225",
       "triggerID" : "c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "82edfc5569e7d434ecd56a872b2f56015df3a851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5232",
       "triggerID" : "82edfc5569e7d434ecd56a872b2f56015df3a851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5f9cc66b6457e7a28b137f82fe24bbff14fda84d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5278",
       "triggerID" : "5f9cc66b6457e7a28b137f82fe24bbff14fda84d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f213639e4e38e9e25506c20d7eff660cadbb6b1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5286",
       "triggerID" : "1f213639e4e38e9e25506c20d7eff660cadbb6b1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "94e8eb39032665f77e897cb572cd4320b66635f9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5703",
       "triggerID" : "94e8eb39032665f77e897cb572cd4320b66635f9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "72e7dcb66f3a2c6eda4899d51ddd6420d2d5822b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5744",
       "triggerID" : "72e7dcb66f3a2c6eda4899d51ddd6420d2d5822b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 72e7dcb66f3a2c6eda4899d51ddd6420d2d5822b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5744) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12880:
URL: https://github.com/apache/flink/pull/12880#issuecomment-657437173


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0265191d170ed07f0980cf370b418f656159e49d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4432",
       "triggerID" : "0265191d170ed07f0980cf370b418f656159e49d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4447",
       "triggerID" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4470",
       "triggerID" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5207",
       "triggerID" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5225",
       "triggerID" : "c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "82edfc5569e7d434ecd56a872b2f56015df3a851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5232",
       "triggerID" : "82edfc5569e7d434ecd56a872b2f56015df3a851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5f9cc66b6457e7a28b137f82fe24bbff14fda84d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5278",
       "triggerID" : "5f9cc66b6457e7a28b137f82fe24bbff14fda84d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f213639e4e38e9e25506c20d7eff660cadbb6b1",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5286",
       "triggerID" : "1f213639e4e38e9e25506c20d7eff660cadbb6b1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5f9cc66b6457e7a28b137f82fe24bbff14fda84d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5278) 
   * 1f213639e4e38e9e25506c20d7eff660cadbb6b1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5286) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12880:
URL: https://github.com/apache/flink/pull/12880#issuecomment-657437173


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0265191d170ed07f0980cf370b418f656159e49d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4432",
       "triggerID" : "0265191d170ed07f0980cf370b418f656159e49d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4447",
       "triggerID" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4470",
       "triggerID" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5207",
       "triggerID" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5225",
       "triggerID" : "c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "82edfc5569e7d434ecd56a872b2f56015df3a851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5232",
       "triggerID" : "82edfc5569e7d434ecd56a872b2f56015df3a851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5f9cc66b6457e7a28b137f82fe24bbff14fda84d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5278",
       "triggerID" : "5f9cc66b6457e7a28b137f82fe24bbff14fda84d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f213639e4e38e9e25506c20d7eff660cadbb6b1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5286",
       "triggerID" : "1f213639e4e38e9e25506c20d7eff660cadbb6b1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "94e8eb39032665f77e897cb572cd4320b66635f9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5703",
       "triggerID" : "94e8eb39032665f77e897cb572cd4320b66635f9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "72e7dcb66f3a2c6eda4899d51ddd6420d2d5822b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5744",
       "triggerID" : "72e7dcb66f3a2c6eda4899d51ddd6420d2d5822b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "607b519de6a6421d13b4bfa0b2414761ac8fccb4",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "607b519de6a6421d13b4bfa0b2414761ac8fccb4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 72e7dcb66f3a2c6eda4899d51ddd6420d2d5822b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5744) 
   * 607b519de6a6421d13b4bfa0b2414761ac8fccb4 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12880:
URL: https://github.com/apache/flink/pull/12880#issuecomment-657437173


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0265191d170ed07f0980cf370b418f656159e49d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4432",
       "triggerID" : "0265191d170ed07f0980cf370b418f656159e49d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4447",
       "triggerID" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4470",
       "triggerID" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5207",
       "triggerID" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5225",
       "triggerID" : "c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "82edfc5569e7d434ecd56a872b2f56015df3a851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5232",
       "triggerID" : "82edfc5569e7d434ecd56a872b2f56015df3a851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5f9cc66b6457e7a28b137f82fe24bbff14fda84d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5278",
       "triggerID" : "5f9cc66b6457e7a28b137f82fe24bbff14fda84d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f213639e4e38e9e25506c20d7eff660cadbb6b1",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5286",
       "triggerID" : "1f213639e4e38e9e25506c20d7eff660cadbb6b1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "94e8eb39032665f77e897cb572cd4320b66635f9",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5703",
       "triggerID" : "94e8eb39032665f77e897cb572cd4320b66635f9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1f213639e4e38e9e25506c20d7eff660cadbb6b1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5286) 
   * 94e8eb39032665f77e897cb572cd4320b66635f9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5703) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12880:
URL: https://github.com/apache/flink/pull/12880#issuecomment-657437173


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0265191d170ed07f0980cf370b418f656159e49d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4432",
       "triggerID" : "0265191d170ed07f0980cf370b418f656159e49d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4447",
       "triggerID" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4470",
       "triggerID" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5207",
       "triggerID" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5225",
       "triggerID" : "c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "82edfc5569e7d434ecd56a872b2f56015df3a851",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "82edfc5569e7d434ecd56a872b2f56015df3a851",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5225) 
   * 82edfc5569e7d434ecd56a872b2f56015df3a851 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12880:
URL: https://github.com/apache/flink/pull/12880#issuecomment-657437173


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0265191d170ed07f0980cf370b418f656159e49d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4432",
       "triggerID" : "0265191d170ed07f0980cf370b418f656159e49d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4447",
       "triggerID" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4470",
       "triggerID" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5207",
       "triggerID" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5225",
       "triggerID" : "c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "82edfc5569e7d434ecd56a872b2f56015df3a851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5232",
       "triggerID" : "82edfc5569e7d434ecd56a872b2f56015df3a851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5f9cc66b6457e7a28b137f82fe24bbff14fda84d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5278",
       "triggerID" : "5f9cc66b6457e7a28b137f82fe24bbff14fda84d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f213639e4e38e9e25506c20d7eff660cadbb6b1",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5286",
       "triggerID" : "1f213639e4e38e9e25506c20d7eff660cadbb6b1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "94e8eb39032665f77e897cb572cd4320b66635f9",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "94e8eb39032665f77e897cb572cd4320b66635f9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1f213639e4e38e9e25506c20d7eff660cadbb6b1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5286) 
   * 94e8eb39032665f77e897cb572cd4320b66635f9 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wuchong commented on a change in pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

wuchong commented on a change in pull request #12880:
URL: https://github.com/apache/flink/pull/12880#discussion_r472743692



##########
File path: flink-table/flink-table-api-java-bridge/src/test/java/org/apache/flink/table/api/bridge/java/internal/StreamTableEnvironmentImplTest.java
##########
@@ -52,18 +52,17 @@ public void testAppendStreamDoesNotOverwriteTableConfig() {
 
 		StreamTableEnvironmentImpl tEnv = getStreamTableEnvironment(env, elements);
 
-		Time minRetention = Time.minutes(1);
-		Time maxRetention = Time.minutes(10);
-		tEnv.getConfig().setIdleStateRetentionTime(minRetention, maxRetention);
+		Duration minRetention = Duration.ofMinutes(1);
+		tEnv.getConfig().setIdleStateRetention(minRetention);
 		Table table = tEnv.fromDataStream(elements);
 		tEnv.toAppendStream(table, Row.class);
 
 		assertThat(
 			tEnv.getConfig().getMinIdleStateRetentionTime(),
-			equalTo(minRetention.toMilliseconds()));
+			equalTo(minRetention.toMillis()));
 		assertThat(
 			tEnv.getConfig().getMaxIdleStateRetentionTime(),
-			equalTo(maxRetention.toMilliseconds()));
+			equalTo(minRetention.toMillis() * 3 / 2));

Review comment:
       We only need to assert the `tEnv.getConfig().getIdleStateRetention()`.

##########
File path: flink-table/flink-table-api-java-bridge/src/test/java/org/apache/flink/table/api/bridge/java/internal/StreamTableEnvironmentImplTest.java
##########
@@ -73,18 +72,17 @@ public void testRetractStreamDoesNotOverwriteTableConfig() {
 
 		StreamTableEnvironmentImpl tEnv = getStreamTableEnvironment(env, elements);
 
-		Time minRetention = Time.minutes(1);
-		Time maxRetention = Time.minutes(10);
-		tEnv.getConfig().setIdleStateRetentionTime(minRetention, maxRetention);
+		Duration minRetention = Duration.ofMinutes(1);
+		tEnv.getConfig().setIdleStateRetention(minRetention);
 		Table table = tEnv.fromDataStream(elements);
 		tEnv.toRetractStream(table, Row.class);
 
 		assertThat(
 			tEnv.getConfig().getMinIdleStateRetentionTime(),
-			equalTo(minRetention.toMilliseconds()));
+			equalTo(minRetention.toMillis()));
 		assertThat(
 			tEnv.getConfig().getMaxIdleStateRetentionTime(),
-			equalTo(maxRetention.toMilliseconds()));
+			equalTo(minRetention.toMillis() * 3 / 2));

Review comment:
       ditto.

##########
File path: flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/api/TableConfigTest.java
##########
@@ -24,114 +24,54 @@
 
 import java.time.Duration;
 import java.time.ZoneId;
-import java.util.Arrays;
-import java.util.List;
-import java.util.function.BiConsumer;
-import java.util.function.Function;
 
-import static org.hamcrest.CoreMatchers.equalTo;
-import static org.junit.Assert.assertThat;
+import static org.junit.Assert.assertEquals;
 
 /**
  * Tests for {@link TableConfig}.
  */
 public class TableConfigTest {
-	private static List<TestSpec> specs = Arrays.asList(
-		TestSpec.testValue(SqlDialect.HIVE)
-			.viaSetter(TableConfig::setSqlDialect)
-			.getterVia(TableConfig::getSqlDialect)
-			.whenSetFromConfig("table.sql-dialect", "HIVE"),
-
-		TestSpec.testValue(5000)
-			.viaSetter(TableConfig::setMaxGeneratedCodeLength)
-			.getterVia(TableConfig::getMaxGeneratedCodeLength)
-			.whenSetFromConfig("table.generated-code.max-length", "5000"),
-
-		TestSpec.testValue(ZoneId.of("Asia/Shanghai"))
-			.viaSetter(TableConfig::setLocalTimeZone)
-			.getterVia(TableConfig::getLocalTimeZone)
-			.whenSetFromConfig("table.local-time-zone", "Asia/Shanghai"),
-
-		TestSpec.testValue(Duration.ofHours(1))
-			.viaSetter(TableConfig::setIdleStateRetention)
-			.getterVia(tableConfig -> Duration.ofMillis(tableConfig.getMinIdleStateRetentionTime()))
-			.whenSetFromConfig("table.exec.state.ttl", "1 h"),
-
-		TestSpec.testValue(Duration.ofHours(2))
-			.viaSetter(TableConfig::setIdleStateRetention)
-			.getterVia(tableConfig -> Duration.ofMillis(tableConfig.getMaxIdleStateRetentionTime()))
-			.whenSetFromConfig("table.exec.state.ttl", "2 h")
-			.nonDefaultValue(Duration.ofHours(3))
-	);
+	private static TableConfig configByMethod = new TableConfig();
+	private static TableConfig configByConfiguration = new TableConfig();
+	private static Configuration configuration = new Configuration();
 
 	@Test
-	public void testLoadFromConfiguration() {
-		for (TestSpec<?> spec: specs) {
-			testWithSpec(spec);
-		}
-	}
-
-	private void testWithSpec(TestSpec<?> testSpec) {
-		Configuration config = new Configuration();
-		config.setString(testSpec.key, testSpec.value);
-		TableConfig tableConfigFromConfig = new TableConfig();
-		tableConfigFromConfig.addConfiguration(config);
+	public void testSetAndGetSqlDialect() {
+		configuration.setString("table.sql-dialect", "HIVE");
+		configByConfiguration.addConfiguration(configuration);
+		configByMethod.setSqlDialect(SqlDialect.HIVE);
 
-		TableConfig tableConfigFromSetter = new TableConfig();
-		testSpec.setValue(tableConfigFromSetter);
-
-		testSpec.assertEqual(tableConfigFromConfig, tableConfigFromSetter);
-		testSpec.assertEqualNonDefaultValue(tableConfigFromConfig);
+		assertEquals(SqlDialect.HIVE, configByMethod.getSqlDialect());
+		assertEquals(SqlDialect.HIVE, configByConfiguration.getSqlDialect());
 	}
 
-	private static class TestSpec<T> {
-		private String key;
-		private String value;
-		private final T objectValue;
-		private BiConsumer<TableConfig, T> setter;
-		private Function<TableConfig, T> getter;
-		private T nonDefaultValue;
-
-		private TestSpec(T value) {
-			this.objectValue = value;
-			this.nonDefaultValue = value;
-		}
-
-		public static <T> TestSpec<T> testValue(T value) {
-			return new TestSpec<>(value);
-		}
-
-		public TestSpec<T> nonDefaultValue(T value) {
-			this.nonDefaultValue = value;
-			return this;
-		}
-
-		public TestSpec<T> whenSetFromConfig(String key, String value) {
-			this.key = key;
-			this.value = value;
-			return this;
-		}
+	@Test
+	public void testSetAndGetMaxGeneratedCodeLength() {
+		configuration.setString("table.generated-code.max-length", "5000");
+		configByConfiguration.addConfiguration(configuration);
+		configByMethod.setMaxGeneratedCodeLength(5000);
 
-		public TestSpec<T> viaSetter(BiConsumer<TableConfig, T> setter) {
-			this.setter = setter;
-			return this;
-		}
+		assertEquals(Integer.valueOf(5000), configByMethod.getMaxGeneratedCodeLength());
+		assertEquals(Integer.valueOf(5000), configByConfiguration.getMaxGeneratedCodeLength());
+	}
 
-		public TestSpec<T> getterVia(Function<TableConfig, T> getter) {
-			this.getter = getter;
-			return this;
-		}
+	@Test
+	public void testSetAndGetLocalTimeZone() {
+		configuration.setString("table.local-time-zone", "Asia/Shanghai");
+		configByConfiguration.addConfiguration(configuration);
+		configByMethod.setLocalTimeZone(ZoneId.of("Asia/Shanghai"));
 
-		public void setValue(TableConfig config) {
-			setter.accept(config, objectValue);
-		}
+		assertEquals(Integer.valueOf(5000), configByMethod.getMaxGeneratedCodeLength());
+		assertEquals(Integer.valueOf(5000), configByConfiguration.getMaxGeneratedCodeLength());

Review comment:
       Should assert time zone. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12880:
URL: https://github.com/apache/flink/pull/12880#issuecomment-657437173


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0265191d170ed07f0980cf370b418f656159e49d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4432",
       "triggerID" : "0265191d170ed07f0980cf370b418f656159e49d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4447",
       "triggerID" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 34ee9488f149038dddd3227b9408bed674240a1a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4447) 
   * 05fede7e394cf0d1a7ba614d1411fa15141c3c65 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] fsk119 commented on a change in pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

fsk119 commented on a change in pull request #12880:
URL: https://github.com/apache/flink/pull/12880#discussion_r465679070



##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableConfig.java
##########
@@ -286,20 +276,43 @@ public void setIdleStateRetentionTime(Time minTime, Time maxTime) {
 		}
 		minIdleStateRetentionTime = minTime.toMilliseconds();
 		maxIdleStateRetentionTime = maxTime.toMilliseconds();
+		setIdleStateRetentionDuration(Duration.ofMillis(minIdleStateRetentionTime));
+	}
+
+	/**
+	 * Specifies a retention time interval for how long idle state, i.e., state which
+	 * was not updated, will be retained.
+	 * State will never be cleared until it was idle for less than the retention time and will never
+	 * be kept if it was idle for more than the 1.5 * retention time.
+	 *
+	 * <p>When new data arrives for previously cleaned-up state, the new data will be handled as if it
+	 * was the first data. This can result in previous results being overwritten.
+	 *
+	 * <p>Set to 0 (zero) to never clean-up the state.
+	 *
+	 * <p>NOTE: Cleaning up state requires additional bookkeeping which becomes less expensive for
+	 * larger differences of minTime and maxTime. The difference between minTime and maxTime must be
+	 * at least 5 minutes.
+	 *
+	 * @param duration The retention time interval for which idle state is retained. Set to 0 (zero) to
+	 *                never clean-up the state.
+	 */
+	public void setIdleStateRetentionDuration(Duration duration){

Review comment:
       If we use the same function name with different parametere list, it will get strange thing on python side. We can only use one of the `setIdleStateRetentionTime` in python. So the only option is to use the method name `setIdleStateRetention`

##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableConfig.java
##########
@@ -286,20 +276,43 @@ public void setIdleStateRetentionTime(Time minTime, Time maxTime) {
 		}
 		minIdleStateRetentionTime = minTime.toMilliseconds();
 		maxIdleStateRetentionTime = maxTime.toMilliseconds();
+		setIdleStateRetentionDuration(Duration.ofMillis(minIdleStateRetentionTime));
+	}
+
+	/**
+	 * Specifies a retention time interval for how long idle state, i.e., state which
+	 * was not updated, will be retained.
+	 * State will never be cleared until it was idle for less than the retention time and will never
+	 * be kept if it was idle for more than the 1.5 * retention time.
+	 *
+	 * <p>When new data arrives for previously cleaned-up state, the new data will be handled as if it
+	 * was the first data. This can result in previous results being overwritten.
+	 *
+	 * <p>Set to 0 (zero) to never clean-up the state.
+	 *
+	 * <p>NOTE: Cleaning up state requires additional bookkeeping which becomes less expensive for
+	 * larger differences of minTime and maxTime. The difference between minTime and maxTime must be
+	 * at least 5 minutes.
+	 *
+	 * @param duration The retention time interval for which idle state is retained. Set to 0 (zero) to
+	 *                never clean-up the state.

Review comment:
       If we use the same function name with different parametere list, it will get strange thing on python side. We can only use one of the `setIdleStateRetentionTime` in python. So the only option is to use the method name `setIdleStateRetention`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12880:
URL: https://github.com/apache/flink/pull/12880#issuecomment-657437173


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0265191d170ed07f0980cf370b418f656159e49d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4432",
       "triggerID" : "0265191d170ed07f0980cf370b418f656159e49d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0265191d170ed07f0980cf370b418f656159e49d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4432) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wuchong commented on a change in pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

wuchong commented on a change in pull request #12880:
URL: https://github.com/apache/flink/pull/12880#discussion_r464833799



##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/TableConfigOptions.java
##########
@@ -51,4 +52,24 @@ private TableConfigOptions() {}
 			.withDescription("The SQL dialect defines how to parse a SQL query. " +
 					"A different SQL dialect may support different SQL grammar. " +
 					"Currently supported dialects are: default and hive");
+
+	@Documentation.TableOption(execMode = Documentation.ExecMode.BATCH_STREAMING)
+	public static final ConfigOption<String> LOCAL_TIME_ZONE = key("table.local-time-zone")
+			.stringType()
+			// special value to decide whether to use ZoneId.systemDefault() in TableConfig.getLocalTimeZone()
+			.defaultValue("System")

Review comment:
       I think it would be better to use "default" as the default value here. Because this is very easy to understand literally and `table.sql-dialect` also uses it. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12880:
URL: https://github.com/apache/flink/pull/12880#issuecomment-657437173


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0265191d170ed07f0980cf370b418f656159e49d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4432",
       "triggerID" : "0265191d170ed07f0980cf370b418f656159e49d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4447",
       "triggerID" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4470",
       "triggerID" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 05fede7e394cf0d1a7ba614d1411fa15141c3c65 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4470) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wuchong commented on pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

wuchong commented on pull request #12880:
URL: https://github.com/apache/flink/pull/12880#issuecomment-681966698


   Merging...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12880:
URL: https://github.com/apache/flink/pull/12880#issuecomment-657437173


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0265191d170ed07f0980cf370b418f656159e49d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4432",
       "triggerID" : "0265191d170ed07f0980cf370b418f656159e49d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4447",
       "triggerID" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0265191d170ed07f0980cf370b418f656159e49d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4432) 
   * 34ee9488f149038dddd3227b9408bed674240a1a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4447) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12880:
URL: https://github.com/apache/flink/pull/12880#issuecomment-657437173


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0265191d170ed07f0980cf370b418f656159e49d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4432",
       "triggerID" : "0265191d170ed07f0980cf370b418f656159e49d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4447",
       "triggerID" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4470",
       "triggerID" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 05fede7e394cf0d1a7ba614d1411fa15141c3c65 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4470) 
   * 5e007a083820aed78298cd519ae17e3762b5fa53 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12880:
URL: https://github.com/apache/flink/pull/12880#issuecomment-657437173


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0265191d170ed07f0980cf370b418f656159e49d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4432",
       "triggerID" : "0265191d170ed07f0980cf370b418f656159e49d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4447",
       "triggerID" : "34ee9488f149038dddd3227b9408bed674240a1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4470",
       "triggerID" : "05fede7e394cf0d1a7ba614d1411fa15141c3c65",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5207",
       "triggerID" : "5e007a083820aed78298cd519ae17e3762b5fa53",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5225",
       "triggerID" : "c5a0c7fa6e6cbe59d50a43745ce76b4ab8864f2d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "82edfc5569e7d434ecd56a872b2f56015df3a851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5232",
       "triggerID" : "82edfc5569e7d434ecd56a872b2f56015df3a851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5f9cc66b6457e7a28b137f82fe24bbff14fda84d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5278",
       "triggerID" : "5f9cc66b6457e7a28b137f82fe24bbff14fda84d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f213639e4e38e9e25506c20d7eff660cadbb6b1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5286",
       "triggerID" : "1f213639e4e38e9e25506c20d7eff660cadbb6b1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "94e8eb39032665f77e897cb572cd4320b66635f9",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5703",
       "triggerID" : "94e8eb39032665f77e897cb572cd4320b66635f9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 94e8eb39032665f77e897cb572cd4320b66635f9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5703) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org