You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/11/10 16:59:45 UTC

[GitHub] [beam] TheNeuralBit commented on a change in pull request #15909: [BEAM-12550] Parallelizable kurtosis Implementation

TheNeuralBit commented on a change in pull request #15909:
URL: https://github.com/apache/beam/pull/15909#discussion_r746794267



##########
File path: sdks/python/apache_beam/dataframe/frames_test.py
##########
@@ -1474,14 +1454,7 @@ def test_dataframe_agg_method(self, agg_method):
     df = pd.DataFrame({'A': [1, 2, 3, 4], 'B': [2, 3, 5, 7]})
 
     nonparallel = agg_method in (
-        'quantile',
-        'mean',
-        'describe',
-        'median',
-        'sem',
-        'mad',
-        'kurtosis',
-        'kurt')
+        'quantile', 'mean', 'describe', 'median', 'sem', 'mad', 'kurt')

Review comment:
       Can you make it so we use your parallelizable implementation for `kurt` as well?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org