[GitHub] [opennlp] rzo1 commented on a diff in pull request #479: OPENNLP-1434 Enhance JavaDoc in opennlp.uima packages

[GitBox <gi...@apache.org>]

rzo1 commented on code in PR #479:
URL: https://github.com/apache/opennlp/pull/479#discussion_r1060162143


##########
opennlp-uima/src/main/java/opennlp/uima/normalizer/NumberUtil.java:
##########
@@ -52,31 +51,36 @@ public static boolean isLanguageSupported(String languageCode) {
   }
 
   /**
-   * Removes trailing and containing space.
+   * Removes a character from given string {@code s}.
+   *
+   * @param s The string to process.
+   * @param remove The {@link Character} to remove from {@code s}.
    */
-  private static String removeChar(String string, char remove) {
+  private static String removeChar(String s, char remove) {

Review Comment:
   This is basically a `s.replace(remove, "")` (replace all occurences of the given `char` in the given `String` literal). Sadly, were is no `String#replace(char,String)` available, but we could do `s.replace(Character.toString(remove), "")` (or change  the method signature).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org