[GitHub] ivankelly opened a new pull request #816: Fix flake in TestPerChannelBookieClient

[GitBox <gi...@apache.org>]

ivankelly opened a new pull request #816: Fix flake in TestPerChannelBookieClient
URL: https://github.com/apache/bookkeeper/pull/816
 
 
   Flake is in testRequestCompletesAfterDisconnectRace. It tests a race
   between disconnection and making a request. The flake occurred because
   when the disconnection happened, the request would be errorred out,
   and this would add a callback to the ordered executor. The test was
   shutting down the executor before the callback was actually run (it
   may not even have been added in some cases), and this was causing the
   request to never complete, failing the test.
   
   The fix is to move the shutdown of the executor to after the assertion
   that the request has completed.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services