You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/26 08:49:24 UTC
[GitHub] [pulsar] cbornet opened a new pull request, #16822: [feature][functions] Add admin CLI command to get available built-in functions
cbornet opened a new pull request, #16822:
URL: https://github.com/apache/pulsar/pull/16822
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.trs9rsex3xom)*.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
### Motivation
Same as `sinks available-sinks` and `sources available-sources` but for Functions.
### Modifications
* Add HTTP endpoints `admin/v3/functions/builtins` to broker and function worker.
* Add Java admin SDK function `getBuiltInFunctions` and `getBuiltInFunctionsAsync` methods.
* Add admin CLI command `functions available-functions`
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change added tests and can be verified as follows:
There are no tests for the builtin sinks/source. Shouldn't we add it in another PR ?
### Does this pull request potentially affect one of the following parts:
yes
*If `yes` was chosen, please highlight the changes*
- The public API: yes
- The schema: no
- The default values of configurations: no
- The wire protocol: no
- The rest endpoints: yes
- The admin cli options: yes
- Anything that affects deployment: no
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [x] `doc-required`
(Your PR needs to update docs and you will update later)
- [ ] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on pull request #16822: [feature][functions] Add admin CLI command to get available built-in functions
Posted by GitBox <gi...@apache.org>.
momo-jun commented on PR #16822:
URL: https://github.com/apache/pulsar/pull/16822#issuecomment-1321354880
Yes, the reference doc can be auto-generated now. Besides the reference info, do you have any other additional information to add in the Pulsar doc site to actively promote this feature? If not, the label can be changed to `doc-complete`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli merged pull request #16822: [feature][functions] Add admin CLI command to get available built-in functions
Posted by GitBox <gi...@apache.org>.
eolivelli merged PR #16822:
URL: https://github.com/apache/pulsar/pull/16822
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on pull request #16822: [feature][functions] Add admin CLI command to get available built-in functions
Posted by GitBox <gi...@apache.org>.
cbornet commented on PR #16822:
URL: https://github.com/apache/pulsar/pull/16822#issuecomment-1229242440
/pulsar-bot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on pull request #16822: [feature][functions] Add admin CLI command to get available built-in functions
Posted by GitBox <gi...@apache.org>.
cbornet commented on PR #16822:
URL: https://github.com/apache/pulsar/pull/16822#issuecomment-1325292046
`available-functions` and `reload` have not been picked into 2.11. Will the reference be re-generated with the 2.11 code when it's released ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on a diff in pull request #16822: Add admin CLI command to get available built-in functions
Posted by GitBox <gi...@apache.org>.
cbornet commented on code in PR #16822:
URL: https://github.com/apache/pulsar/pull/16822#discussion_r931208373
##########
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/FunctionsImpl.java:
##########
@@ -70,11 +71,13 @@
public class FunctionsImpl extends ComponentResource implements Functions {
private final WebTarget functions;
+ private final WebTarget worker;
private final AsyncHttpClient asyncHttpClient;
public FunctionsImpl(WebTarget web, Authentication auth, AsyncHttpClient asyncHttpClient, long readTimeoutMs) {
super(auth, readTimeoutMs);
this.functions = web.path("/admin/v3/functions");
+ this.worker = web.path("/admin/v2/worker");
Review Comment:
Should `available-functions` be a command of `pulsar-admin workers` instead ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on pull request #16822: [feature][functions] Add admin CLI command to get available built-in functions
Posted by GitBox <gi...@apache.org>.
cbornet commented on PR #16822:
URL: https://github.com/apache/pulsar/pull/16822#issuecomment-1324823226
I opened https://github.com/apache/pulsar/pull/18569 to add doc for built-in functions that gives more context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on pull request #16822: [feature][functions] Add admin CLI command to get available built-in functions
Posted by GitBox <gi...@apache.org>.
momo-jun commented on PR #16822:
URL: https://github.com/apache/pulsar/pull/16822#issuecomment-1255896307
@cbornet It will help users a lot if you can add the docs for this feature. Do you have any plans on that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on a diff in pull request #16822: [feature][functions] Add admin CLI command to get available built-in functions
Posted by GitBox <gi...@apache.org>.
cbornet commented on code in PR #16822:
URL: https://github.com/apache/pulsar/pull/16822#discussion_r949912400
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Worker.java:
##########
@@ -115,6 +116,21 @@ public List<ConnectorDefinition> getConnectorsList() throws IOException {
return workers().getListOfConnectors(clientAppId());
}
+ @GET
+ @ApiOperation(
+ value = "Fetches the list of built-in Pulsar functions",
+ response = FunctionDefinition.class,
+ responseContainer = "List"
+ )
+ @ApiResponses(value = {
+ @ApiResponse(code = 200, message = "Get builtin functions successfully.")
Review Comment:
I added them. PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on pull request #16822: [feature][functions] Add admin CLI command to get available built-in functions
Posted by GitBox <gi...@apache.org>.
cbornet commented on PR #16822:
URL: https://github.com/apache/pulsar/pull/16822#issuecomment-1227527704
/pulsar-bot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet closed pull request #16822: [feature][functions] Add admin CLI command to get available built-in functions
Posted by GitBox <gi...@apache.org>.
cbornet closed pull request #16822: [feature][functions] Add admin CLI command to get available built-in functions
URL: https://github.com/apache/pulsar/pull/16822
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on a diff in pull request #16822: [feature][functions] Add admin CLI command to get available built-in functions
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on code in PR #16822:
URL: https://github.com/apache/pulsar/pull/16822#discussion_r947619596
##########
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/FunctionsImpl.java:
##########
@@ -70,11 +71,13 @@
public class FunctionsImpl extends ComponentResource implements Functions {
private final WebTarget functions;
+ private final WebTarget worker;
private final AsyncHttpClient asyncHttpClient;
public FunctionsImpl(WebTarget web, Authentication auth, AsyncHttpClient asyncHttpClient, long readTimeoutMs) {
super(auth, readTimeoutMs);
this.functions = web.path("/admin/v3/functions");
+ this.worker = web.path("/admin/v2/worker");
Review Comment:
+1 for `pulsar-admin functions`. However it's a bit weird that the rest endpoint is under "/worker"
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Worker.java:
##########
@@ -115,6 +116,21 @@ public List<ConnectorDefinition> getConnectorsList() throws IOException {
return workers().getListOfConnectors(clientAppId());
}
+ @GET
+ @ApiOperation(
+ value = "Fetches the list of built-in Pulsar functions",
+ response = FunctionDefinition.class,
+ responseContainer = "List"
+ )
+ @ApiResponses(value = {
+ @ApiResponse(code = 200, message = "Get builtin functions successfully.")
+ })
+ @Path("/builtinfunctions")
Review Comment:
IMO if we want to follow the same as the "/connectors" above this endpoint should be "/functions"
##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java:
##########
@@ -1310,4 +1312,17 @@ private void parseFullyQualifiedFunctionName(String fqfn, FunctionConfig functio
}
}
+ @Parameters(commandDescription = "Get the list of Pulsar Functions supported by Pulsar cluster")
+ public class ListBuiltInFunctions extends BaseCommand {
+ @Override
+ void runCmd() throws Exception {
+ getAdmin().functions().getBuiltInFunctions()
+ .forEach(function -> {
+ System.out.println(function.getName());
Review Comment:
could we create a common method to display this kind of stuff ? (sinks, sources, functions..)
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Worker.java:
##########
@@ -115,6 +116,21 @@ public List<ConnectorDefinition> getConnectorsList() throws IOException {
return workers().getListOfConnectors(clientAppId());
}
+ @GET
+ @ApiOperation(
+ value = "Fetches the list of built-in Pulsar functions",
+ response = FunctionDefinition.class,
+ responseContainer = "List"
+ )
+ @ApiResponses(value = {
+ @ApiResponse(code = 200, message = "Get builtin functions successfully.")
Review Comment:
what about error responses ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on pull request #16822: [feature][functions] Add admin CLI command to get available built-in functions
Posted by GitBox <gi...@apache.org>.
cbornet commented on PR #16822:
URL: https://github.com/apache/pulsar/pull/16822#issuecomment-1320552948
Isn't doc for this auto-generated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on a diff in pull request #16822: Add admin CLI command to get available built-in functions
Posted by GitBox <gi...@apache.org>.
cbornet commented on code in PR #16822:
URL: https://github.com/apache/pulsar/pull/16822#discussion_r931208373
##########
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/FunctionsImpl.java:
##########
@@ -70,11 +71,13 @@
public class FunctionsImpl extends ComponentResource implements Functions {
private final WebTarget functions;
+ private final WebTarget worker;
private final AsyncHttpClient asyncHttpClient;
public FunctionsImpl(WebTarget web, Authentication auth, AsyncHttpClient asyncHttpClient, long readTimeoutMs) {
super(auth, readTimeoutMs);
this.functions = web.path("/admin/v3/functions");
+ this.worker = web.path("/admin/v2/worker");
Review Comment:
Should `available-functions` be a command of `pulsar-admin workers` instead ?
I've put it in `pulsar-admin functions` for consistency with sinks and sources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on a diff in pull request #16822: [feature][functions] Add admin CLI command to get available built-in functions
Posted by GitBox <gi...@apache.org>.
cbornet commented on code in PR #16822:
URL: https://github.com/apache/pulsar/pull/16822#discussion_r947673740
##########
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/FunctionsImpl.java:
##########
@@ -70,11 +71,13 @@
public class FunctionsImpl extends ComponentResource implements Functions {
private final WebTarget functions;
+ private final WebTarget worker;
private final AsyncHttpClient asyncHttpClient;
public FunctionsImpl(WebTarget web, Authentication auth, AsyncHttpClient asyncHttpClient, long readTimeoutMs) {
super(auth, readTimeoutMs);
this.functions = web.path("/admin/v3/functions");
+ this.worker = web.path("/admin/v2/worker");
Review Comment:
This is because we have the list of connectors under `/worker`.
Now we also have the list of sinks under `/sinks` and the list of sources under `/sources`.
So I think we can indeed have the list of functions under `/functions`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on a diff in pull request #16822: Add admin CLI command to get available built-in functions
Posted by GitBox <gi...@apache.org>.
cbornet commented on code in PR #16822:
URL: https://github.com/apache/pulsar/pull/16822#discussion_r931208373
##########
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/FunctionsImpl.java:
##########
@@ -70,11 +71,13 @@
public class FunctionsImpl extends ComponentResource implements Functions {
private final WebTarget functions;
+ private final WebTarget worker;
private final AsyncHttpClient asyncHttpClient;
public FunctionsImpl(WebTarget web, Authentication auth, AsyncHttpClient asyncHttpClient, long readTimeoutMs) {
super(auth, readTimeoutMs);
this.functions = web.path("/admin/v3/functions");
+ this.worker = web.path("/admin/v2/worker");
Review Comment:
Should `available-functions` be a command of `pulsar-admin workers` instead ?
For now, I've put it in `pulsar-admin functions` for consistency with sinks and sources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on a diff in pull request #16822: [feature][functions] Add admin CLI command to get available built-in functions
Posted by GitBox <gi...@apache.org>.
cbornet commented on code in PR #16822:
URL: https://github.com/apache/pulsar/pull/16822#discussion_r949916285
##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java:
##########
@@ -1310,4 +1312,17 @@ private void parseFullyQualifiedFunctionName(String fqfn, FunctionConfig functio
}
}
+ @Parameters(commandDescription = "Get the list of Pulsar Functions supported by Pulsar cluster")
+ public class ListBuiltInFunctions extends BaseCommand {
+ @Override
+ void runCmd() throws Exception {
+ getAdmin().functions().getBuiltInFunctions()
+ .forEach(function -> {
+ System.out.println(function.getName());
Review Comment:
Between source and sink maybe. But between Function and Connectors, we handle distinct classes that are unrelated (FunctionDefinition and ConnectorDefinition) so I don't think we can factorize.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16822: [feature][functions] Add admin CLI command to get available built-in functions
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16822:
URL: https://github.com/apache/pulsar/pull/16822#issuecomment-1325392898
@cbornet I think so. Generally, if we release on time, this won't be a big issue, but 2.11.0 takes more than three months to release. Also, I'm considering versioned docs along with release branches and cutting new versioned docs on feature freeze (along with cutting the branch), but all of them requires concrete proposal,s and I assume to take care of it in months.
For current status, ping @Technoboy- the RM of 2.11.0 FYI. And perhaps we revert the related sections after the docs cut. This is the same as Pulsar SQL's caveat (https://pulsar.apache.org/docs/next/sql-overview#caveat) so you may also add a note for versions as a workaround (we should not have it with a proper process ).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on a diff in pull request #16822: [feature][functions] Add admin CLI command to get available built-in functions
Posted by GitBox <gi...@apache.org>.
eolivelli commented on code in PR #16822:
URL: https://github.com/apache/pulsar/pull/16822#discussion_r947635295
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Worker.java:
##########
@@ -115,6 +116,21 @@ public List<ConnectorDefinition> getConnectorsList() throws IOException {
return workers().getListOfConnectors(clientAppId());
}
+ @GET
+ @ApiOperation(
+ value = "Fetches the list of built-in Pulsar functions",
+ response = FunctionDefinition.class,
+ responseContainer = "List"
+ )
+ @ApiResponses(value = {
+ @ApiResponse(code = 200, message = "Get builtin functions successfully.")
+ })
+ @Path("/builtinfunctions")
Review Comment:
I think that "buildinfunctions" is clearer.
"functions" may look like to refer to "all the functions"
not a big deal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on a diff in pull request #16822: [feature][functions] Add admin CLI command to get available built-in functions
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on code in PR #16822:
URL: https://github.com/apache/pulsar/pull/16822#discussion_r947617310
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Worker.java:
##########
@@ -115,6 +116,21 @@ public List<ConnectorDefinition> getConnectorsList() throws IOException {
return workers().getListOfConnectors(clientAppId());
}
+ @GET
+ @ApiOperation(
+ value = "Fetches the list of built-in Pulsar functions",
+ response = FunctionDefinition.class,
+ responseContainer = "List"
+ )
+ @ApiResponses(value = {
+ @ApiResponse(code = 200, message = "Get builtin functions successfully.")
+ })
+ @Path("/builtinfunctions")
Review Comment:
IMO if we want to follow the same as the "/connectors" above, this endpoint should be "/functions"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet closed pull request #16822: [feature][functions] Add admin CLI command to get available built-in functions
Posted by GitBox <gi...@apache.org>.
cbornet closed pull request #16822: [feature][functions] Add admin CLI command to get available built-in functions
URL: https://github.com/apache/pulsar/pull/16822
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on pull request #16822: [feature][functions] Add admin CLI command to get available built-in functions
Posted by GitBox <gi...@apache.org>.
cbornet commented on PR #16822:
URL: https://github.com/apache/pulsar/pull/16822#issuecomment-1218250783
I changed the location of the endpoint from `worker` to `functions` for more consistency. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16822: [feature][functions] Add admin CLI command to get available built-in functions
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16822:
URL: https://github.com/apache/pulsar/pull/16822#issuecomment-1320748292
@cbornet Yes. I can read https://pulsar.apache.org/reference/#/next/pulsar-admin/functions?id=available-functions now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on pull request #16822: [feature][functions] Add admin CLI command to get available built-in functions
Posted by GitBox <gi...@apache.org>.
cbornet commented on PR #16822:
URL: https://github.com/apache/pulsar/pull/16822#issuecomment-1219566811
/pulsar-bot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on pull request #16822: Add admin CLI command to get available built-in functions
Posted by GitBox <gi...@apache.org>.
cbornet commented on PR #16822:
URL: https://github.com/apache/pulsar/pull/16822#issuecomment-1196964921
It's only builtin functions. It's the same as for sinks and sources.
The name available-functions/available-sinks/available-sources are indeed confusing.
We can change to builtin-functions which is more accurate but is not coherent with sinks/sources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org