[GitHub] [beam] mosche commented on a diff in pull request #21982: [#21634] Add comments on FieldValueGetter.

[GitBox <gi...@apache.org>]

mosche commented on code in PR #21982:
URL: https://github.com/apache/beam/pull/21982#discussion_r907159504


##########
sdks/java/core/src/main/java/org/apache/beam/sdk/values/Row.java:
##########
@@ -106,7 +106,7 @@ public abstract class Row implements Serializable {
   /** Return the size of data fields. */
   public abstract int getFieldCount();
 
-  /** Return the list of data values. */

Review Comment:
   I've updated the comment @TheNeuralBit. For context, here's @reuvenlax's  explanation of `getValues`.
   From that it sounds like this shouldn't be publicly consumed and should also be annotated with `@Internal`.
   
   > getValues() is maybe poorly named - might be better called getRawValues. What you're looking for is probably the getBaseValues() method.
   > getValues is mostly used in code that knows exactly what it's doing for optimization purposes. It goes along with the attachValues method, which is similarly tricky to use. It's there to enable 0-copy code, but not necessarily intended for general consumption.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org