You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/04/24 15:31:09 UTC
[GitHub] mrutkows closed pull request #126: Update RAT pom.xml and document
more excluded files in openwhisk repo
mrutkows closed pull request #126: Update RAT pom.xml and document more excluded files in openwhisk repo
URL: https://github.com/apache/incubator-openwhisk-release/pull/126
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/docs/license_compliance.md b/docs/license_compliance.md
index f464da6..7e982aa 100644
--- a/docs/license_compliance.md
+++ b/docs/license_compliance.md
@@ -52,9 +52,18 @@ In OpenWhisk project, we decided to apply short form of header to minified OpenW
| Template files (`*.j2`) | Excluded | - | Not much creativity |
| Json files (`*.json`) | Excluded | - | Json files don't support comments officially |
| `i18n_resources.go` | Excluded | - | Not much creativity. The file is auto created. Not able to add header |
-| `application.conf` | Excluded | - | Not much creativity. See a sample [here](https://github.com/apache/incubator-openwhisk-runtime-nodejs/blob/master/tests/src/test/resources/application.conf) |
+| `*.conf` | Excluded | - | Configuration file. Not much creativity. See a sample [here](https://github.com/apache/incubator-openwhisk-runtime-nodejs/blob/master/tests/src/test/resources/application.conf) |
+| `*.env` | Excluded | - | Configuration file. Not much creativity. See a sample [here](https://github.com/apache/incubator-openwhisk/blob/master/ansible/environments/distributed/files/openstack/openstack.env) |
+| `*.cfg` | Excluded | - | Configuration file. Not much creativity. See a sample [here](https://github.com/apache/incubator-openwhisk/blob/master/ansible/ansible.cfg) |
+| `*.ini` | Excluded | - | Configuration file. Not much creativity. See a sample [here](https://github.com/apache/incubator-openwhisk/blob/master/ansible/files/package-versions.ini) |
+| `*.properties` | Excluded | - | Configuration file. Not much creativity. See a sample [here](https://github.com/apache/incubator-openwhisk/blob/master/tools/eclipse/scala.properties) |
+| `post.lua` | Excluded | - | Configuration file. Not much creativity. See a sample [here](https://github.com/apache/incubator-openwhisk/blob/master/performance/wrk_tests/post.lua) |
+| `java.xml`,`logback.xml` | Excluded | - | Configuration file in XML format. Not much creativity. See a sample [here](https://github.com/apache/incubator-openwhisk/blob/master/tools/eclipse/java.xml) |
| `group_vars/all` | Excluded | - | Not much creativity. See a sample [here](https://github.com/apache/incubator-openwhisk-runtime-nodejs/blob/master/ansible/environments/local/group_vars/all) |
| `hosts` | Excluded | - | Not much creativity. See a sample [here](https://github.com/apache/incubator-openwhisk-runtime-nodejs/blob/master/ansible/environments/local/hosts) |
+| `dockerhub.groovy` | Excluded | - | Not much creativity. See a sample [here](https://github.com/apache/incubator-openwhisk/blob/master/tools/jenkins/apache/dockerhub.groovy) |
+| `openwhisk/actionRuntimes/*/Dockerfile` | Excluded | - | Very simple docker file without creativity. See a sample [here](https://github.com/apache/incubator-openwhisk/blob/master/actionRuntimes/python2Action/Dockerfile) |
+| `openwhisk/sdk/docker/Dockerfile` | Excluded | - | Very simple docker file without creativity. See a sample [here](https://github.com/apache/incubator-openwhisk/blob/master/sdk/docker/Dockerfile) |
## Tools and scripts
@@ -63,7 +72,7 @@ In OpenWhisk project, we decided to apply short form of header to minified OpenW
```
cd $OPENWHISK_SOURCE_DIR
cp $SCRIPTDIR/lib/pom.xml ./
-mvn clean apache-rat:check
+mvn clean apache-rat:check
```
Below script snippet is used to check LICENSE file and NOTICE file in every repository.
```
diff --git a/tools/lib/pom.xml b/tools/lib/pom.xml
index 71621ba..c978e97 100644
--- a/tools/lib/pom.xml
+++ b/tools/lib/pom.xml
@@ -66,6 +66,26 @@
<exclude>**/i18n_resources.go</exclude>
<!-- NOTICE files -->
<exclude>**/NOTICE.md</exclude>
+ <!-- LICENSE files -->
+ <exclude>**/licenses/**</exclude>
+ <!-- LICENSE files -->
+ <exclude>**/CREDITS.txt</exclude>
+ <!-- configuration files -->
+ <exclude>**/group_vars/all</exclude>
+ <exclude>**/**.conf</exclude>
+ <exclude>**/**.env</exclude>
+ <exclude>**/**.cfg</exclude>
+ <exclude>**/**.ini</exclude>
+ <exclude>**/**.properties</exclude>
+ <exclude>**/post.lua</exclude>
+ <exclude>**/java.xml</exclude>
+ <exclude>**/logback.xml</exclude>
+ <exclude>**/post.lua</exclude>
+ <exclude>**/hosts</exclude>
+ <exclude>**/dockerhub.groovy</exclude>
+ <!-- None creative docker files -->
+ <exclude>openwhisk/actionRuntimes/**/Dockerfile</exclude>
+ <exclude>openwhisk/sdk/docker/Dockerfile</exclude>
<!-- Test data / src files -->
<!-- <exclude>*/tests/dat/**</exclude> -->
<!-- <exclude>*/tests/src/**</exclude> -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services