You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/08/02 14:31:34 UTC

[GitHub] [incubator-superset] villebro opened a new pull request #7973: Bump sqlparse 030

villebro opened a new pull request #7973: Bump sqlparse 030
URL: https://github.com/apache/incubator-superset/pull/7973
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Refactor
   
   ### SUMMARY
   The function that replaces the query limit assumed that the limit number comes two tokens after the keyword. This was the case for `sqlparse==0.2.4`, but stopped working when bumped to `sqlparse==0.3.0`. This makes the function slightly more robust by using native `sqlparse` functionality to find the next non-whitespace token after the limit keyword. The new code works equally well with `0.2.4`, but I figured it's just as well to bump to the newest version.
   
   ### TEST PLAN
   - Unit tests.
   
   ### REVIEWERS
   @john-bodley @betodealmeida 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org