You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Ivan Kelly (Created) (JIRA)" <ji...@apache.org> on 2011/12/21 11:53:30 UTC
[jira] [Created] (BOOKKEEPER-145) Put notice and license file for
distributed binaries in SVN
Put notice and license file for distributed binaries in SVN
-----------------------------------------------------------
Key: BOOKKEEPER-145
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-145
Project: Bookkeeper
Issue Type: Improvement
Reporter: Ivan Kelly
Assignee: Ivan Kelly
Fix For: 4.1.0
During the 4.0.0 I manually put these in the binary tarballs. This is awkward though. It's easier just to have them in the source tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-145) Put notice and license file for
distributed binaries in SVN
Posted by "Ivan Kelly (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated BOOKKEEPER-145:
----------------------------------
Priority: Blocker (was: Major)
> Put notice and license file for distributed binaries in SVN
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-145
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-145
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Blocker
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-145.diff
>
>
> During the 4.0.0 I manually put these in the binary tarballs. This is awkward though. It's easier just to have them in the source tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-145) Put notice and license file for
distributed binaries in SVN
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated BOOKKEEPER-145:
----------------------------------
Attachment: BOOKKEEPER-145.diff
I removed the maven-notice-plugin stuff in the end, as it has no option to exclude dependencies in the test scope. So now both bookkeeper-server and hedwig-server have their own LICENSE.bin.txt and NOTICE.bin.txt files, which get pulled in when generating the packages.
The permissions problems and junit inclusion has also been fixed.
> Put notice and license file for distributed binaries in SVN
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-145
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-145
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Blocker
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-145.diff, BOOKKEEPER-145.diff, BOOKKEEPER-145.diff
>
>
> During the 4.0.0 I manually put these in the binary tarballs. This is awkward though. It's easier just to have them in the source tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-145) Put notice and license file for
distributed binaries in SVN
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272307#comment-13272307 ]
Ivan Kelly commented on BOOKKEEPER-145:
---------------------------------------
Thanks Pat. Afaik, maven will throw the NOTICE and LICENSE into the jars automatically if its an apache project, so this should be fine.
> Put notice and license file for distributed binaries in SVN
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-145
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-145
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Blocker
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-145.diff, BOOKKEEPER-145.diff, BOOKKEEPER-145.diff
>
>
> During the 4.0.0 I manually put these in the binary tarballs. This is awkward though. It's easier just to have them in the source tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-145) Put notice and license file for
distributed binaries in SVN
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262124#comment-13262124 ]
Patrick Hunt commented on BOOKKEEPER-145:
-----------------------------------------
Oddly a number of files in the tar have the executable bit set:
-rwxrwxr-x 1 phunt phunt 11358 2012-04-25 14:05 LICENSE.txt*
-rwxrwxr-x 1 phunt phunt 167 2012-04-25 14:05 NOTICE.txt*
-rwxrwxr-x 1 phunt phunt 3372 2012-04-25 14:05 README*
(not everything, you might take a look)
I did a git checkout and then a build as you mentioned above.
> Put notice and license file for distributed binaries in SVN
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-145
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-145
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Blocker
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-145.diff, BOOKKEEPER-145.diff
>
>
> During the 4.0.0 I manually put these in the binary tarballs. This is awkward though. It's easier just to have them in the source tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-145) Put notice and license file for
distributed binaries in SVN
Posted by "Ivan Kelly (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated BOOKKEEPER-145:
----------------------------------
Attachment: BOOKKEEPER-145.diff
This new patch uses maven-notice-plugin to generate the NOTICE file, and contains a separate LICENSE file to be used for binary artifacts which include thirdparty code. I couldn't find a maven plugin to autogenerate the LICENSE file.
I've also rejigged the assembly to include the new NOTICE/LICENSE for binary packages. I've disabled binary package generation for all but hedwig-server and bookkeeper-server.
Run mvn clean package assembly:single to generate the packages now. The packages generated will be:
* ./bookkeeper-server/target/bookkeeper-server-4.1.0-SNAPSHOT-bin.tar.gz
* ./hedwig-server/target/hedwig-server-4.1.0-SNAPSHOT-bin.tar.gz
* ./target/bookkeeper-4.1.0-SNAPSHOT-src.tar.gz
> Put notice and license file for distributed binaries in SVN
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-145
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-145
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Blocker
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-145.diff, BOOKKEEPER-145.diff
>
>
> During the 4.0.0 I manually put these in the binary tarballs. This is awkward though. It's easier just to have them in the source tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-145) Put notice and license file for
distributed binaries in SVN
Posted by "Ivan Kelly (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated BOOKKEEPER-145:
----------------------------------
Attachment: BOOKKEEPER-145.diff
> Put notice and license file for distributed binaries in SVN
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-145
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-145
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-145.diff
>
>
> During the 4.0.0 I manually put these in the binary tarballs. This is awkward though. It's easier just to have them in the source tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-145) Put notice and license file for
distributed binaries in SVN
Posted by "Flavio Junqueira (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13198918#comment-13198918 ]
Flavio Junqueira commented on BOOKKEEPER-145:
---------------------------------------------
+1 for me, but I think it would be a good idea to have someone else lik Pat having a look at this.
> Put notice and license file for distributed binaries in SVN
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-145
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-145
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-145.diff
>
>
> During the 4.0.0 I manually put these in the binary tarballs. This is awkward though. It's easier just to have them in the source tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-145) Put notice and license file for
distributed binaries in SVN
Posted by "Ivan Kelly (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208611#comment-13208611 ]
Ivan Kelly commented on BOOKKEEPER-145:
---------------------------------------
I'll take a look at the notice plugin, it looks like a nicer solution.
Regarding whirr, it only seems to have 1 LICENSE.txt file which has all the licenses. Is this correct?
> Put notice and license file for distributed binaries in SVN
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-145
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-145
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-145.diff
>
>
> During the 4.0.0 I manually put these in the binary tarballs. This is awkward though. It's easier just to have them in the source tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-145) Put notice and license file for
distributed binaries in SVN
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271872#comment-13271872 ]
Patrick Hunt commented on BOOKKEEPER-145:
-----------------------------------------
I regenerated the binaries and they look ok. Notice that according to the Apache License (for included works under AL) you should do the following:
{noformat}
(d) If the Work includes a "NOTICE" text file as part of its
distribution, then any Derivative Works that You distribute must
include a readable copy of the attribution notices contained
within such NOTICE file, excluding those notices that do not
pertain to any part of the Derivative Works, in at least one
of the following places: within a NOTICE text file distributed
as part of the Derivative Works; within the Source form or
documentation, if provided along with the Derivative Works; or,
within a display generated by the Derivative Works, if and
wherever such third-party notices normally appear. The contents
of the NOTICE file are for informational purposes only and
do not modify the License. You may add Your own attribution
notices within Derivative Works that You distribute, alongside
or as an addendum to the NOTICE text from the Work, provided
that such additional attribution notices cannot be construed
as modifying the License.
{noformat}
You're ok in this case with your notice file, because if you look at the jars (e.g. commons lang or commons io) you'll see that they include NOTICE files. If this were not the case you'd be required to replicate their notice file w/in your own.
> Put notice and license file for distributed binaries in SVN
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-145
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-145
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Blocker
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-145.diff, BOOKKEEPER-145.diff, BOOKKEEPER-145.diff
>
>
> During the 4.0.0 I manually put these in the binary tarballs. This is awkward though. It's easier just to have them in the source tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-145) Put notice and license file for
distributed binaries in SVN
Posted by "Patrick Hunt (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208603#comment-13208603 ]
Patrick Hunt commented on BOOKKEEPER-145:
-----------------------------------------
You don't want to do this. At least not like this patch.
I'm assuming you will have 1 source artifact plus 0 or more binary artifacts. You'll have the same issue, but in reverse - you don't want your source artifact to have a notice/license for things that are not included. On the other hand you do want your binary license/notice to include this.
two options I can see:
1) see how whirr does this, http://svn.apache.org/viewvc/whirr/trunk/
it has two notice files, one for bin one for source. this should work fine as long as you have homogeneous binaries. Although I would think you want a stripped down NOTICE.TXT/license and NOTICE-bin.txt/LICENSE-bin.txt instead of src. Then you pull the right file into the archive during the packaging.
2) generate the notice/license on the fly.
see this:
https://issues.apache.org/jira/browse/OPENJPA-880
or this:
https://wiki.jasig.org/display/LIC/maven-notice-plugin
(probably other options as well).
I'm not very familiar with 2, but I'd suggest you go this route - it will make your life easier in the long run.
> Put notice and license file for distributed binaries in SVN
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-145
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-145
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-145.diff
>
>
> During the 4.0.0 I manually put these in the binary tarballs. This is awkward though. It's easier just to have them in the source tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-145) Put notice and license file for
distributed binaries in SVN
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274536#comment-13274536 ]
Sijie Guo commented on BOOKKEEPER-145:
--------------------------------------
after applying the patch, it works good for me. +1.
> Put notice and license file for distributed binaries in SVN
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-145
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-145
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Blocker
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-145.diff, BOOKKEEPER-145.diff, BOOKKEEPER-145.diff
>
>
> During the 4.0.0 I manually put these in the binary tarballs. This is awkward though. It's easier just to have them in the source tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-145) Put notice and license file for
distributed binaries in SVN
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262132#comment-13262132 ]
Patrick Hunt commented on BOOKKEEPER-145:
-----------------------------------------
after generating the .tar.gz files as suggested above the NOTICE files only seem to have the notices for bk itself, there is no other information. I looked at the files you mentioned in your most recent comment. (ivan).
I'd suggest that you don't include the .jar files for testing. Rather you're better off just including the jars you need to run the product (in the bin assemblies). For example I notice you're bundling junit (cat b license). No real need to do this afaict.
> Put notice and license file for distributed binaries in SVN
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-145
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-145
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Blocker
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-145.diff, BOOKKEEPER-145.diff
>
>
> During the 4.0.0 I manually put these in the binary tarballs. This is awkward though. It's easier just to have them in the source tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira