You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jason Huynh <jh...@pivotal.io> on 2016/09/28 16:41:10 UTC
Review Request 52356: GEODE-1944: Index with method invocation in
regionPath can throw exception when tombstones clean up during gii
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52356/
-----------------------------------------------------------
Review request for geode, nabarun nag, Dan Smith, and xiaojian zhou.
Repository: geode
Description
-------
The fix is to catch the EntryDestroyedException and execute a "remove" just to force a removal from the index incase something/somehow got in there. This specific problem would only occur on start up, during recovery from disk, where tombstones have been reaped and we end up gii'ing and doing a removeOldTombstones call.
Renamed and recategorized a few tests.
Diffs
-----
geode-core/src/main/java/org/apache/geode/cache/query/internal/index/CompactRangeIndex.java c99da56
geode-core/src/main/java/org/apache/geode/cache/query/internal/index/HashIndex.java 775daec
geode-core/src/main/java/org/apache/geode/cache/query/internal/index/IndexManager.java 4dcd1c3
geode-core/src/main/java/org/apache/geode/cache/query/internal/index/IndexStore.java c26ec48
geode-core/src/test/java/org/apache/geode/cache/query/dunit/CompactRangeIndexQueryDUnitTest.java f8bae1b
geode-core/src/test/java/org/apache/geode/cache/query/internal/index/AbstractIndexMaintenanceIntegrationTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/cache/query/internal/index/CompactRangeIndexMaintenanceIntegrationTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/cache/query/internal/index/CompactRangeIndexQueryIntegrationTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/cache/query/internal/index/HashIndexJUnitTest.java 432199a
geode-core/src/test/java/org/apache/geode/cache/query/internal/index/HashIndexMaintenanceIntegrationTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/cache/query/internal/index/HashIndexQueryIntegrationTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/cache/query/internal/index/RangeIndexMaintenanceIntegrationTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/52356/diff/
Testing
-------
Thanks,
Jason Huynh
Re: Review Request 52356: GEODE-1944: Index with method invocation in
regionPath can throw exception when tombstones clean up during gii
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52356/#review150750
-----------------------------------------------------------
Fix it, then Ship it!
geode-core/src/main/java/org/apache/geode/cache/query/internal/index/HashIndex.java (line 1490)
<https://reviews.apache.org/r/52356/#comment218811>
Doesn't seem like it should catch an exception and ignore it here.
- Dan Smith
On Sept. 28, 2016, 4:41 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52356/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2016, 4:41 p.m.)
>
>
> Review request for geode, nabarun nag, Dan Smith, and xiaojian zhou.
>
>
> Repository: geode
>
>
> Description
> -------
>
> The fix is to catch the EntryDestroyedException and execute a "remove" just to force a removal from the index incase something/somehow got in there. This specific problem would only occur on start up, during recovery from disk, where tombstones have been reaped and we end up gii'ing and doing a removeOldTombstones call.
>
> Renamed and recategorized a few tests.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/cache/query/internal/index/CompactRangeIndex.java c99da56
> geode-core/src/main/java/org/apache/geode/cache/query/internal/index/HashIndex.java 775daec
> geode-core/src/main/java/org/apache/geode/cache/query/internal/index/IndexManager.java 4dcd1c3
> geode-core/src/main/java/org/apache/geode/cache/query/internal/index/IndexStore.java c26ec48
> geode-core/src/test/java/org/apache/geode/cache/query/dunit/CompactRangeIndexQueryDUnitTest.java f8bae1b
> geode-core/src/test/java/org/apache/geode/cache/query/internal/index/AbstractIndexMaintenanceIntegrationTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/query/internal/index/CompactRangeIndexMaintenanceIntegrationTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/query/internal/index/CompactRangeIndexQueryIntegrationTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/query/internal/index/HashIndexJUnitTest.java 432199a
> geode-core/src/test/java/org/apache/geode/cache/query/internal/index/HashIndexMaintenanceIntegrationTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/query/internal/index/HashIndexQueryIntegrationTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/query/internal/index/RangeIndexMaintenanceIntegrationTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/52356/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>