You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Hitesh Khamesra <hk...@pivotal.io> on 2016/03/30 00:06:06 UTC
Review Request 45448: GEODE-337 Now test waits until client queue has
been paused before restarting the client
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45448/
-----------------------------------------------------------
Review request for geode, Bruce Schuchardt, Jianxia Chen, and Udo Kohlmeyer.
Repository: geode
Description
-------
If client tries to reconnect while proxy is not paused then that client unable to re-connect to server
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientProxy.java d6226b5
geode-core/src/test/java/com/gemstone/gemfire/management/ClientHealthStatsDUnitTest.java 721be03
Diff: https://reviews.apache.org/r/45448/diff/
Testing
-------
Thanks,
Hitesh Khamesra
Re: Review Request 45448: GEODE-337 Now test waits until client queue
has been paused before restarting the client
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45448/#review125967
-----------------------------------------------------------
Ship it!
Ship It!
- Bruce Schuchardt
On March 29, 2016, 10:06 p.m., Hitesh Khamesra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45448/
> -----------------------------------------------------------
>
> (Updated March 29, 2016, 10:06 p.m.)
>
>
> Review request for geode, Bruce Schuchardt, Jianxia Chen, and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> If client tries to reconnect while proxy is not paused then that client unable to re-connect to server
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientProxy.java d6226b5
> geode-core/src/test/java/com/gemstone/gemfire/management/ClientHealthStatsDUnitTest.java 721be03
>
> Diff: https://reviews.apache.org/r/45448/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hitesh Khamesra
>
>
Re: Review Request 45448: GEODE-337 Now test waits until client queue
has been paused before restarting the client
Posted by Udo Kohlmeyer <uk...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45448/#review125977
-----------------------------------------------------------
geode-core/src/test/java/com/gemstone/gemfire/management/ClientHealthStatsDUnitTest.java (line 218)
<https://reviews.apache.org/r/45448/#comment188894>
not sure that this method has to be "static". Could it not just be "private"?
- Udo Kohlmeyer
On March 29, 2016, 10:06 p.m., Hitesh Khamesra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45448/
> -----------------------------------------------------------
>
> (Updated March 29, 2016, 10:06 p.m.)
>
>
> Review request for geode, Bruce Schuchardt, Jianxia Chen, and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> If client tries to reconnect while proxy is not paused then that client unable to re-connect to server
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientProxy.java d6226b5
> geode-core/src/test/java/com/gemstone/gemfire/management/ClientHealthStatsDUnitTest.java 721be03
>
> Diff: https://reviews.apache.org/r/45448/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hitesh Khamesra
>
>