You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Alok Lal <al...@hortonworks.com> on 2016/01/06 23:15:14 UTC

Review Request 41996: Move Context enricher implementation RangerFileBasedGeolocationProvider out of test into prod

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41996/
-----------------------------------------------------------

Review request for ranger, Abhay Kulkarni and Madhan Neethiraj.


Bugs: RANGER-800
    https://issues.apache.org/jira/browse/RANGER-800


Repository: ranger


Description
-------

Moved Context enricher implementation RangerFileBasedGeolocationProvider out of test into prod


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerFileBasedGeolocationProvider.java PRE-CREATION 
  agents-common/src/test/java/org/apache/ranger/plugin/contextenricher/RangerFileBasedGeolocationProvider.java ea599c7 

Diff: https://reviews.apache.org/r/41996/diff/


Testing
-------

existing junits work. assembly phase works. veryfy phase works.


Thanks,

Alok Lal


Re: Review Request 41996: Move Context enricher implementation RangerFileBasedGeolocationProvider out of test into prod

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41996/#review113146
-----------------------------------------------------------

Ship it!


Ship It!

- Madhan Neethiraj


On Jan. 6, 2016, 10:15 p.m., Alok Lal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41996/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2016, 10:15 p.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni and Madhan Neethiraj.
> 
> 
> Bugs: RANGER-800
>     https://issues.apache.org/jira/browse/RANGER-800
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Moved Context enricher implementation RangerFileBasedGeolocationProvider out of test into prod
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerFileBasedGeolocationProvider.java PRE-CREATION 
>   agents-common/src/test/java/org/apache/ranger/plugin/contextenricher/RangerFileBasedGeolocationProvider.java ea599c7 
> 
> Diff: https://reviews.apache.org/r/41996/diff/
> 
> 
> Testing
> -------
> 
> existing junits work. assembly phase works. veryfy phase works.
> 
> 
> Thanks,
> 
> Alok Lal
> 
>