You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/29 10:39:10 UTC
[GitHub] [arrow-datafusion] retikulum opened a new pull request, #4422: fix panic on to_hex function for negative numbers
retikulum opened a new pull request, #4422:
URL: https://github.com/apache/arrow-datafusion/pull/4422
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #4339.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Better control for `to_hex` function
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
Now it returns error if it can't cast. There was a `unwrap` usage before this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove merged pull request #4422: fix panic on to_hex function for negative numbers
Posted by GitBox <gi...@apache.org>.
andygrove merged PR #4422:
URL: https://github.com/apache/arrow-datafusion/pull/4422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #4422: fix panic on to_hex function for negative numbers
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #4422:
URL: https://github.com/apache/arrow-datafusion/pull/4422#issuecomment-1332339963
Benchmark runs are scheduled for baseline = 522a2a4adea48777f330cac074db94a4da3ea66b and contender = 23b4495516a5a6246e1732bca4f82bb065b021be. 23b4495516a5a6246e1732bca4f82bb065b021be is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/4504a773120047c3bba8a0d82cc7b60b...8871c1cd43d94ab496e673131ae7a865/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/a1c91d14ffc54f8d9663675d20400b9d...4331a49d67e441e3b0d6d360d719ecf3/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/a98dc8f7bf65471d9faf2d3cee177e17...0238e6713cd94eca89b1eea21b228d8d/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/67aca4017ca7465ab272ced1ae7b680f...42f7374f0453414badd885e1a781325a/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] retikulum commented on pull request #4422: fix panic on to_hex function for negative numbers
Posted by GitBox <gi...@apache.org>.
retikulum commented on PR #4422:
URL: https://github.com/apache/arrow-datafusion/pull/4422#issuecomment-1331186709
> Thanks @retikulum -- the code looks great! Can you please add a test so we don't accidentally break this feature in the future?
I have added some tests. Could you please check if they are good enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org