You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/08/12 14:49:38 UTC

[GitHub] [pulsar] jianyun8023 commented on pull request #7802: Support set MaxUnackMessagesPerSubscription on topic level

jianyun8023 commented on pull request #7802:
URL: https://github.com/apache/pulsar/pull/7802#issuecomment-672918381


   Can I not pass `AsyncResponse` to the base class? Make `internalSetMaxUnackedMessagesOnSubscription` return `CompletableFuture<Void>`. Other methods are like this
   I think this can the base class and make it cleaner. en, I am going to post an issue description.
   
   @codelipenghui What do you think？
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org