[GitHub] ZiyueHuang commented on a change in pull request #9189: standard update for sparse sgd_mom_update

[GitBox <gi...@apache.org>]

ZiyueHuang commented on a change in pull request #9189: standard update for sparse sgd_mom_update
URL: https://github.com/apache/incubator-mxnet/pull/9189#discussion_r159153519
 
 

 ##########
 File path: src/operator/optimizer_op.cc
 ##########
 @@ -96,11 +147,15 @@ only the row slices whose indices appear in grad.indices are updated (for both w
 .set_attr_parser(ParamParser<SGDMomParam>)
 .set_attr<nnvm::FInferShape>("FInferShape", ElemwiseShape<3, 1>)
 .set_attr<nnvm::FInferType>("FInferType", ElemwiseType<3, 1>)
-.set_attr<FInferStorageType>("FInferStorageType", ElemwiseStorageType<3, 1, false, true, false>)
 
 Review comment:
   Updated

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services