You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Arun C Murthy (JIRA)" <ji...@apache.org> on 2008/07/31 03:20:31 UTC

[jira] Created: (HADOOP-3875) Fix TaskTracker's heartbeat timer to note the time the hearbeat RPC returned to decide next heartbeat time

Fix TaskTracker's heartbeat timer to note the time the hearbeat RPC returned to decide next heartbeat time
----------------------------------------------------------------------------------------------------------

                 Key: HADOOP-3875
                 URL: https://issues.apache.org/jira/browse/HADOOP-3875
             Project: Hadoop Core
          Issue Type: Bug
          Components: mapred
    Affects Versions: 0.18.0
            Reporter: Arun C Murthy
            Assignee: Arun C Murthy
             Fix For: 0.19.0


The tasktracker notes the time the heartbeat RPC was fired, rather than when it returned to decide when to send the next one. If the RPC spends a lot of time in the JobTracker's queue then the above exacerbates the load on the JobTracker.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3875) Fix TaskTracker's heartbeat timer to note the time the hearbeat RPC returned to decide next heartbeat time

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618600#action_12618600 ] 

Hadoop QA commented on HADOOP-3875:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12387250/HADOOP-3875_0_20080730.patch
  against trunk revision 681243.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2990/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2990/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2990/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2990/console

This message is automatically generated.

> Fix TaskTracker's heartbeat timer to note the time the hearbeat RPC returned to decide next heartbeat time
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3875
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3875
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.18.0
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>             Fix For: 0.19.0
>
>         Attachments: HADOOP-3875_0_20080730.patch
>
>
> The tasktracker notes the time the heartbeat RPC was fired, rather than when it returned to decide when to send the next one. If the RPC spends a lot of time in the JobTracker's queue then the above exacerbates the load on the JobTracker.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3875) Fix TaskTracker's heartbeat timer to note the time the hearbeat RPC returned to decide next heartbeat time

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-3875:
----------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I just committed this. Thanks, Arun!

> Fix TaskTracker's heartbeat timer to note the time the hearbeat RPC returned to decide next heartbeat time
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3875
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3875
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.18.0
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>             Fix For: 0.19.0
>
>         Attachments: HADOOP-3875_0_20080730.patch
>
>
> The tasktracker notes the time the heartbeat RPC was fired, rather than when it returned to decide when to send the next one. If the RPC spends a lot of time in the JobTracker's queue then the above exacerbates the load on the JobTracker.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3875) Fix TaskTracker's heartbeat timer to note the time the hearbeat RPC returned to decide next heartbeat time

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy updated HADOOP-3875:
----------------------------------

    Status: Patch Available  (was: Open)

> Fix TaskTracker's heartbeat timer to note the time the hearbeat RPC returned to decide next heartbeat time
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3875
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3875
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.18.0
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>             Fix For: 0.19.0
>
>         Attachments: HADOOP-3875_0_20080730.patch
>
>
> The tasktracker notes the time the heartbeat RPC was fired, rather than when it returned to decide when to send the next one. If the RPC spends a lot of time in the JobTracker's queue then the above exacerbates the load on the JobTracker.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3875) Fix TaskTracker's heartbeat timer to note the time the hearbeat RPC returned to decide next heartbeat time

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618579#action_12618579 ] 

Arun C Murthy commented on HADOOP-3875:
---------------------------------------

Also, there is a redundant call to System.currentTime in TaskTracker.transmitHeartbeat - that information is already available at TaskTracker.offerService, we should just pass it down.

> Fix TaskTracker's heartbeat timer to note the time the hearbeat RPC returned to decide next heartbeat time
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3875
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3875
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.18.0
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>             Fix For: 0.19.0
>
>
> The tasktracker notes the time the heartbeat RPC was fired, rather than when it returned to decide when to send the next one. If the RPC spends a lot of time in the JobTracker's queue then the above exacerbates the load on the JobTracker.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3875) Fix TaskTracker's heartbeat timer to note the time the hearbeat RPC returned to decide next heartbeat time

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624728#action_12624728 ] 

Hudson commented on HADOOP-3875:
--------------------------------

Integrated in Hadoop-trunk #581 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/581/])

> Fix TaskTracker's heartbeat timer to note the time the hearbeat RPC returned to decide next heartbeat time
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3875
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3875
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.18.0
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>             Fix For: 0.19.0
>
>         Attachments: HADOOP-3875_0_20080730.patch
>
>
> The tasktracker notes the time the heartbeat RPC was fired, rather than when it returned to decide when to send the next one. If the RPC spends a lot of time in the JobTracker's queue then the above exacerbates the load on the JobTracker.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3875) Fix TaskTracker's heartbeat timer to note the time the hearbeat RPC returned to decide next heartbeat time

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy updated HADOOP-3875:
----------------------------------

    Attachment: HADOOP-3875_0_20080730.patch

Straight-forward patch...

> Fix TaskTracker's heartbeat timer to note the time the hearbeat RPC returned to decide next heartbeat time
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3875
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3875
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.18.0
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>             Fix For: 0.19.0
>
>         Attachments: HADOOP-3875_0_20080730.patch
>
>
> The tasktracker notes the time the heartbeat RPC was fired, rather than when it returned to decide when to send the next one. If the RPC spends a lot of time in the JobTracker's queue then the above exacerbates the load on the JobTracker.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3875) Fix TaskTracker's heartbeat timer to note the time the hearbeat RPC returned to decide next heartbeat time

Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amareshwari Sriramadasu updated HADOOP-3875:
--------------------------------------------

    Hadoop Flags: [Reviewed]

+1

> Fix TaskTracker's heartbeat timer to note the time the hearbeat RPC returned to decide next heartbeat time
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3875
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3875
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.18.0
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>             Fix For: 0.19.0
>
>         Attachments: HADOOP-3875_0_20080730.patch
>
>
> The tasktracker notes the time the heartbeat RPC was fired, rather than when it returned to decide when to send the next one. If the RPC spends a lot of time in the JobTracker's queue then the above exacerbates the load on the JobTracker.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.