You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@gmail.com> on 2008/10/09 01:29:24 UTC
Re: svn commit: r33562 - branches/issue-3067-deleted-subtrees/subversion/libsvn_ra_serf
On Wed, Oct 8, 2008 at 3:03 PM, <pb...@tigris.org> wrote:
>...
> +++ branches/issue-3067-deleted-subtrees/subversion/libsvn_ra_serf/get_deleted_rev.c Wed Oct 8 15:03:56 2008 (r33562)
>...
> +typedef struct {
> + /* The currently collected value as we build it up */
> + const char *tmp;
> + apr_size_t tmp_len;
> +} drev_info_t;
Why this structure? Why not svn_string_t or svn_stringbuf_t ??
Cheers,
-g
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r33562 - branches/issue-3067-deleted-subtrees/subversion/libsvn_ra_serf
Posted by Paul Burba <pt...@gmail.com>.
On Wed, Oct 8, 2008 at 9:29 PM, Greg Stein <gs...@gmail.com> wrote:
> On Wed, Oct 8, 2008 at 3:03 PM, <pb...@tigris.org> wrote:
>>...
>> +++ branches/issue-3067-deleted-subtrees/subversion/libsvn_ra_serf/get_deleted_rev.c Wed Oct 8 15:03:56 2008 (r33562)
>>...
>> +typedef struct {
>> + /* The currently collected value as we build it up */
>> + const char *tmp;
>> + apr_size_t tmp_len;
>> +} drev_info_t;
>
> Why this structure? Why not svn_string_t or svn_stringbuf_t ??
Hi Greg,
No good reason...I was following the example of similar code a bit too
blindly. Replaced with svn_string_t in r33781.
Paul
> Cheers,
> -g
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org