You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "nastra (via GitHub)" <gi...@apache.org> on 2024/06/03 13:53:35 UTC
Re: [PR] Core: Fix create v1 table on REST Catalog [iceberg]
nastra commented on code in PR #10369:
URL: https://github.com/apache/iceberg/pull/10369#discussion_r1624502953
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -861,6 +862,19 @@ public static Builder buildFromEmpty() {
return new Builder();
}
+ public static Builder buildFromMetadataUpdates(List<MetadataUpdate> metadataUpdates) {
Review Comment:
I don't think we should expose this in `TableMetadata`. It should be fine to have this inside `CatalogHandlers#create`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org