[GitHub] [orc] belugabehr commented on pull request #756: ORC-854: Optimize ReadFully for Full Reads

[GitBox <gi...@apache.org>]

belugabehr commented on pull request #756:
URL: https://github.com/apache/orc/pull/756#issuecomment-886682195


   > Also, since we've been adding a lot of smaller optimizations recently (which can indeed have a big effect in some cases), would it be a good idea to establish something like JMH benchmarks or something to ensure that the optimizations make sense? I know JMH isn't perfect, and many of the optimization PRs have been visually apparent to be optimizing, but throwing that out there to see what others think.
   
   I think something like ORC should definitely have that, and looking at the code, there might even be some JMH tests in there, but we would need additional documentation on how to do that.
   
   For now, I am using the performance benchmarks currently available, using simple timers and/or examining under a profiler.  I've come up with quite a few ideas for PRs, but not all of them have shown much perf improvement and I don't bother submitting them. :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org