You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@spark.apache.org by "Apache Spark (JIRA)" <ji...@apache.org> on 2014/12/18 20:49:13 UTC

[jira] [Commented] (SPARK-4887) Fix a bad unittest in LogisticRegressionSuite

    [ https://issues.apache.org/jira/browse/SPARK-4887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14252130#comment-14252130 ] 

Apache Spark commented on SPARK-4887:
-------------------------------------

User 'dbtsai' has created a pull request for this issue:
https://github.com/apache/spark/pull/3735

> Fix a bad unittest in LogisticRegressionSuite
> ---------------------------------------------
>
>                 Key: SPARK-4887
>                 URL: https://issues.apache.org/jira/browse/SPARK-4887
>             Project: Spark
>          Issue Type: Bug
>          Components: MLlib
>            Reporter: DB Tsai
>
> The original test doesn't make sense since if you step in, the lossSum already NaN, and the coefficients are diverging. That's because the step size is too large for SGD, so it doesn't work. The correct behavior is that you should get smaller coefficients than the one without regularization. Comparing the values using 20000.0 relative error doesn't make sense as well. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org