You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/07/24 16:22:16 UTC
[GitHub] [spark] tgravescs opened a new pull request #29225: [SPARK-32287][TESTS] Flaky Test: ExecutorAllocationManagerSuite.add executors default profile
tgravescs opened a new pull request #29225:
URL: https://github.com/apache/spark/pull/29225
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
I wasn't able to reproduce the failure but the best I can tell is that the allocation manager timer triggers and call doRequest. The timeout is 10s so try to increase that to 30seconds.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
test failure
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
no
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
unit test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29225: [SPARK-32287][TESTS] Flaky Test: ExecutorAllocationManagerSuite.add executors default profile
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #29225:
URL: https://github.com/apache/spark/pull/29225#discussion_r460194831
##########
File path: core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala
##########
@@ -1603,7 +1603,7 @@ class ExecutorAllocationManagerSuite extends SparkFunSuite {
.set(config.DYN_ALLOCATION_TESTING, true)
// SPARK-22864: effectively disable the allocation schedule by setting the period to a
// really long value.
- .set(TEST_SCHEDULE_INTERVAL, 10000L)
+ .set(TEST_SCHEDULE_INTERVAL, 30000L)
Review comment:
So, this is for the same reason with SPARK-22864 at line 1604?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on pull request #29225: [SPARK-32287][TESTS] Flaky Test: ExecutorAllocationManagerSuite.add executors default profile
Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on pull request #29225:
URL: https://github.com/apache/spark/pull/29225#issuecomment-667433163
Oh it shows the timstamps when you download the log. I'll share the timestamps too later when I happene to see this again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29225: [SPARK-32287][TESTS] Flaky Test: ExecutorAllocationManagerSuite.add executors default profile
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29225:
URL: https://github.com/apache/spark/pull/29225#issuecomment-664761409
Thank you @tgravescs for fixing this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29225: [SPARK-32287][TESTS] Flaky Test: ExecutorAllocationManagerSuite.add executors default profile
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29225:
URL: https://github.com/apache/spark/pull/29225#issuecomment-663672410
Sure~ I'll monitor on GitHub Action result. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on a change in pull request #29225: [SPARK-32287][TESTS] Flaky Test: ExecutorAllocationManagerSuite.add executors default profile
Posted by GitBox <gi...@apache.org>.
tgravescs commented on a change in pull request #29225:
URL: https://github.com/apache/spark/pull/29225#discussion_r471478921
##########
File path: core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala
##########
@@ -1603,7 +1603,7 @@ class ExecutorAllocationManagerSuite extends SparkFunSuite {
.set(config.DYN_ALLOCATION_TESTING, true)
// SPARK-22864: effectively disable the allocation schedule by setting the period to a
// really long value.
- .set(TEST_SCHEDULE_INTERVAL, 10000L)
+ .set(TEST_SCHEDULE_INTERVAL, 30000L)
Review comment:
I'm not seeing. a test report in that run?
Yes but it seemed like the failures we were seeing before we after an interation or two or the test starting, although it did vary. If we can see the logs from it we should be able to see timing and possibly some log messages to tell us if that is the problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #29225: [SPARK-32287][TESTS] Flaky Test: ExecutorAllocationManagerSuite.add executors default profile
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #29225:
URL: https://github.com/apache/spark/pull/29225
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on a change in pull request #29225: [SPARK-32287][TESTS] Flaky Test: ExecutorAllocationManagerSuite.add executors default profile
Posted by GitBox <gi...@apache.org>.
tgravescs commented on a change in pull request #29225:
URL: https://github.com/apache/spark/pull/29225#discussion_r473037545
##########
File path: core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala
##########
@@ -1603,7 +1603,7 @@ class ExecutorAllocationManagerSuite extends SparkFunSuite {
.set(config.DYN_ALLOCATION_TESTING, true)
// SPARK-22864: effectively disable the allocation schedule by setting the period to a
// really long value.
- .set(TEST_SCHEDULE_INTERVAL, 10000L)
+ .set(TEST_SCHEDULE_INTERVAL, 30000L)
Review comment:
thanks for updating and uploading the logs, let me know if you see a build that has this test failure and I'll look at the log
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on pull request #29225: [SPARK-32287][TESTS] Flaky Test: ExecutorAllocationManagerSuite.add executors default profile
Posted by GitBox <gi...@apache.org>.
tgravescs commented on pull request #29225:
URL: https://github.com/apache/spark/pull/29225#issuecomment-678326004
so @Ngone51 found this again here:
for the flaky ExecutorAllocationManagerSuite : https://github.com/apache/spark/pull/29452/checks?check_run_id=1008962797
entire test suite ran in less then 5 seconds
The logs that I see are fine up til it fails but the output is intermixed with other test Suites running so its hard to differentiate some of the logs. The only path I see this can changed would be on a decrement triggered by an updateAndSync and the only way it should hit that is if the timer fired. So it might be the initial timer as stated above. I'll put up a PR with some more debugging enabled to see if I can verify it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29225: [SPARK-32287][TESTS] Flaky Test: ExecutorAllocationManagerSuite.add executors default profile
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29225:
URL: https://github.com/apache/spark/pull/29225#issuecomment-667433163
Oh it shows wthe timstamps when you download the log. I'll share the timestamps too later when I happene to see this again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on pull request #29225: [SPARK-32287][TESTS] Flaky Test: ExecutorAllocationManagerSuite.add executors default profile
Posted by GitBox <gi...@apache.org>.
tgravescs commented on pull request #29225:
URL: https://github.com/apache/spark/pull/29225#issuecomment-663669383
thanks @dongjoon-hyun if you see this failing again let me know and I'll try to reproduce again. I ran it in a subset of the tests in a loop and wasn't able to reproduce locally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on pull request #29225: [SPARK-32287][TESTS] Flaky Test: ExecutorAllocationManagerSuite.add executors default profile
Posted by GitBox <gi...@apache.org>.
tgravescs commented on pull request #29225:
URL: https://github.com/apache/spark/pull/29225#issuecomment-667123030
is there anyway to access the unit test detailed logs from GitHub action?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #29225: [SPARK-32287][TESTS] Flaky Test: ExecutorAllocationManagerSuite.add executors default profile
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #29225:
URL: https://github.com/apache/spark/pull/29225#discussion_r471554630
##########
File path: core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala
##########
@@ -1603,7 +1603,7 @@ class ExecutorAllocationManagerSuite extends SparkFunSuite {
.set(config.DYN_ALLOCATION_TESTING, true)
// SPARK-22864: effectively disable the allocation schedule by setting the period to a
// really long value.
- .set(TEST_SCHEDULE_INTERVAL, 10000L)
+ .set(TEST_SCHEDULE_INTERVAL, 30000L)
Review comment:
I think I can try to upload that specific log file as an artifact. Let me take a look in coming few days.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29225: [SPARK-32287][TESTS] Flaky Test: ExecutorAllocationManagerSuite.add executors default profile
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29225:
URL: https://github.com/apache/spark/pull/29225#issuecomment-678582621
Thank you @tgravescs a lot for taking a look for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29225: [SPARK-32287][TESTS] Flaky Test: ExecutorAllocationManagerSuite.add executors default profile
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29225:
URL: https://github.com/apache/spark/pull/29225#issuecomment-663686140
**[Test build #126506 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126506/testReport)** for PR 29225 at commit [`3af6ab9`](https://github.com/apache/spark/commit/3af6ab923914575a85a097d6b75d69cee26af275).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29225: [SPARK-32287][TESTS] Flaky Test: ExecutorAllocationManagerSuite.add executors default profile
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29225:
URL: https://github.com/apache/spark/pull/29225#issuecomment-663623399
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29225: [SPARK-32287][TESTS] Flaky Test: ExecutorAllocationManagerSuite.add executors default profile
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29225:
URL: https://github.com/apache/spark/pull/29225#issuecomment-663622742
**[Test build #126506 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126506/testReport)** for PR 29225 at commit [`3af6ab9`](https://github.com/apache/spark/commit/3af6ab923914575a85a097d6b75d69cee26af275).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29225: [SPARK-32287][TESTS] Flaky Test: ExecutorAllocationManagerSuite.add executors default profile
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29225:
URL: https://github.com/apache/spark/pull/29225#issuecomment-663623399
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on pull request #29225: [SPARK-32287][TESTS] Flaky Test: ExecutorAllocationManagerSuite.add executors default profile
Posted by GitBox <gi...@apache.org>.
tgravescs commented on pull request #29225:
URL: https://github.com/apache/spark/pull/29225#issuecomment-663620542
@Ngone51
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on a change in pull request #29225: [SPARK-32287][TESTS] Flaky Test: ExecutorAllocationManagerSuite.add executors default profile
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #29225:
URL: https://github.com/apache/spark/pull/29225#discussion_r471211841
##########
File path: core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala
##########
@@ -1603,7 +1603,7 @@ class ExecutorAllocationManagerSuite extends SparkFunSuite {
.set(config.DYN_ALLOCATION_TESTING, true)
// SPARK-22864: effectively disable the allocation schedule by setting the period to a
// really long value.
- .set(TEST_SCHEDULE_INTERVAL, 10000L)
+ .set(TEST_SCHEDULE_INTERVAL, 30000L)
Review comment:
@tgravescs It happens again at: https://github.com/apache/spark/pull/29418/checks?check_run_id=975304054
BTW, this change only prevents the automatic invocation of `schedule()` for the second time but the first time invocation of `schedule()` always happens because the `initialDelay` is 0?
https://github.com/apache/spark/blob/8f0fef18438aa8fb07f5ed885ffad1339992f102/core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala#L250
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29225: [SPARK-32287][TESTS] Flaky Test: ExecutorAllocationManagerSuite.add executors default profile
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29225:
URL: https://github.com/apache/spark/pull/29225#issuecomment-663687158
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on a change in pull request #29225: [SPARK-32287][TESTS] Flaky Test: ExecutorAllocationManagerSuite.add executors default profile
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #29225:
URL: https://github.com/apache/spark/pull/29225#discussion_r471485011
##########
File path: core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala
##########
@@ -1603,7 +1603,7 @@ class ExecutorAllocationManagerSuite extends SparkFunSuite {
.set(config.DYN_ALLOCATION_TESTING, true)
// SPARK-22864: effectively disable the allocation schedule by setting the period to a
// really long value.
- .set(TEST_SCHEDULE_INTERVAL, 10000L)
+ .set(TEST_SCHEDULE_INTERVAL, 30000L)
Review comment:
> I'm not seeing. a test report in that run?
You need to scroll to the end of ` Run tests: core, unsafe, kvstore, avro` section to see the failed tests.
> Yes but it seemed like the failures we were seeing before we after an interation or two or the test starting, although it did vary.
Ok, not aware of that...
> If we can see the logs from it we should be able to see timing and possibly some log messages to tell us if that is the problem.
@tgravescs A feasible way to debug it is to open a PR in your own fork repository and adds some `println` in the source code.
@HyukjinKwon I think we still can not see the complete logs in GithubActions like the `unit-test.log` in Jenkins. I mean, even we download the archive logs after checks finished.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29225: [SPARK-32287][TESTS] Flaky Test: ExecutorAllocationManagerSuite.add executors default profile
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29225:
URL: https://github.com/apache/spark/pull/29225#issuecomment-663622742
**[Test build #126506 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126506/testReport)** for PR 29225 at commit [`3af6ab9`](https://github.com/apache/spark/commit/3af6ab923914575a85a097d6b75d69cee26af275).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29225: [SPARK-32287][TESTS] Flaky Test: ExecutorAllocationManagerSuite.add executors default profile
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29225:
URL: https://github.com/apache/spark/pull/29225#issuecomment-666900157
I saw this again:
```
[info] - add executors default profile *** FAILED *** (38 milliseconds)
[info] 4 did not equal 2 (ExecutorAllocationManagerSuite.scala:132)
[info] org.scalatest.exceptions.TestFailedException:
[info] at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:472)
[info] at org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:471)
[info] at org.scalatest.Assertions$.newAssertionFailedException(Assertions.scala:1231)
[info] at org.scalatest.Assertions$AssertionsHelper.macroAssert(Assertions.scala:1295)
[info] at org.apache.spark.ExecutorAllocationManagerSuite.$anonfun$new$7(ExecutorAllocationManagerSuite.scala:132)
[info] at org.scalatest.OutcomeOf.outcomeOf(OutcomeOf.scala:85)
[info] at org.scalatest.OutcomeOf.outcomeOf$(OutcomeOf.scala:83)
[info] at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104)
[info] at org.scalatest.Transformer.apply(Transformer.scala:22)
[info] at org.scalatest.Transformer.apply(Transformer.scala:20)
[info] at org.scalatest.funsuite.AnyFunSuiteLike$$anon$1.apply(AnyFunSuiteLike.scala:189)
[info] at org.apache.spark.SparkFunSuite.withFixture(SparkFunSuite.scala:158)
[info] at org.scalatest.funsuite.AnyFunSuiteLike.invokeWithFixture$1(AnyFunSuiteLike.scala:187)
[info] at org.scalatest.funsuite.AnyFunSuiteLike.$anonfun$runTest$1(AnyFunSuiteLike.scala:199)
[info] at org.scalatest.SuperEngine.runTestImpl(Engine.scala:306)
```
with:
```
[info] - add executors capped by num pending tasks *** FAILED *** (77 milliseconds)
[info] 6 did not equal 5 (ExecutorAllocationManagerSuite.scala:428)
[info] org.scalatest.exceptions.TestFailedException:
[info] at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:472)
[info] at org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:471)
[info] at org.scalatest.Assertions$.newAssertionFailedException(Assertions.scala:1231)
[info] at org.scalatest.Assertions$AssertionsHelper.macroAssert(Assertions.scala:1295)
[info] at org.apache.spark.ExecutorAllocationManagerSuite.$anonfun$new$18(ExecutorAllocationManagerSuite.scala:428)
[info] at org.scalatest.OutcomeOf.outcomeOf(OutcomeOf.scala:85)
[info] at org.scalatest.OutcomeOf.outcomeOf$(OutcomeOf.scala:83)
[info] at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104)
[info] at org.scalatest.Transformer.apply(Transformer.scala:22)
[info] at org.scalatest.Transformer.apply(Transformer.scala:20)
[info] at org.scalatest.funsuite.AnyFunSuiteLike$$anon$1.apply(AnyFunSuiteLike.scala:189)
[info] at org.apache.spark.SparkFunSuite.withFixture(SparkFunSuite.scala:158)
[info] at org.scalatest.funsuite.AnyFunSuiteLike.invokeWithFixture$1(AnyFunSuiteLike.scala:187)
[info] at org.scalatest.funsuite.AnyFunSuiteLike.$anonfun$runTest$1(AnyFunSuiteLike.scala:199)
[info] at org.scalatest.SuperEngine.runTestImpl(Engine.scala:306)
[info] at org.scalatest.funsuite.AnyFunSuiteLike.runTest(AnyFunSuiteLike.scala:199)
```
at https://github.com/apache/spark/pull/29278/checks?check_run_id=930261611. I am retriggering.
I will monitor a bit more and update here. If the flakiness is very rare, it would be fine for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on pull request #29225: [SPARK-32287][TESTS] Flaky Test: ExecutorAllocationManagerSuite.add executors default profile
Posted by GitBox <gi...@apache.org>.
tgravescs commented on pull request #29225:
URL: https://github.com/apache/spark/pull/29225#issuecomment-667127868
It would be really nice if we could get some timestamps on how long tests were taking
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on a change in pull request #29225: [SPARK-32287][TESTS] Flaky Test: ExecutorAllocationManagerSuite.add executors default profile
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #29225:
URL: https://github.com/apache/spark/pull/29225#discussion_r471865229
##########
File path: core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala
##########
@@ -1603,7 +1603,7 @@ class ExecutorAllocationManagerSuite extends SparkFunSuite {
.set(config.DYN_ALLOCATION_TESTING, true)
// SPARK-22864: effectively disable the allocation schedule by setting the period to a
// really long value.
- .set(TEST_SCHEDULE_INTERVAL, 10000L)
+ .set(TEST_SCHEDULE_INTERVAL, 30000L)
Review comment:
BTW, the `unit-tests.log` file is generated by `log4j`:
https://github.com/apache/spark/blob/b33066f42bd474f5f80b14221f97d09a76e0b398/core/src/test/resources/log4j.properties#L23
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #29225: [SPARK-32287][TESTS] Flaky Test: ExecutorAllocationManagerSuite.add executors default profile
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #29225:
URL: https://github.com/apache/spark/pull/29225#discussion_r471554630
##########
File path: core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala
##########
@@ -1603,7 +1603,7 @@ class ExecutorAllocationManagerSuite extends SparkFunSuite {
.set(config.DYN_ALLOCATION_TESTING, true)
// SPARK-22864: effectively disable the allocation schedule by setting the period to a
// really long value.
- .set(TEST_SCHEDULE_INTERVAL, 10000L)
+ .set(TEST_SCHEDULE_INTERVAL, 30000L)
Review comment:
I think I can try to upload that specific log file as an artifact (so we can download) Let me take a look in coming few days.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29225: [SPARK-32287][TESTS] Flaky Test: ExecutorAllocationManagerSuite.add executors default profile
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29225:
URL: https://github.com/apache/spark/pull/29225#issuecomment-663687158
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org