You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zookeeper.apache.org by andschwa <gi...@git.apache.org> on 2018/03/09 21:17:46 UTC

[GitHub] zookeeper pull request #485: ZOOKEEPER-2997: CMake should not force static C...

GitHub user andschwa opened a pull request:

    https://github.com/apache/zookeeper/pull/485

    ZOOKEEPER-2997: CMake should not force static CRT linking

    By removing this code, CMake will use its own defaults for the CRT
    flags (e.g., `/MDd` for debug configurations). With it removed, the
    user can override this behavior by setting the `CMAKE_CXX_FLAGS`
    manually when configuring ZooKeeper.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/andschwa/zookeeper ZOOKEEPER-2997

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/485.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #485
    
----
commit 45a997ad0e281d967460f4eb205a4b18e4219ecd
Author: Andrew Schwartzmeyer <an...@...>
Date:   2018-03-09T21:00:48Z

    ZOOKEEPER-2997: CMake should not force static CRT linking
    
    By removing this code, CMake will use its own defaults for the CRT
    flags (e.g., `/MDd` for debug configurations). With it removed, the
    user can override this behavior by setting the `CMAKE_CXX_FLAGS`
    manually when configuring ZooKeeper.

----


---

[GitHub] zookeeper issue #485: ZOOKEEPER-2997: CMake should not force static CRT link...

Posted by andschwa <gi...@git.apache.org>.

Github user andschwa commented on the issue:

    https://github.com/apache/zookeeper/pull/485
  
    CI errors look spurious...


---

[GitHub] zookeeper issue #485: ZOOKEEPER-2997: CMake should not force static CRT link...

Posted by andschwa <gi...@git.apache.org>.

Github user andschwa commented on the issue:

    https://github.com/apache/zookeeper/pull/485
  
    [JIRA: ZOOKEEPER-2997](https://issues.apache.org/jira/browse/ZOOKEEPER-2997)


---

[GitHub] zookeeper pull request #485: ZOOKEEPER-2997: CMake should not force static C...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zookeeper/pull/485


---

[GitHub] zookeeper issue #485: ZOOKEEPER-2997: CMake should not force static CRT link...

Posted by andschwa <gi...@git.apache.org>.

Github user andschwa commented on the issue:

    https://github.com/apache/zookeeper/pull/485
  
    Thanks @hanm!


---

[GitHub] zookeeper issue #485: ZOOKEEPER-2997: CMake should not force static CRT link...

Posted by andschwa <gi...@git.apache.org>.

Github user andschwa commented on the issue:

    https://github.com/apache/zookeeper/pull/485
  
    I had to reopen this because I changed which branch it was from.


---