You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/19 12:27:36 UTC
[GitHub] [cloudstack] Pearl1594 opened a new pull request #4713: API: Increase leniency to list templates on secondary stores that hae been marked deleted by updating the db
Pearl1594 opened a new pull request #4713:
URL: https://github.com/apache/cloudstack/pull/4713
### Description
This PR aims at restoring the previous level of leniency in listing templates on stores that have been marked as deleted / removed by updating the DB.
While Cloudstack doesn't allow deleting stores that have resources on them, it may so happen that users may mimic a deletion of a store by merely updating the DB. Under such a case, listing of templates is hampered due to an NPE that is caused. (as seen in https://github.com/apache/cloudstack/issues/4606)
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
Mark an image store having templates (public/private) on them as deleted by updating the DB i.e., setting the removed field to some timestamp
Try listing the templates, should list all templates as usual
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4713: API: Increase leniency to list templates on secondary stores that have been marked deleted by updating the db
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4713:
URL: https://github.com/apache/cloudstack/pull/4713#issuecomment-783904742
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4713: API: Increase leniency to list templates on secondary stores that have been marked deleted by updating the db
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4713:
URL: https://github.com/apache/cloudstack/pull/4713#issuecomment-783902471
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4713: API: Increase leniency to list templates on secondary stores that have been marked deleted by updating the db
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4713:
URL: https://github.com/apache/cloudstack/pull/4713
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4713: API: Increase leniency to list templates on secondary stores that have been marked deleted by updating the db
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4713:
URL: https://github.com/apache/cloudstack/pull/4713#issuecomment-783938331
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2799
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4713: API: Increase leniency to list templates on secondary stores that have been marked deleted by updating the db
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4713:
URL: https://github.com/apache/cloudstack/pull/4713#issuecomment-784035724
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4713: API: Increase leniency to list templates on secondary stores that have been marked deleted by updating the db
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4713:
URL: https://github.com/apache/cloudstack/pull/4713#issuecomment-784034994
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4713: API: Increase leniency to list templates on secondary stores that have been marked deleted by updating the db
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4713:
URL: https://github.com/apache/cloudstack/pull/4713#issuecomment-784442911
<b>Trillian test result (tid-3602)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32462 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4713-t3602-kvm-centos7.zip
Smoke tests completed. 86 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org