You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2019/01/23 07:09:23 UTC

Review Request 69812: Implemented the RPC retry logic for SLRP.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69812/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.


Bugs: MESOS-9517
    https://issues.apache.org/jira/browse/MESOS-9517


Repository: mesos


Description
-------

When the CSI plugin returns a retryable error (i.e., `DEADLINE_EXCEEDED`
or `UNAVAILABLE`) for `CreateVolume` or `DeleteVolume` CSI calls, SLRP
will now retry indefinitely with a random exponential backoff.


Diffs
-----

  src/csi/client.hpp 5d40d54c2abbd03993ce8835d37db23e209c7554 
  src/csi/client.cpp 61ed410985099828a2f58b1527ab57daa4b379df 
  src/resource_provider/storage/provider.hpp 331f7b785b14b814c2889488effd53f3a48a1b95 
  src/resource_provider/storage/provider.cpp d6e20a549ede189c757ae3ae922ab7cb86d2be2c 


Diff: https://reviews.apache.org/r/69812/diff/1/


Testing
-------

make check

A unit test will be added later in the chain.


Thanks,

Chun-Hung Hsiao