You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by tz...@apache.org on 2017/06/13 05:17:33 UTC
[14/15] flink git commit: [FLINK-6803] [tests] Fully enable
PojoSerializerUpgradeTests for all state backends
[FLINK-6803] [tests] Fully enable PojoSerializerUpgradeTests for all state backends
With the fixes for the PojoSerializer in, this commit fully enables all
tests for upgrading the PojoSerializer for all state backends, which
otherwise could not pass before.
This closes #4044.
Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/8b26460b
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/8b26460b
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/8b26460b
Branch: refs/heads/master
Commit: 8b26460b72bc4322aea7a9feaa3a728646c0399a
Parents: f0f2e99b
Author: Tzu-Li (Gordon) Tai <tz...@apache.org>
Authored: Sun Jun 4 22:48:45 2017 +0200
Committer: Tzu-Li (Gordon) Tai <tz...@apache.org>
Committed: Tue Jun 13 06:39:17 2017 +0200
----------------------------------------------------------------------
.../typeserializerupgrade/PojoSerializerUpgradeTest.java | 10 ----------
1 file changed, 10 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flink/blob/8b26460b/flink-tests/src/test/java/org/apache/flink/test/typeserializerupgrade/PojoSerializerUpgradeTest.java
----------------------------------------------------------------------
diff --git a/flink-tests/src/test/java/org/apache/flink/test/typeserializerupgrade/PojoSerializerUpgradeTest.java b/flink-tests/src/test/java/org/apache/flink/test/typeserializerupgrade/PojoSerializerUpgradeTest.java
index a925d43..e4dd535 100644
--- a/flink-tests/src/test/java/org/apache/flink/test/typeserializerupgrade/PojoSerializerUpgradeTest.java
+++ b/flink-tests/src/test/java/org/apache/flink/test/typeserializerupgrade/PojoSerializerUpgradeTest.java
@@ -34,7 +34,6 @@ import org.apache.flink.api.common.typeutils.base.LongSerializer;
import org.apache.flink.api.java.functions.KeySelector;
import org.apache.flink.configuration.Configuration;
import org.apache.flink.configuration.CoreOptions;
-import org.apache.flink.contrib.streaming.state.RocksDBStateBackend;
import org.apache.flink.core.testutils.CommonTestUtils;
import org.apache.flink.runtime.operators.testutils.MockEnvironment;
import org.apache.flink.runtime.operators.testutils.MockInputSplitProvider;
@@ -52,7 +51,6 @@ import org.apache.flink.util.DynamicCodeLoadingException;
import org.apache.flink.util.StateMigrationException;
import org.apache.flink.util.TestLogger;
import org.junit.ClassRule;
-import org.junit.Ignore;
import org.junit.Test;
import org.junit.rules.TemporaryFolder;
import org.junit.runner.RunWith;
@@ -74,7 +72,6 @@ import static org.apache.flink.runtime.state.filesystem.FsStateBackendFactory.CH
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
-import static org.junit.Assume.assumeTrue;
@RunWith(Parameterized.class)
public class PojoSerializerUpgradeTest extends TestLogger {
@@ -181,7 +178,6 @@ public class PojoSerializerUpgradeTest extends TestLogger {
/**
* We should be able to handle a changed field order of a POJO as operator state
*/
- @Ignore("Ignore this test until FLINK-6804 has been fixed.")
@Test
public void testChangedFieldOrderWithOperatorState() throws Exception {
testPojoSerializerUpgrade(SOURCE_A, SOURCE_B, true, false);
@@ -192,7 +188,6 @@ public class PojoSerializerUpgradeTest extends TestLogger {
*/
@Test
public void testChangedFieldTypesWithKeyedState() throws Exception {
- assumeTrue("Running only for RocksDBStateBackend until FLINK-6804 has been fixed.", stateBackend instanceof RocksDBStateBackend);
try {
testPojoSerializerUpgrade(SOURCE_A, SOURCE_C, true, true);
fail("Expected a state migration exception.");
@@ -208,7 +203,6 @@ public class PojoSerializerUpgradeTest extends TestLogger {
/**
* Changing field types of a POJO as operator state should require a state migration
*/
- @Ignore("Ignore this test until FLINK-6804 has been fixed.")
@Test
public void testChangedFieldTypesWithOperatorState() throws Exception {
try {
@@ -228,7 +222,6 @@ public class PojoSerializerUpgradeTest extends TestLogger {
*/
@Test
public void testAdditionalFieldWithKeyedState() throws Exception {
- assumeTrue("Running only for RocksDBStateBackend until FLINK-6804 has been fixed.", stateBackend instanceof RocksDBStateBackend);
try {
testPojoSerializerUpgrade(SOURCE_A, SOURCE_D, true, true);
fail("Expected a state migration exception.");
@@ -244,7 +237,6 @@ public class PojoSerializerUpgradeTest extends TestLogger {
/**
* Adding fields to a POJO as operator state should require a state migration
*/
- @Ignore("Ignore this test until FLINK-6804 has been fixed.")
@Test
public void testAdditionalFieldWithOperatorState() throws Exception {
try {
@@ -262,7 +254,6 @@ public class PojoSerializerUpgradeTest extends TestLogger {
/**
* Removing fields from a POJO as keyed state should require a state migration
*/
- @Ignore("Ignore this test until FLINK-6801 has been fixed.")
@Test
public void testMissingFieldWithKeyedState() throws Exception {
try {
@@ -280,7 +271,6 @@ public class PojoSerializerUpgradeTest extends TestLogger {
/**
* Removing fields from a POJO as operator state should require a state migration
*/
- @Ignore("Ignore this test until FLINK-6804 has been fixed.")
@Test
public void testMissingFieldWithOperatorState() throws Exception {
try {