You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/26 12:23:10 UTC
[GitHub] [skywalking] kezhenxu94 opened a new pull request #4574: Add JDK13,
JDK14 to build matrix
kezhenxu94 opened a new pull request #4574: Add JDK13, JDK14 to build matrix
URL: https://github.com/apache/skywalking/pull/4574
Motivation:
Guarantee that the agent supports JDK13 and JDK14
Modifications:
Add JDK13 and JDK14 to build matrix
Result:
Build with JDK13 and JDK14
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4574: [Agent] Add JDK13,
JDK14 to build matrix
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4574: [Agent] Add JDK13, JDK14 to build matrix
URL: https://github.com/apache/skywalking/pull/4574#issuecomment-604412577
Does this make the OAP running on the JDK 13/14 too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on issue #4574: [Agent] Add JDK13,
JDK14 to build matrix
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #4574: [Agent] Add JDK13, JDK14 to build matrix
URL: https://github.com/apache/skywalking/pull/4574#issuecomment-604415029
> Does this make the OAP running on the JDK 13/14 too?
Nope, the OAP is running in the docker built by the `skywalking/docker/oap/Dockerfile.oap`, which is only based on `openjdk:8u181-jdk-stretch`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4574:
[Agent] Add JDK13, JDK14 to build matrix
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4574: [Agent] Add JDK13, JDK14 to build matrix
URL: https://github.com/apache/skywalking/pull/4574#discussion_r398564751
##########
File path: docs/en/setup/service-agent/java-agent/README.md
##########
@@ -1,5 +1,5 @@
# Setup java agent
-1. Agent is available for JDK 8 - 12 in 7.x releases. JDK 1.6 - JDK 12 are supported in all 6.x releases [NOTICE¹](#notice)
+1. Agent is available for JDK 8 - 14 in 7.x releases. JDK 1.6 - JDK 14 are supported in all 6.x releases [NOTICE¹](#notice)
Review comment:
We don't test 6.x for JDK 13/14. We should not indicate those.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4574: [Agent] Add JDK13,
JDK14 to build matrix
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4574: [Agent] Add JDK13, JDK14 to build matrix
URL: https://github.com/apache/skywalking/pull/4574#issuecomment-604422223
BTW, I think you need to update the agent document about this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 merged pull request #4574: [Agent] Add
JDK13, JDK14 to build matrix
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #4574: [Agent] Add JDK13, JDK14 to build matrix
URL: https://github.com/apache/skywalking/pull/4574
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services