[jira] [Commented] (SLING-7985) ProjectHelper#getConfigValue() puts null values to the resulting Set values

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-7985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16639595#comment-16639595 ] 

ASF GitHub Bot commented on SLING-7985:
---------------------------------------

simonetripodi opened a new pull request #2: SLING-7985 - ProjectHelper#getConfigValue() puts null values to the resulting Set<String> values
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/2
 
 
   proposed fix

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> ProjectHelper#getConfigValue() puts null values to the resulting Set<String> values
> -----------------------------------------------------------------------------------
>
>                 Key: SLING-7985
>                 URL: https://issues.apache.org/jira/browse/SLING-7985
>             Project: Sling
>          Issue Type: Bug
>          Components: Feature Model, Maven Plugins and Archetypes
>            Reporter: Simone Tripodi
>            Assignee: David Bosschaert
>            Priority: Major
>
> Looks like {{null}} values can be erroneously added in the {{Set<String>}} values and that are preferred to the default value.
> A safer way is adding more safe guards, i.e.
> {noformat}
>             if ( pluginNode != null
>                     && pluginNode.getValue() != null
>                     && !pluginNode.getValue().isEmpty() ) {
>                 values.add(pluginNode.getValue());
>             }
> {noformat}
> PR is coming



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)