[jira] [Commented] (DATAFU-164) Improve test cases

["Arpit Bhardwaj (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DATAFU-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17612132#comment-17612132 ] 

Arpit Bhardwaj commented on DATAFU-164:
---------------------------------------

Hi [~eyal] 

Let me know if i start working on this.

> Improve test cases
> ------------------
>
>                 Key: DATAFU-164
>                 URL: https://issues.apache.org/jira/browse/DATAFU-164
>             Project: DataFu
>          Issue Type: Test
>            Reporter: Eyal Allweil
>            Priority: Major
>              Labels: good-first-issue, newbie, up-for-grabs
>
> We can get better code coverage and cover edge cases that are currently missing in our main tests file, [TestSparkDFUtils|https://github.com/apache/datafu/blob/master/datafu-spark/src/test/scala/datafu/spark/TestSparkDFUtils.scala].
>  
> For example, another test for [joinWithRange|https://github.com/apache/datafu/blob/master/datafu-spark/src/main/scala/datafu/spark/SparkDFUtils.scala#L419] that includes the case that a record falls into {{{}decreased_range_single{}}}, but {{range_start}} and {{range_end}} do not contain {{single.}}
> Another case for the [flatten|https://github.com/apache/datafu/blob/master/datafu-spark/src/main/scala/datafu/spark/SparkDFUtils.scala#L256] API could also be good.
> Or for [dedupRandomN|https://github.com/apache/datafu/blob/master/datafu-spark/src/main/scala/datafu/spark/SparkDFUtils.scala#L567]. Or for anything else, for that matter.
>  
> It's perfectly alright to only do one of them - either as a patch or GitHub PR.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)