[GitHub] chetanmeh commented on a change in pull request #4212: Optimize Kamon metric update flow

[GitBox <gi...@apache.org>]

chetanmeh commented on a change in pull request #4212: Optimize Kamon metric update flow
URL: https://github.com/apache/incubator-openwhisk/pull/4212#discussion_r246640299
 
 

 ##########
 File path: common/scala/src/main/scala/org/apache/openwhisk/common/Logging.scala
 ##########
 @@ -184,13 +185,71 @@ case class LogMarkerToken(component: String,
                           state: String,
                           subAction: Option[String] = None,
                           tags: Map[String, String] = Map.empty) {
+  private var finishToken: LogMarkerToken = _
+  private var errorToken: LogMarkerToken = _
+  private var _counter: KCounter = _
+  private var _histogram: KHistogram = _
 
 Review comment:
   It would be safe to use `var` here as the variables would get initialized to "same" values. Kamon would ensure that metric instance for given name and tag are always same

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services