You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/10/27 07:53:22 UTC
[GitHub] [shardingsphere] terrymanu commented on a change in pull request #7929: Update committer.en.md
terrymanu commented on a change in pull request #7929:
URL: https://github.com/apache/shardingsphere/pull/7929#discussion_r512475877
##########
File path: docs/community/content/contribute/committer.en.md
##########
@@ -25,25 +25,19 @@ After a contributor participate ShardingSphere community actively, PMC and Commi
1. Weekly rotating committers needs to check the list of Pull Requests and issues to be processed in the community on a daily basis.
- - Including(mark issue lable, reply issue, close issue).
- - Assign issue to the appropriate committer, namely assignee.
+ - Including label issue, reply issue, close issue;
+ - Assign issue to the appropriate committer, namely assignee;
- The rotation period is one week.
->Committer rota will update in the group chat, this position is aims to bring out the sense of community ownership and greater the sense of belonging, the Apache ShardingSphere is belongs to every PMC/Committer!
-
2. After a committer is assigned with an issue, the following work is required:
- - Estimate whether it is a long-term issue. If it is, please mark it as pending.
- - Add issue labels, such as bug, enhancement, discussion, etc.
- - Add Milestone labels.
+ - Estimate whether it is a long-term issue. If it is, please mark it as pending;
Review comment:
It is better to change for `please label it as pending`
##########
File path: docs/community/content/contribute/committer.en.md
##########
@@ -25,25 +25,19 @@ After a contributor participate ShardingSphere community actively, PMC and Commi
1. Weekly rotating committers needs to check the list of Pull Requests and issues to be processed in the community on a daily basis.
- - Including(mark issue lable, reply issue, close issue).
- - Assign issue to the appropriate committer, namely assignee.
+ - Including label issue, reply issue, close issue;
+ - Assign issue to the appropriate committer, namely assignee;
- The rotation period is one week.
->Committer rota will update in the group chat, this position is aims to bring out the sense of community ownership and greater the sense of belonging, the Apache ShardingSphere is belongs to every PMC/Committer!
-
2. After a committer is assigned with an issue, the following work is required:
- - Estimate whether it is a long-term issue. If it is, please mark it as pending.
- - Add issue labels, such as bug, enhancement, discussion, etc.
- - Add Milestone labels.
+ - Estimate whether it is a long-term issue. If it is, please mark it as pending;
+ - Add issue labels, such as bug, enhancement, discussion, etc;
+ - Add Milestone.
Review comment:
milestone should be lower case
##########
File path: docs/community/content/contribute/committer.en.md
##########
@@ -25,25 +25,19 @@ After a contributor participate ShardingSphere community actively, PMC and Commi
1. Weekly rotating committers needs to check the list of Pull Requests and issues to be processed in the community on a daily basis.
- - Including(mark issue lable, reply issue, close issue).
- - Assign issue to the appropriate committer, namely assignee.
+ - Including label issue, reply issue, close issue;
+ - Assign issue to the appropriate committer, namely assignee;
- The rotation period is one week.
->Committer rota will update in the group chat, this position is aims to bring out the sense of community ownership and greater the sense of belonging, the Apache ShardingSphere is belongs to every PMC/Committer!
-
2. After a committer is assigned with an issue, the following work is required:
- - Estimate whether it is a long-term issue. If it is, please mark it as pending.
- - Add issue labels, such as bug, enhancement, discussion, etc.
- - Add Milestone labels.
+ - Estimate whether it is a long-term issue. If it is, please mark it as pending;
+ - Add issue labels, such as bug, enhancement, discussion, etc;
+ - Add Milestone.
3. Pull Request that committer submits needs to mark labels and milestone based on the type and time.
Review comment:
Pull Request that committer submits needs to mark labels and milestone based on the type and `release period`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org