[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10802: [multistage][bugfix] fix execution exception not propagate through issue on mailbox

["Jackie-Jiang (via GitHub)" <gi...@apache.org>]

Jackie-Jiang commented on code in PR #10802:
URL: https://github.com/apache/pinot/pull/10802#discussion_r1204874480


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/exchange/BlockExchange.java:
##########
@@ -137,6 +147,19 @@ protected void sendBlock(SendingMailbox sendingMailbox, TransferableBlock block)
     }
   }
 
+  private void setErrorBlock(TransferableBlock errorBlock) {
+    if (_errorBlock.compareAndSet(null, errorBlock)) {
+      try {
+        for (SendingMailbox sendingMailbox : _sendingMailboxes) {

Review Comment:
   Should we call `_callback.accept()` here?



##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/exchange/BlockExchange.java:
##########
@@ -100,6 +104,10 @@ public TransferableBlock send() {
     try {
       TransferableBlock block;
       long timeoutMs = _deadlineMs - System.currentTimeMillis();
+      if (_errorBlock.get() != null) {

Review Comment:
   Do we need to cache the error block? Once error block is returned, there should be no more `send()`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org