You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/24 16:36:25 UTC

[GitHub] [superset] geido opened a new pull request #13778: test: Tests and dedicated dir for Explore TextControl component

geido opened a new pull request #13778:
URL: https://github.com/apache/superset/pull/13778


   ### SUMMARY
   Move the TextControl component to a dedicated directory and adds the tests
   
   ### TEST PLAN
   All tests should pass


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13778: test: Tests and dedicated dir for Explore TextControl component

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13778:
URL: https://github.com/apache/superset/pull/13778#issuecomment-806046910


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13778?src=pr&el=h1) Report
   > Merging [#13778](https://codecov.io/gh/apache/superset/pull/13778?src=pr&el=desc) (a68d6cf) into [master](https://codecov.io/gh/apache/superset/commit/5b79f84e1ba2feab10bc9b96fd786d82418b7b4a?el=desc) (5b79f84) will **decrease** coverage by `0.32%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13778/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13778?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13778      +/-   ##
   ==========================================
   - Coverage   77.45%   77.13%   -0.33%     
   ==========================================
     Files         933      935       +2     
     Lines       47144    47472     +328     
     Branches     5848     5949     +101     
   ==========================================
   + Hits        36516    36617     +101     
   - Misses      10485    10707     +222     
   - Partials      143      148       +5     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.25% <ø> (-0.09%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13778?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [.../explore/components/controls/TextControl/index.tsx](https://codecov.io/gh/apache/superset/pull/13778/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC9pbmRleC50c3g=) | `72.22% <ø> (ø)` | |
   | [superset-frontend/src/middleware/asyncEvent.ts](https://codecov.io/gh/apache/superset/pull/13778/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21pZGRsZXdhcmUvYXN5bmNFdmVudC50cw==) | `53.54% <0.00%> (-33.80%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/superset/pull/13778/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `37.50% <0.00%> (-26.14%)` | :arrow_down: |
   | [...nd/src/explore/components/controls/TextControl.tsx](https://codecov.io/gh/apache/superset/pull/13778/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC50c3g=) | `48.83% <0.00%> (-25.59%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/13778/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `40.00% <0.00%> (-23.64%)` | :arrow_down: |
   | [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/superset/pull/13778/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `40.47% <0.00%> (-21.55%)` | :arrow_down: |
   | [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13778/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `48.59% <0.00%> (-15.79%)` | :arrow_down: |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13778/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `68.75% <0.00%> (-9.25%)` | :arrow_down: |
   | [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13778/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `90.90% <0.00%> (ø)` | |
   | ... and [2 more](https://codecov.io/gh/apache/superset/pull/13778/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13778?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13778?src=pr&el=footer). Last update [5b79f84...a68d6cf](https://codecov.io/gh/apache/superset/pull/13778?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc commented on pull request #13778: test: Tests and dedicated dir for Explore TextControl component

Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #13778:
URL: https://github.com/apache/superset/pull/13778#issuecomment-808668863


   @rusackas ready to merge? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] rusackas merged pull request #13778: test: Tests and dedicated dir for Explore TextControl component

Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #13778:
URL: https://github.com/apache/superset/pull/13778


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13778: test: Tests and dedicated dir for Explore TextControl component

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13778:
URL: https://github.com/apache/superset/pull/13778#issuecomment-806046910


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13778?src=pr&el=h1) Report
   > Merging [#13778](https://codecov.io/gh/apache/superset/pull/13778?src=pr&el=desc) (5779fa2) into [master](https://codecov.io/gh/apache/superset/commit/5b79f84e1ba2feab10bc9b96fd786d82418b7b4a?el=desc) (5b79f84) will **increase** coverage by `0.03%`.
   > The diff coverage is `77.69%`.
   
   > :exclamation: Current head 5779fa2 differs from pull request most recent head a68d6cf. Consider uploading reports for the commit a68d6cf to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13778/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13778?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13778      +/-   ##
   ==========================================
   + Coverage   77.45%   77.48%   +0.03%     
   ==========================================
     Files         933      933              
     Lines       47144    47188      +44     
     Branches     5848     5863      +15     
   ==========================================
   + Hits        36516    36565      +49     
   + Misses      10485    10481       -4     
   + Partials      143      142       -1     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `63.60% <76.25%> (+0.13%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13778?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13778/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `66.19% <ø> (+1.81%)` | :arrow_up: |
   | [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/superset/pull/13778/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `96.42% <ø> (ø)` | |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/13778/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `100.00% <ø> (+36.36%)` | :arrow_up: |
   | [...tasourcePanel/DatasourcePanelDragWrapper/index.tsx](https://codecov.io/gh/apache/superset/pull/13778/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwvRGF0YXNvdXJjZVBhbmVsRHJhZ1dyYXBwZXIvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [.../explore/components/controls/TextControl/index.tsx](https://codecov.io/gh/apache/superset/pull/13778/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC9pbmRleC50c3g=) | `88.37% <ø> (ø)` | |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/superset/pull/13778/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `100.00% <ø> (+36.36%)` | :arrow_up: |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13778/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `78.60% <60.00%> (+0.60%)` | :arrow_up: |
   | [superset-frontend/src/middleware/asyncEvent.ts](https://codecov.io/gh/apache/superset/pull/13778/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21pZGRsZXdhcmUvYXN5bmNFdmVudC50cw==) | `78.03% <77.69%> (-9.32%)` | :arrow_down: |
   | [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/superset/pull/13778/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `62.96% <100.00%> (+0.93%)` | :arrow_up: |
   | [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13778/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `90.90% <0.00%> (ø)` | |
   | ... and [3 more](https://codecov.io/gh/apache/superset/pull/13778/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13778?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13778?src=pr&el=footer). Last update [5b79f84...a68d6cf](https://codecov.io/gh/apache/superset/pull/13778?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] commented on pull request #13778: test: Tests and dedicated dir for Explore TextControl component

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13778:
URL: https://github.com/apache/superset/pull/13778#issuecomment-806046910


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13778?src=pr&el=h1) Report
   > Merging [#13778](https://codecov.io/gh/apache/superset/pull/13778?src=pr&el=desc) (a68d6cf) into [master](https://codecov.io/gh/apache/superset/commit/5b79f84e1ba2feab10bc9b96fd786d82418b7b4a?el=desc) (5b79f84) will **decrease** coverage by `1.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13778/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13778?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13778      +/-   ##
   ==========================================
   - Coverage   77.45%   76.44%   -1.01%     
   ==========================================
     Files         933      935       +2     
     Lines       47144    47472     +328     
     Branches     5848     5949     +101     
   ==========================================
   - Hits        36516    36291     -225     
   - Misses      10485    11016     +531     
   - Partials      143      165      +22     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `53.20% <ø> (-3.15%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13778?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [.../explore/components/controls/TextControl/index.tsx](https://codecov.io/gh/apache/superset/pull/13778/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC9pbmRleC50c3g=) | `41.66% <ø> (ø)` | |
   | [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/13778/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/13778/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...c/dashboard/components/dnd/AddSliceDragPreview.jsx](https://codecov.io/gh/apache/superset/pull/13778/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9BZGRTbGljZURyYWdQcmV2aWV3LmpzeA==) | `35.71% <0.00%> (-64.29%)` | :arrow_down: |
   | [...et-frontend/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/superset/pull/13778/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL3NsaWNlRW50aXRpZXMuanM=) | `12.90% <0.00%> (-58.07%)` | :arrow_down: |
   | [...frontend/src/dashboard/components/AddSliceCard.jsx](https://codecov.io/gh/apache/superset/pull/13778/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0FkZFNsaWNlQ2FyZC5qc3g=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/superset/pull/13778/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXIuanN4) | `2.38% <0.00%> (-49.53%)` | :arrow_down: |
   | [...set-frontend/src/dashboard/reducers/datasources.js](https://codecov.io/gh/apache/superset/pull/13778/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXRhc291cmNlcy5qcw==) | `57.14% <0.00%> (-42.86%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/actions/datasources.js](https://codecov.io/gh/apache/superset/pull/13778/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2RhdGFzb3VyY2VzLmpz) | `15.78% <0.00%> (-42.11%)` | :arrow_down: |
   | [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/superset/pull/13778/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `42.85% <0.00%> (-40.00%)` | :arrow_down: |
   | ... and [34 more](https://codecov.io/gh/apache/superset/pull/13778/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13778?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13778?src=pr&el=footer). Last update [5b79f84...a68d6cf](https://codecov.io/gh/apache/superset/pull/13778?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] geido commented on pull request #13778: test: Tests and dedicated dir for Explore TextControl component

Posted by GitBox <gi...@apache.org>.
geido commented on pull request #13778:
URL: https://github.com/apache/superset/pull/13778#issuecomment-805977497


   @junlincc @rusackas 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org