You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Geir Ove Grønmo (JIRA)" <ji...@apache.org> on 2010/02/04 08:52:28 UTC

[jira] Created: (OFBIZ-3440) Calculation of promotions and price rules should support multi-level GROUP_ROLLUP

Calculation of promotions and price rules should support multi-level GROUP_ROLLUP
---------------------------------------------------------------------------------

                 Key: OFBIZ-3440
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3440
             Project: OFBiz
          Issue Type: Improvement
          Components: order, product
    Affects Versions: SVN trunk
            Reporter: Geir Ove Grønmo
            Priority: Minor


The calculation of product prices given promotion and price rules do not currently take multi-level GROUP_ROLLUP party relations into account. 

The calculation of price rules consider two levels of GROUP_ROLLUP only, while the calculation of promotions take just a single level of GROUP_ROLLUP into account.

The attached patch will calculate price rules and promotions for GROUP_ROLLUPs for an arbitrary number of GROUP_ROLLUPs. This is essential in the situation where there are hierarchies of parties.




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (OFBIZ-3440) Calculation of promotions and price rules should support multi-level GROUP_ROLLUP

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-3440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-3440.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk

Hi Geir,

Your (slightly modified) patch is in trunk at r922177  

Small details : please take care of formatting (in PriceServices.java for instance) and genericity. For instance List<GenericValue> partyRelationshipList ProductPromoWorker.java. I know it was already like that in previous code, but if we get an opportunity to fix, why not?

Anyway, good job, thanks!

> Calculation of promotions and price rules should support multi-level GROUP_ROLLUP
> ---------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3440
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3440
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order, product
>    Affects Versions: SVN trunk
>            Reporter: Geir Ove Grønmo
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3440.patch
>
>
> The calculation of product prices given promotion and price rules do not currently take multi-level GROUP_ROLLUP party relations into account. 
> The calculation of price rules consider two levels of GROUP_ROLLUP only, while the calculation of promotions take just a single level of GROUP_ROLLUP into account.
> The attached patch will calculate price rules and promotions for GROUP_ROLLUPs for an arbitrary number of GROUP_ROLLUPs. This is essential in the situation where there are hierarchies of parties.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (OFBIZ-3440) Calculation of promotions and price rules should support multi-level GROUP_ROLLUP

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-3440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-3440:
--------------------------------------

    Assignee: Jacques Le Roux

> Calculation of promotions and price rules should support multi-level GROUP_ROLLUP
> ---------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3440
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3440
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order, product
>    Affects Versions: SVN trunk
>            Reporter: Geir Ove Grønmo
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: OFBIZ-3440.patch
>
>
> The calculation of product prices given promotion and price rules do not currently take multi-level GROUP_ROLLUP party relations into account. 
> The calculation of price rules consider two levels of GROUP_ROLLUP only, while the calculation of promotions take just a single level of GROUP_ROLLUP into account.
> The attached patch will calculate price rules and promotions for GROUP_ROLLUPs for an arbitrary number of GROUP_ROLLUPs. This is essential in the situation where there are hierarchies of parties.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-3440) Calculation of promotions and price rules should support multi-level GROUP_ROLLUP

Posted by "Geir Ove Grønmo (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-3440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Geir Ove Grønmo updated OFBIZ-3440:
-----------------------------------

    Attachment: OFBIZ-3440.patch

This patch was created from trunk at revision 906373.

> Calculation of promotions and price rules should support multi-level GROUP_ROLLUP
> ---------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3440
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3440
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order, product
>    Affects Versions: SVN trunk
>            Reporter: Geir Ove Grønmo
>            Priority: Minor
>         Attachments: OFBIZ-3440.patch
>
>
> The calculation of product prices given promotion and price rules do not currently take multi-level GROUP_ROLLUP party relations into account. 
> The calculation of price rules consider two levels of GROUP_ROLLUP only, while the calculation of promotions take just a single level of GROUP_ROLLUP into account.
> The attached patch will calculate price rules and promotions for GROUP_ROLLUPs for an arbitrary number of GROUP_ROLLUPs. This is essential in the situation where there are hierarchies of parties.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.