[GitHub] [incubator-uniffle] smallzhongfeng commented on a diff in pull request #104: [Improvement] Use ConfigBuilder to rewrite the class RssSparkConfig

[GitBox <gi...@apache.org>]

smallzhongfeng commented on code in PR #104:
URL: https://github.com/apache/incubator-uniffle/pull/104#discussion_r933071831


##########
client-spark/common/src/main/java/org/apache/spark/shuffle/RssSparkConfig.java:
##########
@@ -17,130 +17,277 @@
 
 package org.apache.spark.shuffle;
 
-import java.util.Set;
-
 import com.google.common.collect.Sets;
+import org.apache.spark.internal.config.ConfigBuilder;
+import org.apache.spark.internal.config.ConfigEntry;
 
-import org.apache.uniffle.client.util.RssClientConfig;
+import java.util.Set;
 
 public class RssSparkConfig {
 
+  public static final class SparkConfigBuilder {

Review Comment:
   The reason why I encapsulate it here is to support type conversion. If configbuilder or configintry is used, there will be problems during type conversion.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org