You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2019/02/13 09:45:37 UTC
[GitHub] codecov-io commented on issue #533: SCB-1092 Output event
processing time
codecov-io commented on issue #533: SCB-1092 Output event processing time
URL: https://github.com/apache/servicecomb-service-center/pull/533#issuecomment-463130525
# [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/533?src=pr&el=h1) Report
> Merging [#533](https://codecov.io/gh/apache/servicecomb-service-center/pull/533?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/c3520074fd05cbc683d5923c50725bb10b28d36a?src=pr&el=desc) will **decrease** coverage by `0.58%`.
> The diff coverage is `58.9%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-service-center/pull/533/graphs/tree.svg?width=650&token=GAaF7zrg8R&height=150&src=pr)](https://codecov.io/gh/apache/servicecomb-service-center/pull/533?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #533 +/- ##
==========================================
- Coverage 59.42% 58.84% -0.59%
==========================================
Files 176 181 +5
Lines 14352 14569 +217
==========================================
+ Hits 8529 8573 +44
- Misses 5231 5404 +173
Partials 592 592
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/533?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [server/service/event/rule\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/533/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvcnVsZV9ldmVudF9oYW5kbGVyLmdv) | `8.16% <0%> (-0.18%)` | :arrow_down: |
| [server/plugin/pkg/discovery/metrics.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/533/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L21ldHJpY3MuZ28=) | `16.66% <0%> (-3.34%)` | :arrow_down: |
| [server/service/event/instance\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/533/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvaW5zdGFuY2VfZXZlbnRfaGFuZGxlci5nbw==) | `7.27% <0%> (+0.12%)` | :arrow_up: |
| [server/service/event/tag\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/533/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvdGFnX2V2ZW50X2hhbmRsZXIuZ28=) | `7.01% <0%> (-0.13%)` | :arrow_down: |
| [server/plugin/pkg/discovery/etcd/cacher\_kv.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/533/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvY2FjaGVyX2t2Lmdv) | `66.42% <100%> (-1.17%)` | :arrow_down: |
| [server/notify/websocket.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/533/diff?src=pr&el=tree#diff-c2VydmVyL25vdGlmeS93ZWJzb2NrZXQuZ28=) | `82.24% <100%> (ø)` | :arrow_up: |
| [server/plugin/pkg/discovery/types.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/533/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3R5cGVzLmdv) | `100% <100%> (ø)` | :arrow_up: |
| [server/plugin/pkg/discovery/cacher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/533/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2NhY2hlci5nbw==) | `100% <100%> (ø)` | :arrow_up: |
| [pkg/client/sc/client\_lb.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/533/diff?src=pr&el=tree#diff-cGtnL2NsaWVudC9zYy9jbGllbnRfbGIuZ28=) | `91.3% <100%> (ø)` | |
| [server/notify/listwatcher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/533/diff?src=pr&el=tree#diff-c2VydmVyL25vdGlmeS9saXN0d2F0Y2hlci5nbw==) | `79.16% <100%> (+1.55%)` | :arrow_up: |
| ... and [18 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/533/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/533?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/533?src=pr&el=footer). Last update [c352007...23483ac](https://codecov.io/gh/apache/servicecomb-service-center/pull/533?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services