You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2023/01/13 17:23:52 UTC
[GitHub] [netbeans-tools] matthiasblaesing commented on a diff in pull request #61: More appropriate template for notifications about new NetBeans version
matthiasblaesing commented on code in PR #61:
URL: https://github.com/apache/netbeans-tools/pull/61#discussion_r1069731478
##########
pp3/module/Application/src/Application/Controller/AdminController.php:
##########
@@ -350,32 +350,37 @@ public function emailSendingAction() {
$onlyVerified = false;
$nbVersionId = [];
- $subject = '[NetBeans PluginPortal] <SUBJECT>';
+ $subject = '[NetBeans PluginPortal] Check your plugin with the new Apache NetBeans %4$s version!';
$emailText = '
<html>
<head><title></title></head>
<body>
-<p>Dear %1$s,</p>
+<p>Hey %1$s,</p>
-<p>we have some news for you.</p>
-
-<p><Your message></p>
+<p>
+have you heard of the new Apache NetBeans version on the horizon?
+Yes, the NetBeans community is going to release version %4$s soon!
+In order to have your great plugin(s) available on the NetBeans Update
+Center also for users of the new version please consider testing the
+plugin(s) with the latest RC build and possibly submit new verification
+request(s) via the Plugin Portal website.
+</p>
<p>
Your plugins:<br />
%3$s
</p>
-<p>Direct link to the plugin portal:<br />
-<a href="%2$s">%2$s</a>
+<p>Direct link to the list of your plugins:<br />
+<a href="%2$s/plugin/list">%2$s/plugin/list</a>
Review Comment:
This will fail in most cases. The URL `/plugin/list` will redirect you to the front page because you are not logged in. This might confuse users reading the sentence directly before the link.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists