[GitHub] [hbase] virajjasani commented on a change in pull request #2330: HBASE-24964 Remove MetaTableAccessor.tableExists

[GitBox <gi...@apache.org>]

virajjasani commented on a change in pull request #2330:
URL: https://github.com/apache/hbase/pull/2330#discussion_r479731274



##########
File path: hbase-balancer/src/main/java/org/apache/hadoop/hbase/MetaTableAccessor.java
##########
@@ -354,20 +354,6 @@ private static boolean isMergeQualifierPrefix(Cell cell) {
       PrivateCellUtil.qualifierStartsWith(cell, HConstants.MERGE_QUALIFIER_PREFIX);
   }
 
-  /**
-   * Checks if the specified table exists. Looks at the hbase:meta table hosted on the specified
-   * server.
-   * @param connection connection we're using
-   * @param tableName table to check
-   * @return true if the table exists in meta, false if not
-   */
-  public static boolean tableExists(Connection connection, final TableName tableName)
-    throws IOException {
-    // Catalog tables always exist.
-    return tableName.equals(TableName.META_TABLE_NAME) ||
-      getTableState(connection, tableName) != null;
-  }
-
   /**
    * Lists all of the regions currently in META.
    * @param connection to connect with

Review comment:
       `get(TableName tableName)` is a good candidate for returning `Optional<TableDescriptor>`, but anyways nothing related to this change.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org