You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Gabrielle Crawford (JIRA)" <de...@myfaces.apache.org> on 2009/06/30 23:48:48 UTC
[jira] Created: (TRINIDAD-1522) improve compareTo check in
uixeditablevalueholder
improve compareTo check in uixeditablevalueholder
-------------------------------------------------
Key: TRINIDAD-1522
URL: https://issues.apache.org/jira/browse/TRINIDAD-1522
Project: MyFaces Trinidad
Issue Type: Bug
Reporter: Gabrielle Crawford
Due to the fix for TRINIDAD-1489 we're now using compareTo in UIXEditableValue.
However we should avoid unnecessary calls to compareTo. According to "Effective Java" by Josh Bloch "While the contract doesn't preclude interclass comparisons, there are, as of release 1.6, no classes in the Java platform libraries that support them". He also states this is the proper behavior. I'm reading Item 12 in the second edition of the book.
Therefore we should make the compareTo check more strict, so we only compare when the class is the same.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TRINIDAD-1522) improve compareTo check in
uixeditablevalueholder
Posted by "Gabrielle Crawford (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gabrielle Crawford resolved TRINIDAD-1522.
------------------------------------------
Resolution: Fixed
Fix Version/s: 1.2.12-core
> improve compareTo check in uixeditablevalueholder
> -------------------------------------------------
>
> Key: TRINIDAD-1522
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1522
> Project: MyFaces Trinidad
> Issue Type: Bug
> Reporter: Gabrielle Crawford
> Fix For: 1.2.12-core
>
>
> Due to the fix for TRINIDAD-1489 we're now using compareTo in UIXEditableValue.
> However we should avoid unnecessary calls to compareTo. According to "Effective Java" by Josh Bloch "While the contract doesn't preclude interclass comparisons, there are, as of release 1.6, no classes in the Java platform libraries that support them". He also states this is the proper behavior. I'm reading Item 12 in the second edition of the book.
> Therefore we should make the compareTo check more strict, so we only compare when the class is the same.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.