You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "Master-sudo-doct (via GitHub)" <gi...@apache.org> on 2023/06/18 12:22:16 UTC

[GitHub] [shardingsphere] Master-sudo-doct opened a new pull request, #26416: Fixes #26162 .

Master-sudo-doct opened a new pull request, #26416:
URL: https://github.com/apache/shardingsphere/pull/26416

   Fixes #26162 .
   
   Changes proposed in this pull request:
     -
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [ ] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Master-sudo-doct closed pull request #26416: Fixes #26162 .

Posted by "Master-sudo-doct (via GitHub)" <gi...@apache.org>.
Master-sudo-doct closed pull request #26416: Fixes #26162 .
URL: https://github.com/apache/shardingsphere/pull/26416


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tuichenchuxin commented on a diff in pull request #26416: Fixes #26162 .

Posted by "tuichenchuxin (via GitHub)" <gi...@apache.org>.
tuichenchuxin commented on code in PR #26416:
URL: https://github.com/apache/shardingsphere/pull/26416#discussion_r1234883770


##########
infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/database/schema/builder/SystemSchemaBuilderRule.java:
##########
@@ -131,7 +132,7 @@ public enum SystemSchemaBuilderRule {
      * Value of builder rule.
      *
      * @param databaseType database type
-     * @param schema schema
+     * @param schema       schema

Review Comment:
   This appears to be an inadvertent modification



##########
infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/database/schema/builder/SystemSchemaBuilderRule.java:
##########
@@ -144,7 +145,7 @@ public static SystemSchemaBuilderRule valueOf(final String databaseType, final S
     /**
      * Judge whether current table is system table or not.
      *
-     * @param schema schema
+     * @param schema    schema

Review Comment:
   This appears to be an inadvertent modification



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tuichenchuxin commented on a diff in pull request #26416: Fixes #26162 .

Posted by "tuichenchuxin (via GitHub)" <gi...@apache.org>.
tuichenchuxin commented on code in PR #26416:
URL: https://github.com/apache/shardingsphere/pull/26416#discussion_r1234900762


##########
infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/database/schema/builder/SystemSchemaBuilderRule.java:
##########
@@ -144,7 +145,7 @@ public static SystemSchemaBuilderRule valueOf(final String databaseType, final S
     /**
      * Judge whether current table is system table or not.
      *
-     * @param schema schema
+     * @param schema    schema

Review Comment:
   Just modify it directly on the branch you submitted



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tuichenchuxin merged pull request #26416: Fixes #26162 .

Posted by "tuichenchuxin (via GitHub)" <gi...@apache.org>.
tuichenchuxin merged PR #26416:
URL: https://github.com/apache/shardingsphere/pull/26416


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Master-sudo-doct commented on a diff in pull request #26416: Fixes #26162 .

Posted by "Master-sudo-doct (via GitHub)" <gi...@apache.org>.
Master-sudo-doct commented on code in PR #26416:
URL: https://github.com/apache/shardingsphere/pull/26416#discussion_r1234909409


##########
infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/database/schema/builder/SystemSchemaBuilderRule.java:
##########
@@ -144,7 +145,7 @@ public static SystemSchemaBuilderRule valueOf(final String databaseType, final S
     /**
      * Judge whether current table is system table or not.
      *
-     * @param schema schema
+     * @param schema    schema

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Master-sudo-doct commented on a diff in pull request #26416: Fixes #26162 .

Posted by "Master-sudo-doct (via GitHub)" <gi...@apache.org>.
Master-sudo-doct commented on code in PR #26416:
URL: https://github.com/apache/shardingsphere/pull/26416#discussion_r1234899066


##########
infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/database/schema/builder/SystemSchemaBuilderRule.java:
##########
@@ -144,7 +145,7 @@ public static SystemSchemaBuilderRule valueOf(final String databaseType, final S
     /**
      * Judge whether current table is system table or not.
      *
-     * @param schema schema
+     * @param schema    schema

Review Comment:
   It seems like so, should I make a new commit to rectify it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org