You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/09 11:11:36 UTC
[GitHub] [shardingsphere] FlyingZC opened a new pull request, #22772: Add xa resource exceeds length check(#22768)
FlyingZC opened a new pull request, #22772:
URL: https://github.com/apache/shardingsphere/pull/22772
Fixes #22768.
Changes proposed in this pull request:
- Add xa resource exceeds length check
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [x] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [x] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #22772: Add xa resource exceeds length check(#22768)
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #22772:
URL: https://github.com/apache/shardingsphere/pull/22772#issuecomment-1345490632
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/22772?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22772](https://codecov.io/gh/apache/shardingsphere/pull/22772?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (be8a772) into [master](https://codecov.io/gh/apache/shardingsphere/commit/7e7e3eb3ad00ebe069a8826758c2dd332e593327?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7e7e3eb) will **increase** coverage by `0.00%`.
> The diff coverage is `40.00%`.
```diff
@@ Coverage Diff @@
## master #22772 +/- ##
=========================================
Coverage 49.31% 49.31%
- Complexity 2445 2447 +2
=========================================
Files 4121 4126 +5
Lines 57678 57731 +53
Branches 9879 9890 +11
=========================================
+ Hits 28442 28472 +30
- Misses 26787 26806 +19
- Partials 2449 2453 +4
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/22772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ception/XAResourceNameLengthExceededException.java](https://codecov.io/gh/apache/shardingsphere/pull/22772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL3RyYW5zYWN0aW9uL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3RyYW5zYWN0aW9uL2V4Y2VwdGlvbi9YQVJlc291cmNlTmFtZUxlbmd0aEV4Y2VlZGVkRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ingsphere/transaction/core/ResourceDataSource.java](https://codecov.io/gh/apache/shardingsphere/pull/22772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL3RyYW5zYWN0aW9uL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3RyYW5zYWN0aW9uL2NvcmUvUmVzb3VyY2VEYXRhU291cmNlLmphdmE=) | `87.50% <50.00%> (-12.50%)` | :arrow_down: |
| [...ngsphere/transaction/core/ResourceIDGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/22772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL3RyYW5zYWN0aW9uL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3RyYW5zYWN0aW9uL2NvcmUvUmVzb3VyY2VJREdlbmVyYXRvci5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...e/execute/ShardingSphereDataScheduleCollector.java](https://codecov.io/gh/apache/shardingsphere/pull/22772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL2V4ZWN1dGUvU2hhcmRpbmdTcGhlcmVEYXRhU2NoZWR1bGVDb2xsZWN0b3IuamF2YQ==) | `68.75% <0.00%> (-4.69%)` | :arrow_down: |
| [...eger/definition/JaegerPluginDefinitionService.java](https://codecov.io/gh/apache/shardingsphere/pull/22772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy90cmFjaW5nL2phZWdlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvcGx1Z2luL3RyYWNpbmcvamFlZ2VyL2RlZmluaXRpb24vSmFlZ2VyUGx1Z2luRGVmaW5pdGlvblNlcnZpY2UuamF2YQ==) | `87.50% <0.00%> (-1.39%)` | :arrow_down: |
| [...pkin/definition/ZipkinPluginDefinitionService.java](https://codecov.io/gh/apache/shardingsphere/pull/22772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy90cmFjaW5nL3ppcGtpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvcGx1Z2luL3RyYWNpbmcvemlwa2luL2RlZmluaXRpb24vWmlwa2luUGx1Z2luRGVmaW5pdGlvblNlcnZpY2UuamF2YQ==) | `87.50% <0.00%> (-1.39%)` | :arrow_down: |
| [...definition/OpenTracingPluginDefinitionService.java](https://codecov.io/gh/apache/shardingsphere/pull/22772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy90cmFjaW5nL29wZW50cmFjaW5nL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hZ2VudC9wbHVnaW4vdHJhY2luZy9vcGVudHJhY2luZy9kZWZpbml0aW9uL09wZW5UcmFjaW5nUGx1Z2luRGVmaW5pdGlvblNlcnZpY2UuamF2YQ==) | `87.50% <0.00%> (-1.39%)` | :arrow_down: |
| [...n/OpenTelemetryTracingPluginDefinitionService.java](https://codecov.io/gh/apache/shardingsphere/pull/22772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy90cmFjaW5nL29wZW50ZWxlbWV0cnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2FnZW50L3BsdWdpbi90cmFjaW5nL29wZW50ZWxlbWV0cnkvZGVmaW5pdGlvbi9PcGVuVGVsZW1ldHJ5VHJhY2luZ1BsdWdpbkRlZmluaXRpb25TZXJ2aWNlLmphdmE=) | `87.50% <0.00%> (-1.39%)` | :arrow_down: |
| [.../mode/metadata/persist/MetaDataPersistService.java](https://codecov.io/gh/apache/shardingsphere/pull/22772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21ldGFkYXRhL3BlcnNpc3QvTWV0YURhdGFQZXJzaXN0U2VydmljZS5qYXZh) | `65.11% <0.00%> (-0.80%)` | :arrow_down: |
| [...ingsphere/agent/core/plugin/AgentPluginLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/22772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9wbHVnaW4vQWdlbnRQbHVnaW5Mb2FkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| ... and [136 more](https://codecov.io/gh/apache/shardingsphere/pull/22772/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tuichenchuxin merged pull request #22772: Add xa resource exceeds length check(#22768)
Posted by GitBox <gi...@apache.org>.
tuichenchuxin merged PR #22772:
URL: https://github.com/apache/shardingsphere/pull/22772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org