You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/10 15:07:42 UTC

[GitHub] [superset] srinify commented on a change in pull request #12238: Update index.mdx

srinify commented on a change in pull request #12238:
URL: https://github.com/apache/superset/pull/12238#discussion_r554580399



##########
File path: docs/src/pages/docs/Connecting to Databases/index.mdx
##########
@@ -29,7 +29,7 @@ A list of some of the recommended packages.
 |[Apache Hive](/docs/databases/hive)|```pip install pyhive```|```hive://hive@{hostname}:{port}/{database}```|
 |[Apache Impala](/docs/databases/impala)|```pip install impala```|```impala://{hostname}:{port}/{database}```|
 |[Apache Kylin](/docs/databases/kylin)|```pip install kylinpy```|```kylin://<username>:<password>@<hostname>:<port>/<project>?<param1>=<value1>&<param2>=<value2>```|
-|[Apache Pinot](/docs/databases/pinot)|```pip install pinotdb```|```pinot+http://CONTROLLER:5436/ query?server=http://CONTROLLER:5983/```|
+|[Apache Pinot](/docs/databases/pinot)|```pip install pinotdb```|```pinot+http://BROKER:5436/query?server=http://CONTROLLER:5983/```|

Review comment:
       I strongly second this, we should drop the `+http`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org