You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by felixcheung <gi...@git.apache.org> on 2018/06/05 01:45:39 UTC

[GitHub] spark pull request #21462: [SPARK-24428][K8S] Fix unused code

Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21462#discussion_r192925875
  
    --- Diff: resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
    @@ -46,12 +46,6 @@ shift 1
     SPARK_CLASSPATH="$SPARK_CLASSPATH:${SPARK_HOME}/jars/*"
     env | grep SPARK_JAVA_OPT_ | sort -t_ -k4 -n | sed 's/[^=]*=\(.*\)/\1/g' > /tmp/java_opts.txt
     readarray -t SPARK_JAVA_OPTS < /tmp/java_opts.txt
    --- End diff --
    
    it would be confusing -- this is local though right, not exported?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org