You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/05/17 20:23:16 UTC

[GitHub] [iceberg] kbendick commented on a diff in pull request #4716: [CORE] - Add remaining parsers for MetadataUpdate implementations

kbendick commented on code in PR #4716:
URL: https://github.com/apache/iceberg/pull/4716#discussion_r875231131


##########
core/src/main/java/org/apache/iceberg/MetadataUpdate.java:
##########
@@ -234,6 +234,7 @@ public void applyTo(TableMetadata.Builder metadataBuilder) {
 
   class SetSnapshotRef implements MetadataUpdate {
     private final String name;
+    // TODO - this can be primitive.
     private final Long snapshotId;

Review Comment:
   TODO / possible follow up - This can be made primitive



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org