[GitHub] [hadoop] steveloughran commented on pull request #5465: YARN-11427. + YARN-11404. Pull up the versioned imports in pom of hadoop-mapreduce-client-app to hadoop-project pom

["steveloughran (via GitHub)" <gi...@apache.org>]

steveloughran commented on PR #5465:
URL: https://github.com/apache/hadoop/pull/5465#issuecomment-1533516959

   the pom move should be separate from the source changes.
   
   I really do not see the point in moving from the original junit calls to the jupiter ones. Seriously: why are we making our lives harder for ourselves unless/until they actually cut the old ones? At which point: why stay with the sessions from a project which is prepared to break existing code.
   
   I know there are some extra features, specifically java8 support and the ability to generate errors dynamically, but AssertJ is really good here and it can coexist with JUnit 4 quite happily.
   
   As you have already done the change, I am =0 on that move. However, be aware that if you ever ask me to review any tests in new code, my response will be "use AssertJ". Is if you don't know it yet -your future PR will be that opportunity. It is a lot better, despite its verbosity.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org