You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by catapan <gi...@git.apache.org> on 2016/05/29 18:53:58 UTC
[GitHub] spark pull request: SPARK-15641 do not show for incomplete applica...
GitHub user catapan opened a pull request:
https://github.com/apache/spark/pull/13396
SPARK-15641 do not show for incomplete application
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/catapan/spark SPARK-15641_fix_completed_column
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/13396.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13396
----
commit f2897b6aeb2a254f068d6e6703b7ba82d8ab0159
Author: Ziying Pan <ce...@ziyings-macbook.local>
Date: 2016-05-29T18:49:41Z
SPARK-15641 do not show for incomplete application
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-15641 HistoryServer to not show invalid ...
Posted by catapan <gi...@git.apache.org>.
Github user catapan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13396#discussion_r65014383
--- Diff: core/src/main/resources/org/apache/spark/ui/static/historypage.js ---
@@ -54,7 +54,8 @@ function makeIdNumeric(id) {
}
function formatDate(date) {
- return date.split(".")[0].replace("T", " ");
+ if (date <= 0) return "-";
--- End diff --
How about I spell it out as "Not available"? blank or "-" seems not very informative to the users.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-15641 HistoryServer to not show invalid date for i...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/13396
Merged to master/2.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-15641 HistoryServer to not show invalid ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13396#issuecomment-222389158
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-15641 HistoryServer to not show invalid date for i...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13396
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-15641 HistoryServer to not show invalid ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13396#issuecomment-222389122
**[Test build #59599 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59599/consoleFull)** for PR 13396 at commit [`f2897b6`](https://github.com/apache/spark/commit/f2897b6aeb2a254f068d6e6703b7ba82d8ab0159).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-15641 HistoryServer to not show invalid ...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13396#discussion_r65014109
--- Diff: core/src/main/resources/org/apache/spark/ui/static/historypage.js ---
@@ -54,7 +54,8 @@ function makeIdNumeric(id) {
}
function formatDate(date) {
- return date.split(".")[0].replace("T", " ");
+ if (date <= 0) return "-";
--- End diff --
_shrug_ I think blank or - is simpler and more general. I guess n/a takes a moment to parse as not applicable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-15641 do not show for incomplete applica...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13396#issuecomment-222376647
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-15641 do not show for incomplete applica...
Posted by tejasapatil <gi...@git.apache.org>.
Github user tejasapatil commented on the pull request:
https://github.com/apache/spark/pull/13396#issuecomment-222387582
nit: the title of the PR could be made better:
`[SPARK-15641] HistoryServer to not show invalid date for incomplete application`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-15641 HistoryServer to not show invalid ...
Posted by catapan <gi...@git.apache.org>.
Github user catapan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13396#discussion_r65076293
--- Diff: core/src/main/resources/org/apache/spark/ui/static/historypage.js ---
@@ -54,7 +54,8 @@ function makeIdNumeric(id) {
}
function formatDate(date) {
- return date.split(".")[0].replace("T", " ");
+ if (date <= 0) return "-";
--- End diff --
I see. But to me, blank indicates that something is wrong. "-" is a little better. So I changed it back to "-".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-15641 do not show for incomplete applica...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13396#issuecomment-222384278
**[Test build #59599 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59599/consoleFull)** for PR 13396 at commit [`f2897b6`](https://github.com/apache/spark/commit/f2897b6aeb2a254f068d6e6703b7ba82d8ab0159).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-15641 do not show for incomplete applica...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/13396#issuecomment-222384154
Jenkins test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-15641 HistoryServer to not show invalid ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13396#issuecomment-222389159
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59599/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-15641 do not show for incomplete applica...
Posted by tejasapatil <gi...@git.apache.org>.
Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/13396#discussion_r65013295
--- Diff: core/src/main/resources/org/apache/spark/ui/static/historypage.js ---
@@ -54,7 +54,8 @@ function makeIdNumeric(id) {
}
function formatDate(date) {
- return date.split(".")[0].replace("T", " ");
+ if (date <= 0) return "-";
--- End diff --
How about using "n/a" which would specifically indicate that its invalid to expect the end time ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-15641 HistoryServer to not show invalid ...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13396#discussion_r65073485
--- Diff: core/src/main/resources/org/apache/spark/ui/static/historypage.js ---
@@ -54,7 +54,8 @@ function makeIdNumeric(id) {
}
function formatDate(date) {
- return date.split(".")[0].replace("T", " ");
+ if (date <= 0) return "-";
--- End diff --
I personally think that just adds more noise to the screen. Sometimes the column value is a date, sometimes a text string then. Using a blank is the most natural "no value" to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-15641 do not show for incomplete applica...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13396#discussion_r65011946
--- Diff: core/src/main/resources/org/apache/spark/ui/static/historypage.js ---
@@ -54,7 +54,8 @@ function makeIdNumeric(id) {
}
function formatDate(date) {
- return date.split(".")[0].replace("T", " ");
+ if (date <= 0) return "-";
--- End diff --
I suppose I don't have a preference on "" vs "-". LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-15641 HistoryServer to not show invalid ...
Posted by catapan <gi...@git.apache.org>.
Github user catapan commented on the pull request:
https://github.com/apache/spark/pull/13396#issuecomment-222388056
revised as suggested. Thanks for the suggestions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org