You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/09/13 06:33:41 UTC

[PR] Refactor JDBC prepared statement parameter index [shardingsphere]

terrymanu opened a new pull request, #39827:
URL: https://github.com/apache/shardingsphere/pull/39827

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Refactor JDBC prepared statement parameter index [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39827:
URL: https://github.com/apache/shardingsphere/pull/39827#issuecomment-5651692737

   ### Result
   
   **Review Result: Mergeable**
   
   The change is correctly scoped and preserves parameter-binding behavior. No blocking issues were found. No changes recommended.
   
   ### Evidence
   
   - `JDBCBackendStatement.java:69` initializes `parameterIndex` at JDBC position `1`.
   - Both the `Types.OTHER` and regular parameter branches use `parameterIndex` directly.
   - Iteration count, parameter order, exception propagation, and integer increment behavior remain unchanged.
   - `JDBCBackendStatementTest`: 6 tests passed, with 0 failures and 0 errors.
   - Spotless: Passed for the target file.
   - Checkstyle: 0 violations.
   - `git diff --check`: Passed.
   
   ### Coverage
   
   - Candidate type: Standalone local change.
   - Baseline: `60ff6e83d60ca8137717fab2e8bdd5fdeaba0e36`.
   - Reviewed file: `proxy/backend/core/src/main/java/org/apache/shardingsphere/proxy/backend/connector/jdbc/statement/JDBCBackendStatement.java`.
   - Reviewed areas: loop boundaries, both parameter types, empty parameter path, prepared-statement reuse path, exception semantics, formatting, and coding standards.
   - Blocking issues: 0.
   - Unresolved evidence gaps: None.
   - This result covers code correctness only; remote CI was not reviewed.
   - Other concurrent workspace changes were excluded from the candidate scope.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Refactor JDBC prepared statement parameter index [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39827:
URL: https://github.com/apache/shardingsphere/pull/39827


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org