[jira] [Resolved] (ARROW-407) BitVector.copyFromSafe() should re-allocate if necessary instead of returning false

["SIDDHARTH TEOTIA (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARROW-407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

SIDDHARTH TEOTIA resolved ARROW-407.
------------------------------------
    Resolution: Fixed

Issue seems to have already been fixed.

> BitVector.copyFromSafe() should re-allocate if necessary instead of returning false
> -----------------------------------------------------------------------------------
>
>                 Key: ARROW-407
>                 URL: https://issues.apache.org/jira/browse/ARROW-407
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: Java - Vectors
>            Reporter: Deneche A. Hakim
>            Assignee: Deneche A. Hakim
>
> Current implementation:
> {code}
> public boolean copyFromSafe(int inIndex, int outIndex, BitVector from) {
>     if (outIndex >= this.getValueCapacity()) {
>       decrementAllocationMonitor();
>       return false;
>     }
>     copyFrom(inIndex, outIndex, from);
>     return true;
>   }
> {code}
> doesn't match the expectation from "safe" methods. The method should try to re-allocate if it's running out of space instead of returning false



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)