You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "wegod (via GitHub)" <gi...@apache.org> on 2023/03/01 09:23:27 UTC
[GitHub] [dubbo] wegod opened a new pull request, #11697: fix bug https://github.com/apache/dubbo/issues/11644
wegod opened a new pull request, #11697:
URL: https://github.com/apache/dubbo/pull/11697
## What is the purpose of the change
fix bug see https://github.com/apache/dubbo/issues/11644
## Brief changelog
Add compatible method of com.alibaba.dubbo.rpc.Result and com.alibaba.dubbo.rpc.Invoker
## Verifying this change
I test calling 2.6.x's method both sync and async
<!-- Follow this checklist to help us incorporate your contribution quickly and easily: -->
## Checklist
- [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature.
- [ ] GitHub Actions works fine on your own branch.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] wegod closed pull request #11697: fix bug https://github.com/apache/dubbo/issues/11644
Posted by "wegod (via GitHub)" <gi...@apache.org>.
wegod closed pull request #11697: fix bug https://github.com/apache/dubbo/issues/11644
URL: https://github.com/apache/dubbo/pull/11697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on pull request #11697: fix bug https://github.com/apache/dubbo/issues/11644
Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ commented on PR #11697:
URL: https://github.com/apache/dubbo/pull/11697#issuecomment-1455574165
> > Please change the target branch to `3.1`. 2.7.x will EOL in this month.
>
> We have many projects using dubbo, it's hard to push migrate to 3.x. We want to migrate to 2.7.x first. Please consider merge to 2.7.x first, thanks
The 2.7.x branch will not have any new releases, so you won't be able to use it even if it is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] wegod commented on pull request #11697: fix bug https://github.com/apache/dubbo/issues/11644
Posted by "wegod (via GitHub)" <gi...@apache.org>.
wegod commented on PR #11697:
URL: https://github.com/apache/dubbo/pull/11697#issuecomment-1455691552
> The 2.7.x branch will not have any new releases, so you won't be able to use it even if it is merged.
Well, I changed the target branch to 3.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter commented on pull request #11697: fix bug https://github.com/apache/dubbo/issues/11644
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11697:
URL: https://github.com/apache/dubbo/pull/11697#issuecomment-1451038198
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/11697?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#11697](https://codecov.io/gh/apache/dubbo/pull/11697?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (130393a) into [master](https://codecov.io/gh/apache/dubbo/commit/4f664f0a3d338673f4b554230345b89c580bccbb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4f664f0) will **decrease** coverage by `0.19%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #11697 +/- ##
============================================
- Coverage 60.17% 59.98% -0.19%
- Complexity 444 445 +1
============================================
Files 1100 1100
Lines 44487 44489 +2
Branches 6457 6457
============================================
- Hits 26769 26688 -81
- Misses 14766 14855 +89
+ Partials 2952 2946 -6
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/11697?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/src/main/java/com/alibaba/dubbo/rpc/Invoker.java](https://codecov.io/gh/apache/dubbo/pull/11697?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9JbnZva2VyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...le/src/main/java/com/alibaba/dubbo/rpc/Result.java](https://codecov.io/gh/apache/dubbo/pull/11697?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9SZXN1bHQuamF2YQ==) | `10.25% <0.00%> (-0.27%)` | :arrow_down: |
| [...a/org/apache/dubbo/rpc/filter/AccessLogFilter.java](https://codecov.io/gh/apache/dubbo/pull/11697?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvQWNjZXNzTG9nRmlsdGVyLmphdmE=) | `29.23% <0.00%> (-49.24%)` | :arrow_down: |
| [...va/org/apache/dubbo/rpc/support/AccessLogData.java](https://codecov.io/gh/apache/dubbo/pull/11697?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9zdXBwb3J0L0FjY2Vzc0xvZ0RhdGEuamF2YQ==) | `53.16% <0.00%> (-37.98%)` | :arrow_down: |
| [...org/apache/dubbo/registry/dubbo/DubboRegistry.java](https://codecov.io/gh/apache/dubbo/pull/11697?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktZGVmYXVsdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVnaXN0cnkvZHViYm8vRHViYm9SZWdpc3RyeS5qYXZh) | `42.00% <0.00%> (-14.00%)` | :arrow_down: |
| [...apache/dubbo/common/config/ConfigurationUtils.java](https://codecov.io/gh/apache/dubbo/pull/11697?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL0NvbmZpZ3VyYXRpb25VdGlscy5qYXZh) | `58.06% <0.00%> (-6.46%)` | :arrow_down: |
| [...fig/configcenter/TreePathDynamicConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/11697?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL2NvbmZpZ2NlbnRlci9UcmVlUGF0aER5bmFtaWNDb25maWd1cmF0aW9uLmphdmE=) | `25.71% <0.00%> (-5.72%)` | :arrow_down: |
| [...in/java/org/apache/dubbo/common/utils/JVMUtil.java](https://codecov.io/gh/apache/dubbo/pull/11697?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvSlZNVXRpbC5qYXZh) | `75.47% <0.00%> (-5.67%)` | :arrow_down: |
| [...g/p2p/exchange/support/MulticastExchangeGroup.java](https://codecov.io/gh/apache/dubbo/pull/11697?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctcDJwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9wMnAvZXhjaGFuZ2Uvc3VwcG9ydC9NdWx0aWNhc3RFeGNoYW5nZUdyb3VwLmphdmE=) | `77.50% <0.00%> (-5.00%)` | :arrow_down: |
| [...pport/merger/DefaultProviderURLMergeProcessor.java](https://codecov.io/gh/apache/dubbo/pull/11697?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9tZXJnZXIvRGVmYXVsdFByb3ZpZGVyVVJMTWVyZ2VQcm9jZXNzb3IuamF2YQ==) | `78.26% <0.00%> (-4.35%)` | :arrow_down: |
| ... and [24 more](https://codecov.io/gh/apache/dubbo/pull/11697?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] wegod commented on pull request #11697: fix bug https://github.com/apache/dubbo/issues/11644
Posted by "wegod (via GitHub)" <gi...@apache.org>.
wegod commented on PR #11697:
URL: https://github.com/apache/dubbo/pull/11697#issuecomment-1453150969
> Please change the target branch to `3.1`. 2.7.x will EOL in this month.
We have many projects using dubbo, it's hard to push migrate to 3.x. We want to migrate to 2.7.x first.
Please consider merge to 2.7.x first, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org