[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #9445: [Feature] [ALERT-9406]enrich alert info when insert new row into DB

[GitBox <gi...@apache.org>]

caishunfeng commented on code in PR #9445:
URL: https://github.com/apache/dolphinscheduler/pull/9445#discussion_r847907715


##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/AlertType.java:
##########
@@ -24,13 +24,17 @@
  */
 public enum AlertType {
     /**
-     * 0 process instance failure; 1 process instance success, 2 fault tolerance warning, 3 task failure, 4 task success
-     */
+     * 0 process instance failure, 1 process instance success, 2 process instance blocked, 3 process instance timeout, 4 fault tolerance warning,
+     * 5 task failure, 6 task success, 7 task timeout
+      */
     PROCESS_INSTANCE_FAILURE(0, "process instance failure"),
     PROCESS_INSTANCE_SUCCESS(1, "process instance success"),
-    FAULT_TOLERANCE_WARNING(2, "fault tolerance warning"),

Review Comment:
   Why to change the code? I think it's not good for upgrade.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org